Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200203154517.2347-1-tiny.windzz@gmail.com>
In-Reply-To: <20200203154517.2347-1-tiny.windzz@gmail.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Mon, 3 Feb 2020 16:57:52 +0100
Message-ID: <CAJZ5v0hRnCXqDhee4UENYzqka3--2Vhnu3TWikrWJtGcq6aimA@mail.gmail.com>
Subject: Re: [PATCH] cpufreq: make cpufreq_global_kobject static
To:     Yangtao Li <tiny.windzz@gmail.com>
Cc:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Linux PM <linux-pm@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Feb 3, 2020 at 4:45 PM Yangtao Li <tiny.windzz@gmail.com> wrote:
>
> The cpufreq_global_kobject is only used internally by cpufreq.c
> after this:
>
> commit 2361be236662 ("cpufreq: Don't create empty
> /sys/devices/system/cpu/cpufreq directory")
>
> Make it static.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
>  drivers/cpufreq/cpufreq.c | 4 +---
>  include/linux/cpufreq.h   | 3 ---
>  2 files changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 4adac3a8c265..a0831d3d5ed1 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -105,6 +105,7 @@ bool have_governor_per_policy(void)
>  }
>  EXPORT_SYMBOL_GPL(have_governor_per_policy);
>
> +static struct kobject *cpufreq_global_kobject;
>  struct kobject *get_governor_parent_kobj(struct cpufreq_policy *policy)
>  {
>         if (have_governor_per_policy())
> @@ -2745,9 +2746,6 @@ int cpufreq_unregister_driver(struct cpufreq_driver *driver)
>  }
>  EXPORT_SYMBOL_GPL(cpufreq_unregister_driver);
>
> -struct kobject *cpufreq_global_kobject;
> -EXPORT_SYMBOL(cpufreq_global_kobject);
> -
>  static int __init cpufreq_core_init(void)
>  {
>         if (cpufreq_disabled())
> diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
> index 018dce868de6..0fb561d1b524 100644
> --- a/include/linux/cpufreq.h
> +++ b/include/linux/cpufreq.h
> @@ -201,9 +201,6 @@ static inline bool policy_is_shared(struct cpufreq_policy *policy)
>         return cpumask_weight(policy->cpus) > 1;
>  }
>
> -/* /sys/devices/system/cpu/cpufreq: entry point for global variables */
> -extern struct kobject *cpufreq_global_kobject;
> -
>  #ifdef CONFIG_CPU_FREQ
>  unsigned int cpufreq_get(unsigned int cpu);
>  unsigned int cpufreq_quick_get(unsigned int cpu);
> --

Applied as 5.6 material with minor modification, thanks!