Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4011518ybl; Mon, 3 Feb 2020 10:48:45 -0800 (PST) X-Google-Smtp-Source: APXvYqxr2kfErIo0gfEY6JPTF4TcGXG+otPsQkku1RDlaqpCtnXJn35INj48IJ4zSy+V9Z4MwOD9 X-Received: by 2002:a9d:729c:: with SMTP id t28mr18988453otj.66.1580755725304; Mon, 03 Feb 2020 10:48:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580755725; cv=none; d=google.com; s=arc-20160816; b=itm+Dk3U5S3Z6/wthozHjOtoEIJs8YZ/b6nytA2gx6WfY0yH6NGNvE2KVYkvUFVRJC DVtpzGpqUzjpncfPIy3JxsOnwGh3/ch2V5QjAo4uKNVzcBci0hV+OiCFrXU6BOG3FBnc HeHGRiuyqlT4EQ/qe2YuTR77dMdqBQYY5J8sbzT0JoiuXwLYeBv1fjaSSiD8fftqnmXE MOWLAxG6R1jFOlc0CVVUg+kjmx2+6EfqI081gbDnWLQyMrDDwZUSjRQ3Q8faQucxvZX9 B2FPF5nMllaZFJ3NgqNLRwmQ/8tymvJ7H6eUJ3KZWKgLlrVUkth9YatzbUmBsadZh1i7 oyjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=pGXJQkhFdYBCzrlChxpGq39ucfcYr5bBlrz5dC+Y++s=; b=eFMF8ONnUymrxzubvcmCwm8AFSXiJEm1+xgvIiQPkzJS4jMTHQmRp8baPExhIwr/c+ r2LEDV4vbCbh12X57n4ZsV8St9m+UiCerDwZcQffkoztQhacV7/GqWUooexwUGe+VoNy 7x6djxDG4LY3NVChJWUB7cl6iQB+AEf2CoCYNnb52iaQiSYe1zqNXp+PwGMbojkbjJeX nj/6AVAWCStC9jyYyTXKzkxztS+0c8nWRBf23rPEYr+zuBGwFOq8EPraiYwJBh/7ggRj GBzXPwzgintf5KJkcCLoce/xy45HJUkIN18DderHW6Sj6fifsaYqIFy+lK6duWUMV3qb 4MJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mn6k5hRt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g15si3829091otp.153.2020.02.03.10.48.33; Mon, 03 Feb 2020 10:48:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mn6k5hRt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729196AbgBCQf4 (ORCPT + 98 others); Mon, 3 Feb 2020 11:35:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:50918 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730553AbgBCQfx (ORCPT ); Mon, 3 Feb 2020 11:35:53 -0500 Received: from localhost (unknown [104.132.45.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 801552051A; Mon, 3 Feb 2020 16:35:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580747752; bh=W7OtS8SI7erFGisFYGpsxO0NJjdpkZVRWfwp69rcqY8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mn6k5hRthNhc7+g3TUmPgrSkE9/QWt/G+RZMpVDa+b/N9e/qyzkauRR3Tgm9atdMq dobvJ3dspi1GS/FZ9tSIKBR/v0EJFOezQ940yRrF1ZiplwC24tYRh27qGMj8gyg6Al iUjVXVh7HngNWlMMnpQT7s0UIRZkFum6WR+gt8y4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hans Verkuil , Mauro Carvalho Chehab , syzbot+32310fc2aea76898d074@syzkaller.appspotmail.com, syzbot+99706d6390be1ac542a2@syzkaller.appspotmail.com, syzbot+64437af5c781a7f0e08e@syzkaller.appspotmail.com Subject: [PATCH 5.4 18/90] media: gspca: zero usb_buf Date: Mon, 3 Feb 2020 16:19:21 +0000 Message-Id: <20200203161920.107897723@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200203161917.612554987@linuxfoundation.org> References: <20200203161917.612554987@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hans Verkuil commit de89d0864f66c2a1b75becfdd6bf3793c07ce870 upstream. Allocate gspca_dev->usb_buf with kzalloc instead of kmalloc to ensure it is property zeroed. This fixes various syzbot errors about uninitialized data. Syzbot links: https://syzkaller.appspot.com/bug?extid=32310fc2aea76898d074 https://syzkaller.appspot.com/bug?extid=99706d6390be1ac542a2 https://syzkaller.appspot.com/bug?extid=64437af5c781a7f0e08e Reported-and-tested-by: syzbot+32310fc2aea76898d074@syzkaller.appspotmail.com Reported-and-tested-by: syzbot+99706d6390be1ac542a2@syzkaller.appspotmail.com Reported-and-tested-by: syzbot+64437af5c781a7f0e08e@syzkaller.appspotmail.com Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/usb/gspca/gspca.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/media/usb/gspca/gspca.c +++ b/drivers/media/usb/gspca/gspca.c @@ -1461,7 +1461,7 @@ int gspca_dev_probe2(struct usb_interfac pr_err("couldn't kzalloc gspca struct\n"); return -ENOMEM; } - gspca_dev->usb_buf = kmalloc(USB_BUF_SZ, GFP_KERNEL); + gspca_dev->usb_buf = kzalloc(USB_BUF_SZ, GFP_KERNEL); if (!gspca_dev->usb_buf) { pr_err("out of memory\n"); ret = -ENOMEM;