Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4022308ybl; Mon, 3 Feb 2020 11:02:33 -0800 (PST) X-Google-Smtp-Source: APXvYqw4gsFgY+fu7bgC3kRgORmrSPz+sGSGuHcEIh2VNxLDeZ2FX5C2075ixIwy43MyNJgOlFY2 X-Received: by 2002:a9d:12f1:: with SMTP id g104mr17911476otg.149.1580756553641; Mon, 03 Feb 2020 11:02:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580756553; cv=none; d=google.com; s=arc-20160816; b=z4N+PDJ2h//Y7s6WbIk9mm/SKvGia5Zc0mVElOXllZ7x2YPGeBiQBpD8asQJRdJ+tR 67s9rtb1s6BC6n6PCN4ig0w4LI4I/V9HgjwjjmZWs3Raa5TkhmmZ93aCsSdA0FlKxXad MK1ejE0Ym9wINxQYuqE9NUwaVeU7jET61w1BcnOgatWX6Bw4/uh131zIa1sq6Ik8SsHm TxrVWca5oEjjDF40D480JnujhYgX5/V8RsOd9hfOFA5DCNogujTGdPOhVBXqxVT/A+LZ INjKgdp3wSe6a6JZ4xKsD0hSEgAP8jqodAcWNOh6WZx00ggI7+FZ8U9QnWg5407O1IWK dvKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=DimJTdmqaA8dk7zUeRcKTkrUVtAbqIhU1ee4edlyW4A=; b=JxEpy9huJ0nyWXbrhR7FmBzRXtRIi/ai7pvWAPjdNeylJl+eAKPkShBWVzaVMpjtM0 2HbjWVzD8oGA222smO/v3xUMJO8uWxi9NT2FvHKdJcMmOvg8hLUbDdotMsYwv3QwJ/FD SLRpQ29VtPm+ar18ntAbsBZx3S9ZAGKypWmRp/cZErRNtdcjR5rKhVXPyOokGSf1C3lq aMSBuVvTeJ2Z7y+YS2tkt0jAtU7dI7FbElOes4MqiSVsJfU9534cDgonGN3n4/nyZ9BC cY+C/DxlGmhWwXOINTZjpDsXELo5fuLTKLxkR5LIHGKJzWUxF75mgL/rnkrShQwYtKF1 WezQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="nT0/8gMh"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c64si8634928oig.178.2020.02.03.11.02.19; Mon, 03 Feb 2020 11:02:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="nT0/8gMh"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727445AbgBCQWz (ORCPT + 99 others); Mon, 3 Feb 2020 11:22:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:60618 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728204AbgBCQUn (ORCPT ); Mon, 3 Feb 2020 11:20:43 -0500 Received: from localhost (unknown [104.132.45.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4D9EC2086A; Mon, 3 Feb 2020 16:20:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580746842; bh=UMNkywr2kghPfVriFgzkLLTwv2Xm+B2fKeuP25mKzTA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nT0/8gMh2SVk26jl/RIk4TLsoKNKEjFr35BZ6iMiQUWDmePDzXBIyLUhNWkudEup/ Um23q0it9TBDcNuPEPRo6vdD0v4PGKXoBAhxcJQYYajM608A6zGK3+K4qWXFJhhnsv rKEnYeFr/Yi5nTtG+DM7acfaZtRGrL1U2xMjfIec= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hans Verkuil , Mauro Carvalho Chehab , syzbot+32310fc2aea76898d074@syzkaller.appspotmail.com, syzbot+99706d6390be1ac542a2@syzkaller.appspotmail.com, syzbot+64437af5c781a7f0e08e@syzkaller.appspotmail.com Subject: [PATCH 4.4 29/53] media: gspca: zero usb_buf Date: Mon, 3 Feb 2020 16:19:21 +0000 Message-Id: <20200203161908.365893015@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200203161902.714326084@linuxfoundation.org> References: <20200203161902.714326084@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hans Verkuil commit de89d0864f66c2a1b75becfdd6bf3793c07ce870 upstream. Allocate gspca_dev->usb_buf with kzalloc instead of kmalloc to ensure it is property zeroed. This fixes various syzbot errors about uninitialized data. Syzbot links: https://syzkaller.appspot.com/bug?extid=32310fc2aea76898d074 https://syzkaller.appspot.com/bug?extid=99706d6390be1ac542a2 https://syzkaller.appspot.com/bug?extid=64437af5c781a7f0e08e Reported-and-tested-by: syzbot+32310fc2aea76898d074@syzkaller.appspotmail.com Reported-and-tested-by: syzbot+99706d6390be1ac542a2@syzkaller.appspotmail.com Reported-and-tested-by: syzbot+64437af5c781a7f0e08e@syzkaller.appspotmail.com Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/usb/gspca/gspca.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/media/usb/gspca/gspca.c +++ b/drivers/media/usb/gspca/gspca.c @@ -2028,7 +2028,7 @@ int gspca_dev_probe2(struct usb_interfac pr_err("couldn't kzalloc gspca struct\n"); return -ENOMEM; } - gspca_dev->usb_buf = kmalloc(USB_BUF_SZ, GFP_KERNEL); + gspca_dev->usb_buf = kzalloc(USB_BUF_SZ, GFP_KERNEL); if (!gspca_dev->usb_buf) { pr_err("out of memory\n"); ret = -ENOMEM;