Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4023481ybl; Mon, 3 Feb 2020 11:03:34 -0800 (PST) X-Google-Smtp-Source: APXvYqwTtet3GvFPdP8oEdVk7CesLkXyYqHEwdawwMGWr+Xjh4N/aRAHfn+fxCyER42xCWZr4j4d X-Received: by 2002:a9d:65cb:: with SMTP id z11mr17710006oth.348.1580756614346; Mon, 03 Feb 2020 11:03:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580756614; cv=none; d=google.com; s=arc-20160816; b=woKfI4Qq1tWrG4KyxFZUAYq0xXILofY8/f8hiouZIRCHw2ZID0J4iICcpVOFjnl7mF 1oVMGvpiHFsWsJqdJe38JghZuPyd6UT+71OxU1lr6jXb8HMiH9imAToQPM/di7a6FaxE e1YsDNlfSwr6axyP24hR9N6bm0eCsbZzHQLZvKigpHlVjjJ6CVcFHDGZMWBlmhEFgM25 U+K6f7z5VXKoejIpDePTU55OmVLVyp7kKYmdtvFLCU+Bd5dZdl4jvyc7ebQSCZ4A69TV cqoZqrNSlzZGIdHVH/a4Z97tWcLGDBvM9QsTOAEbdAkpD+BH/aMHdJeCgNbpdbuvTlV/ 8F8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Dtp6ABsArvOGziOf04+D+qMtM+9qyciDkgjHcM2pTCE=; b=GEqfKyog4+d+g2GTsm8q8iTLoSW0VbXB2/JWOlQiwkHO0EU6I5zyU3roHwZig/palD JMqpBZj8FpnZJtC5ABAXLvlfBg79uQwbGx5qBtyRZoKxhOTb75kAwTsodiTMmDI/5pMI ptbijSXbeZ65k9O5KtfULb6p3SO6RKm/LqgVtcEZqSYrBuwZCSFQ6Kb/yCnY5CB163Pt 8L++kuxXAupBBCD44zYbJzoPZfLPchNwvv8epp5pMKm3Sr395auD3IQUgvC1RqBElUiK oMKqaFym/Y4qgNvBtmJlvWSyl4jHDJM5YWl+z6GECCLtX3h9nup6YRMn/oytCecuepuY ezfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jKRLO2EE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h3si10146258otq.203.2020.02.03.11.03.22; Mon, 03 Feb 2020 11:03:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jKRLO2EE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729287AbgBCQ0u (ORCPT + 99 others); Mon, 3 Feb 2020 11:26:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:37898 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729252AbgBCQ0t (ORCPT ); Mon, 3 Feb 2020 11:26:49 -0500 Received: from localhost (unknown [104.132.45.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 95EF82086A; Mon, 3 Feb 2020 16:26:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580747208; bh=V/URwyR45V2UVqCc6dN8N9EyzaFjT5CgEyR/Gyu1eyM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jKRLO2EEq/pt5OBA4U7Bf2h313ByZa0ZXWoeUukXQOQHmX/1ia98P0+ffkhme3Org u1Dnqpb8AeZqBAvqsNltcvpuUGylLd0H0UnEsCGZqmgXYR6F1R6NGQ8zKURbFkkt01 u2qBrdaj0uF/z9FuEnWLuRWNTtfcrkvqcXpQQOt0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hayes Wang , "David S. Miller" , Sasha Levin Subject: [PATCH 4.9 57/68] r8152: get default setting of WOL before initializing Date: Mon, 3 Feb 2020 16:19:53 +0000 Message-Id: <20200203161914.352721176@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200203161904.705434837@linuxfoundation.org> References: <20200203161904.705434837@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hayes Wang [ Upstream commit 9583a3638dc07cc1878f41265e85ed497f72efcb ] Initailization would reset runtime suspend by tp->saved_wolopts, so the tp->saved_wolopts should be set before initializing. Signed-off-by: Hayes Wang Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/usb/r8152.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 3c037b76a0cc8..ba7cfc0895165 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -4441,6 +4441,11 @@ static int rtl8152_probe(struct usb_interface *intf, intf->needs_remote_wakeup = 1; + if (!rtl_can_wakeup(tp)) + __rtl_set_wol(tp, 0); + else + tp->saved_wolopts = __rtl_get_wol(tp); + tp->rtl_ops.init(tp); queue_delayed_work(system_long_wq, &tp->hw_phy_work, 0); set_ethernet_addr(tp); @@ -4454,10 +4459,6 @@ static int rtl8152_probe(struct usb_interface *intf, goto out1; } - if (!rtl_can_wakeup(tp)) - __rtl_set_wol(tp, 0); - - tp->saved_wolopts = __rtl_get_wol(tp); if (tp->saved_wolopts) device_set_wakeup_enable(&udev->dev, true); else -- 2.20.1