Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4023506ybl; Mon, 3 Feb 2020 11:03:35 -0800 (PST) X-Google-Smtp-Source: APXvYqwvjDaHX6jxahXwtElUmtxD8zs3xkIW3arR84LnVLEl/z9p0RAAElVxFoWjSfbsfLBso3Ov X-Received: by 2002:a9d:6a48:: with SMTP id h8mr19057413otn.264.1580756615684; Mon, 03 Feb 2020 11:03:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580756615; cv=none; d=google.com; s=arc-20160816; b=UFgboGFXJUwR1UDSbqRkaCsV63mdnT8HXE5y9QAruvAGPna6vAw8OlhxqKXODJ4p5P h85NjYnsg7GxE5mEXcthRQI9MGphRZ8+v/9GcOdOxOMpSWrfPURkZIvGijxve9N0CqMM n2PP+ei5bHCgl5f2W5hQg92f52svBkfbU0wl38Uo9ZChQYKa9TxYFA9MmfK7XibKQtho l32wgGPCZ56owXYxbajhrtiqdNJZdlt/F4HkWVRdBsKUyjJr5mAFqn0nMCiVJIpBUYui 4HtCYJGv8lkDe2MJJY/YDOCkLKgtwOchGRx4QV6sF3f6NdUM1pMegXXaDoTgxWLWzvS9 r3uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=H9Qzfiu6e/oEIgwANzfd95ouLhwy/NAXjqoMu1JP1bQ=; b=NYfGuD/8cWopIRKCemkVJouSGQ7SKIARQgREFMXa0TL8t2Cn15o7HuIc6Y9Fs+viF5 RMLs6qYmCn3sg+zEAWKBB9S6lftvlPmF1e7KGId4DCw1XylYgIW7QEPAeGUcn5it4R7p G2Ce24iAFfgQX1XSnxmAIpXOZYm8xVmyt7IA0kv5rn3akUGG2YV/jd5bEtrKKbECwsDJ CPsmUVyPDsSap0axAbHP9u2gv3JyfwN8CUOtJaw6A0kHQKFABsDvzx0vqQyaZHv/riRf X5n8f1VkawpcdyDOQxfJxGqGa8F27XCVT9Ed4C3L+T3K9kxQc6kaPVBtYU3PsBZPdmMh jZhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RwW46wH4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m14si9557616otr.131.2020.02.03.11.03.23; Mon, 03 Feb 2020 11:03:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RwW46wH4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728903AbgBCQ0G (ORCPT + 99 others); Mon, 3 Feb 2020 11:26:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:36946 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728882AbgBCQ0D (ORCPT ); Mon, 3 Feb 2020 11:26:03 -0500 Received: from localhost (unknown [104.132.45.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A5A002080C; Mon, 3 Feb 2020 16:26:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580747162; bh=UteHNnpLt/O9YQ6oHAMfw8GJtA0rGXMaFuZvPNpQoR0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RwW46wH4oj+MabdomE9w58XUEX4YLjKkssxkMRSS6zsDeeKyWzXxd34D16B6XWGhR aSzmkXKRXXLYMEhXq6awDkx52zInMFe3gsmiXfR5LFW3cqPzlgxJqYk4/DR5N4pcBu TTPeRCvy8ufKBS5TFySKLAdReyxI8K+XRGZLMvm8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hans Verkuil , Mauro Carvalho Chehab , syzbot+32310fc2aea76898d074@syzkaller.appspotmail.com, syzbot+99706d6390be1ac542a2@syzkaller.appspotmail.com, syzbot+64437af5c781a7f0e08e@syzkaller.appspotmail.com Subject: [PATCH 4.9 36/68] media: gspca: zero usb_buf Date: Mon, 3 Feb 2020 16:19:32 +0000 Message-Id: <20200203161910.889671568@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200203161904.705434837@linuxfoundation.org> References: <20200203161904.705434837@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hans Verkuil commit de89d0864f66c2a1b75becfdd6bf3793c07ce870 upstream. Allocate gspca_dev->usb_buf with kzalloc instead of kmalloc to ensure it is property zeroed. This fixes various syzbot errors about uninitialized data. Syzbot links: https://syzkaller.appspot.com/bug?extid=32310fc2aea76898d074 https://syzkaller.appspot.com/bug?extid=99706d6390be1ac542a2 https://syzkaller.appspot.com/bug?extid=64437af5c781a7f0e08e Reported-and-tested-by: syzbot+32310fc2aea76898d074@syzkaller.appspotmail.com Reported-and-tested-by: syzbot+99706d6390be1ac542a2@syzkaller.appspotmail.com Reported-and-tested-by: syzbot+64437af5c781a7f0e08e@syzkaller.appspotmail.com Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/usb/gspca/gspca.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/media/usb/gspca/gspca.c +++ b/drivers/media/usb/gspca/gspca.c @@ -2043,7 +2043,7 @@ int gspca_dev_probe2(struct usb_interfac pr_err("couldn't kzalloc gspca struct\n"); return -ENOMEM; } - gspca_dev->usb_buf = kmalloc(USB_BUF_SZ, GFP_KERNEL); + gspca_dev->usb_buf = kzalloc(USB_BUF_SZ, GFP_KERNEL); if (!gspca_dev->usb_buf) { pr_err("out of memory\n"); ret = -ENOMEM;