Date: Sat, 4 Feb 2006 18:00:26 -0800
From: Paul Jackson <pj@sgi.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: christoph@lameter.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org,
       manfred@colorfullife.com
Subject: Re: [RFT/PATCH] slab: consolidate allocation paths
Message-Id: <20060204180026.b68e9476.pj@sgi.com>
In-Reply-To: <1139070779.21489.5.camel@localhost>
References: <1139060024.8707.5.camel@localhost>
	<Pine.LNX.4.62.0602040709210.31909@graphe.net>
	<1139070369.21489.3.camel@localhost>
	<1139070779.21489.5.camel@localhost>
Organization: SGI
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1078
Lines: 25

This consolidation patch looks ok to me on first read, though others
are certainly more expert in this code than I am.  Certainly cleanup,
ifdef reduction and consolidation of mm/slab.c is a worthwhile goal.
That code is rough for folks like me to follow.

Two issues I can see:

  1) This patch increased the text size of mm/slab.o by 776
     bytes (ia64 sn2_defconfig gcc 3.3.3), which should be
     justified.  My naive expectation would have been that
     such a source code consolidation patch would be text
     size neutral, or close to it.

  2) You might want to hold off this patch for a few days,
     until the dust settles from my memory spread patch.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/