Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4024712ybl; Mon, 3 Feb 2020 11:04:48 -0800 (PST) X-Google-Smtp-Source: APXvYqxRk5O7+Vxe/SZmn2PVAt5Kt+Z/wxWPK9+WB2AEW5egqCFMKpVFWQosczNLToA+BlB6x2N7 X-Received: by 2002:a05:6808:10b:: with SMTP id b11mr371957oie.110.1580756688376; Mon, 03 Feb 2020 11:04:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580756688; cv=none; d=google.com; s=arc-20160816; b=aOsUJ75iPUEjP+x2DVoUqH7ja9mMHvGVueJ6cLMIi8U//CbWxz/1buGvigWXQIclxq R0IgZbnTkA4koaBL0g7pEihd/q3OrN8T9miP1MNgN2mci+4OUhNpMQED6kpaHkKAfZXI qBnpVoW2u5+wxVrT9sy+ENlvTlhc2Vh5CSQDhM4erW481Ir32kLC4IJAKkxTTBsQ5aAv TwP+MThQL5ivJxE1Le/ociQUPHJez+iYczi9ta/wm4FSO5zwnc3UbyI6GqSI5JdTJvb9 Ve+uHltMi/sU3mtdc/w5RIuRu9e4XhpVELFLZzvtUVneHVDJ3g1uFOpdQTST+rQE5zeu eJ3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=7p4dN2MwkjnXLoGIOdUvyKDeBRbLnpqvmSdZReZP7cM=; b=nOk+V9XD+3ViByG73SHoCJiPn4qBEOW2SsaVnSYTbxuWMC6CwUzSdui2Dyx8Qs0vfO 9FO32iw/f9Amt51iZ7zXG1mLgqZwVv6GeCEB4DWnFSQU5c/CtDdUdRH4xl/vPUREl/po B5Ke5n3m77WgXV1oyRchZs+E5D1btHsUF87CPaFwzssMzM1hgQJaVk9zNYtScbsjBwRQ bqZ8R/5tfLTiJXAUGM3lluadXfupuQBhsGe2nKZt/zT4EfVFEkIfebtsxftuvMyGMFPr eaeJrRyqFzAeLAOGzZVK6+H821+qOfc6AfYSzKUIJfQXskjhGOqhi2EWXryu4+ahpKiW BfGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Rj9dmXNH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i78si8632890oib.1.2020.02.03.11.04.35; Mon, 03 Feb 2020 11:04:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Rj9dmXNH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729743AbgBCQ3M (ORCPT + 99 others); Mon, 3 Feb 2020 11:29:12 -0500 Received: from mail.kernel.org ([198.145.29.99]:41074 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729734AbgBCQ3L (ORCPT ); Mon, 3 Feb 2020 11:29:11 -0500 Received: from localhost (unknown [104.132.45.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EA1D92080C; Mon, 3 Feb 2020 16:29:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580747351; bh=nbVpVw4p1VfuJ7QN8lurRGFg/BN8CBl5Bc8vLSaxQwY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Rj9dmXNHPCVFpeP4h1Di+GXIZJdMa3u7R58PaWxYO78GDl+kRr/wod3MlTcY2bq0X nJHISJ4RqOMQ4KwBtPZYhh0tgBC7HL2lJMaS9mdYSWAjM/nsdYrHTicYMTBMSr1jx0 ira56NUWOBSagGCgY6qrUVyPWQ70OVTuX310tY4Y= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hans Verkuil , Mauro Carvalho Chehab , syzbot+32310fc2aea76898d074@syzkaller.appspotmail.com, syzbot+99706d6390be1ac542a2@syzkaller.appspotmail.com, syzbot+64437af5c781a7f0e08e@syzkaller.appspotmail.com Subject: [PATCH 4.14 47/89] media: gspca: zero usb_buf Date: Mon, 3 Feb 2020 16:19:32 +0000 Message-Id: <20200203161923.290659014@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200203161916.847439465@linuxfoundation.org> References: <20200203161916.847439465@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hans Verkuil commit de89d0864f66c2a1b75becfdd6bf3793c07ce870 upstream. Allocate gspca_dev->usb_buf with kzalloc instead of kmalloc to ensure it is property zeroed. This fixes various syzbot errors about uninitialized data. Syzbot links: https://syzkaller.appspot.com/bug?extid=32310fc2aea76898d074 https://syzkaller.appspot.com/bug?extid=99706d6390be1ac542a2 https://syzkaller.appspot.com/bug?extid=64437af5c781a7f0e08e Reported-and-tested-by: syzbot+32310fc2aea76898d074@syzkaller.appspotmail.com Reported-and-tested-by: syzbot+99706d6390be1ac542a2@syzkaller.appspotmail.com Reported-and-tested-by: syzbot+64437af5c781a7f0e08e@syzkaller.appspotmail.com Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/usb/gspca/gspca.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/media/usb/gspca/gspca.c +++ b/drivers/media/usb/gspca/gspca.c @@ -2038,7 +2038,7 @@ int gspca_dev_probe2(struct usb_interfac pr_err("couldn't kzalloc gspca struct\n"); return -ENOMEM; } - gspca_dev->usb_buf = kmalloc(USB_BUF_SZ, GFP_KERNEL); + gspca_dev->usb_buf = kzalloc(USB_BUF_SZ, GFP_KERNEL); if (!gspca_dev->usb_buf) { pr_err("out of memory\n"); ret = -ENOMEM;