Date: Sat, 4 Feb 2006 19:37:39 -0800 (PST)
From: Christoph Lameter <clameter@engr.sgi.com>
To: Andrew Morton <akpm@osdl.org>
cc: Paul Jackson <pj@sgi.com>, dgc@sgi.com, steiner@sgi.com,
       Simon.Derr@bull.net, ak@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] cpuset memory spread slab cache implementation
In-Reply-To: <20060204154959.0322e5da.akpm@osdl.org>
Message-ID: <Pine.LNX.4.62.0602041935590.8874@schroedinger.engr.sgi.com>
References: <20060204071910.10021.8437.sendpatchset@jackhammer.engr.sgi.com>
 <20060204071921.10021.83884.sendpatchset@jackhammer.engr.sgi.com>
 <20060204154959.0322e5da.akpm@osdl.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 824
Lines: 23

On Sat, 4 Feb 2006, Andrew Morton wrote:

> Paul Jackson <pj@sgi.com> wrote:
> >
> > +	if (unlikely(cpuset_mem_spread_check() &&
> >  +					(cachep->flags & SLAB_MEM_SPREAD) &&
> >  +					!in_interrupt())) {
> >  +		int nid = cpuset_mem_spread_node();
> >  +
> >  +		if (nid != numa_node_id())
> >  +			return __cache_alloc_node(cachep, flags, nid);
> >  +	}
> 
> Need a comment here explaining the mysterious !in_interrupt() check.

If we are in interrupt context then the current pointer may not be 
meaningful. cpuset settings should not be applied for any memory 
allocation.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/