Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4030346ybl; Mon, 3 Feb 2020 11:10:32 -0800 (PST) X-Google-Smtp-Source: APXvYqyxlfPyvhDX/j2sCIyAcoTRo7nCddbF4qx4uZC5YW6/yA/ZtoZfYQOHoVe7wv9E1hZVRn+s X-Received: by 2002:aca:3f54:: with SMTP id m81mr358849oia.73.1580757032586; Mon, 03 Feb 2020 11:10:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580757032; cv=none; d=google.com; s=arc-20160816; b=g88TrT5C15laawvaqySihMKs/SW4BUoHZr7DPa0ELG6ZfIAvZ/Xh4pdXaEmt4hGMlt yN/Daxu/2QWenTRwHFHQiXwv4HUT1v8n4FRi64kufekPTLegF2oWIQfUlKuvAWKmakQq ZWtioXwLYmFSGavDt+g7urYdihC6TJKb5ZmHCL1Tq6Zbhk0hD7/JSPOglrpjAlP1mf0K i1oFQvCQHe6TT2FXZNwfJ1B11KV9AMqz4h/iYIYwp/UBzKA6aaodb94kS8tNj/Lkb1lT YXGE3wJgUHwptFPy5yjcCw5EcY42drmribycj3taVpG+wFbeuEYnIjQet5kDZFEhWqav RARA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=+svzYeMjDifvnay5XBCjENPcDei37krIAEbCjdfWWhU=; b=Lb0a5xcTmkfks3hK3V4lnlnTspXCCjZrEjqcKgg+Y/Sr6pSZ0aHbw7djkwgFU3qorJ iMjSoj1PmgBejW9klwUa9W5Q2VzopOinFvdWXomyUcQM0xQ767XfGVyfUjMyMt1pVJcC UNHouvlZRRVS2UW5Pko/mfYaHTHZzDNXM4/T4k+6CM/9KHjgdLCMBBb/dTvVcxVLL4Su TDriUJZqR6JVQoxXC2in+/h4//DZ8jAfRxAXVfwJ6Xmi/kADZPdxTQPt8K9NhNgFOeVP kFN+1QArK8Vfg9fRt9r8fmmrFW7KqmhHFTrOCq/Q52I6/LhXv8ved4In6ExUBHf8IqFp 8xdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Uh9wVVKd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s5si10049675otd.141.2020.02.03.11.10.20; Mon, 03 Feb 2020 11:10:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Uh9wVVKd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729006AbgBCRiP (ORCPT + 98 others); Mon, 3 Feb 2020 12:38:15 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:48902 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726561AbgBCRiP (ORCPT ); Mon, 3 Feb 2020 12:38:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+svzYeMjDifvnay5XBCjENPcDei37krIAEbCjdfWWhU=; b=Uh9wVVKd7GmAMVO4QoLCs33RIH tlUkrd456X1MQBI2ZcjKd8tWTxYKw/bt1d55Ecyox2OJeX/KE3bKnXvCj0vdsvzOSRJOd/UDIAj2w l69ejkcK5CyzMwzk0S4RHBdXLS04dd6+vaW8jfpHz5B4mBd/ZuzHl/qmllj4Q34oHizwWkUodym02 ZUMRhjFtl2ELh+OM+6mA5n82D1di9RosZqr2hOYtHgD5aGIXdOFNC+Vi54iDCsFS1U75qnFbhSdWd 6KQP4QlIfHfPrkzxQ8aWaj0dUQkgDa2J9kucmHTDPGk2LSzjnDt+zoORFqfTTcsUgOBgWXXrrmdLU rT5JVVNg==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iyffn-00015V-Ss; Mon, 03 Feb 2020 17:38:11 +0000 Date: Mon, 3 Feb 2020 09:38:11 -0800 From: Christoph Hellwig To: Kees Cook Cc: Christian Borntraeger , Christoph Hellwig , Christopher Lameter , Jiri Slaby , Julian Wiedmann , Ursula Braun , Alexander Viro , linux-kernel@vger.kernel.org, David Windsor , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , linux-mm@kvack.org, linux-xfs@vger.kernel.org, Linus Torvalds , Andy Lutomirski , "David S. Miller" , Laura Abbott , Mark Rutland , "Martin K. Petersen" , Paolo Bonzini , Christoffer Dall , Dave Kleikamp , Jan Kara , Luis de Bethencourt , Marc Zyngier , Rik van Riel , Matthew Garrett , linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, netdev@vger.kernel.org, kernel-hardening@lists.openwall.com, Vlastimil Babka , Michal Kubecek Subject: Re: [kernel-hardening] [PATCH 09/38] usercopy: Mark kmalloc caches as usercopy caches Message-ID: <20200203173811.GB30011@infradead.org> References: <201911141327.4DE6510@keescook> <202001271519.AA6ADEACF0@keescook> <5861936c-1fe1-4c44-d012-26efa0c8b6e7@de.ibm.com> <202001281457.FA11CC313A@keescook> <6844ea47-8e0e-4fb7-d86f-68046995a749@de.ibm.com> <20200129170939.GA4277@infradead.org> <771c5511-c5ab-3dd1-d938-5dbc40396daa@de.ibm.com> <202001300945.7D465B5F5@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202001300945.7D465B5F5@keescook> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 30, 2020 at 11:23:38AM -0800, Kees Cook wrote: > Hm, looks like it's allocated from the low 16MB. Seems like poor naming! > :) There seems to be a LOT of stuff using GFP_DMA, and it seems unlikely > those are all expecting low addresses? Most of that is either completely or partially bogus. Besides the weird S/390 stuff pretty much everything should be using the dma allocators. A couple really messed up drivers even pass GFP_DMA* to the dma allocator, but my patches to fix that up seem to be stuck.