Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4511719ybl; Mon, 3 Feb 2020 20:30:47 -0800 (PST) X-Google-Smtp-Source: APXvYqy4iGOiaPfz1XCh+e3OfGQrFUsv7FBLEkffixz46Oj/jxzWDO2BmbArkIX/XaIFMw0sQVGY X-Received: by 2002:aca:f517:: with SMTP id t23mr2022447oih.160.1580790646893; Mon, 03 Feb 2020 20:30:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580790646; cv=none; d=google.com; s=arc-20160816; b=TNCVYyOTC4hT5maQm+vWqJrhPV39peYfelmmiS27zzeXNyKGOl78FOqd8zxQqTwdAC TlQM3NIjqr81StqjpWOwVd945GgRaV4Llo+fNksuEhYN4PAbYBfVzyIHArHZMRvxkZKy PcMq7oolCm0VlY8yAq73eoFcG2A1w+gg1wDVUUUn01dScmlnTRouDuOXBP1WmvWceUg9 X5KEPu06vfoe2vA+99Mj/hg6RsmDPmt+2Wutr1PHj2HDcwiKhT16cqgu6W/2Kxc/9d8X lD6WOmCMuiOKZdgy6P2WNji7yeGYtyg/c1slduBSVYrt91EE06VdRMuAraig5duvor4k 2B9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:cc; bh=wVpdIIs0547yQaMYO5AyL0NeEChuyPF6vnSMSMeoo7g=; b=p9SobqyfHQRw08b2zYEGXcer8Uu8zxVea8UEPzKd3Ux16vN0N6YniMLmwnZvfApcXh sTkljaMf23A0jB+G6MAElnqJRhV6W1uZ27bhDkx4zvnpMyCF4Ft7NaqVHYOdwtjteEhL hikSB/qBGWmBtV76IHlC1/CbGDoKhFD02eHIq4JLvU/oXG03xaXxE0dhCZ/4iO47W3f2 oRTcLaVI9Q0gV4xCoQ9hcHekW+MWaer/HLGeoln51T4vKAxni439sLXDsy3YPDz2GNLG MVupc0En9w7UrSQ+EXki7OOJkkZPUlAgNVbnGFUCiyezxR5Zbcs9Y73mZ44k8+LdX5VK aH8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=Ecu5oqfH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r6si10966981otp.220.2020.02.03.20.30.33; Mon, 03 Feb 2020 20:30:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=Ecu5oqfH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727192AbgBDE3i (ORCPT + 99 others); Mon, 3 Feb 2020 23:29:38 -0500 Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:11538 "EHLO hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727127AbgBDE3h (ORCPT ); Mon, 3 Feb 2020 23:29:37 -0500 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 03 Feb 2020 20:28:40 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Mon, 03 Feb 2020 20:29:36 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Mon, 03 Feb 2020 20:29:36 -0800 Received: from [10.24.44.92] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 4 Feb 2020 04:29:31 +0000 CC: , , , , , , , , , , , , , , Subject: Re: [PATCH v2 5/9] ASoC: tegra: add Tegra210 based AHUB driver To: Dmitry Osipenko , , , References: <1580380422-3431-1-git-send-email-spujar@nvidia.com> <1580380422-3431-6-git-send-email-spujar@nvidia.com> From: Sameer Pujar Message-ID: <125e08ae-8800-a81c-078e-e785ca9d4eaf@nvidia.com> Date: Tue, 4 Feb 2020 09:59:28 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-GB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1580790520; bh=wVpdIIs0547yQaMYO5AyL0NeEChuyPF6vnSMSMeoo7g=; h=X-PGP-Universal:CC:Subject:To:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding: Content-Language; b=Ecu5oqfHFKQhPHd263g8ghyvlryujc4E3xVUcTEp8RIWvBWxO3WqcC07dSxuYUWUD v5IuluCuxfOkqsw4yYZUnBBfccDyKyquxFoYWgNPj5NgbR83gP6p2q4hVaKRJUlzNn 3BXQrprR4i8pSH2DVq4dtrlzFZZGTW8yHj7rnQg9Ri/c23rTgXKdGCpz483ON58Znr zTCexRKVA7/S8EYI4BghHxywyC1d9wrP/kCIv3QnYjWwqGvShQe7Ik+U7MSP294GvL nCg4hmjikgqa4A0PiVSIMR8RiytNgLkwgl5udDg5SnP3EpjVKDkRCCCU2dakBR07BW zSfYDB+9fgeRg== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/30/2020 9:52 PM, Dmitry Osipenko wrote: > External email: Use caution opening links or attachments > > > 30.01.2020 13:33, Sameer Pujar =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > ... >> +static int tegra_ahub_probe(struct platform_device *pdev) >> +{ >> + struct tegra_ahub *ahub; >> + void __iomem *regs; >> + int ret; >> + >> + ahub =3D devm_kcalloc(&pdev->dev, 1, sizeof(*ahub), GFP_KERNEL); >> + if (!ahub) >> + return -ENOMEM; > ahub =3D devm_kzalloc(&pdev->dev, sizeof(*ahub), GFP_KERNEL); Earlier I had the impression that it won't memset it to 0. Now looking=20 at the implementation I see that it uses '__GFP_ZERO' flag, which I=20 think would initialize it to '0'. Will update. Thanks.