Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4515937ybl;
        Mon, 3 Feb 2020 20:35:49 -0800 (PST)
X-Google-Smtp-Source: APXvYqxQM4h4z5vqvnLmgdCdzEGHpqGLmesHvHOyJuY73oR3d5RkiMcHNCZLPRJoUFgJMbvOZa2N
X-Received: by 2002:a9d:67c9:: with SMTP id c9mr21115875otn.67.1580790949592;
        Mon, 03 Feb 2020 20:35:49 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1580790949; cv=none;
        d=google.com; s=arc-20160816;
        b=ahnPi9pliEJT1ugdOt2J3b+6hdK15hKneVNKbsxRsMdDeewptR5WkVXXInXeVxdigB
         4vD4hZJPrpKqI4pzWcuoj13UOw4uWSQ8N1yHhsNZzVS7XRJhobu6EBJhD2FRiC1J9nSn
         FAwftChdZhI8vphGJwPqO7/37GBiw3rg0y6VV5wAdiEfKQJ+jckYBIabY7zsgi62fRrj
         u+ylWwXOskT8kZMEo7BVpnOsSKTxWG/Qy6ycpGGuwJYy5r4Q85tEfF5RCCqENDr4W2Mm
         NxgFzTpPTzqUgFvLQtQPmDE62RKYUGJXhUyTnhlCru+OH/XpXrsiQ6YhFrYcCcYi+6R8
         5hCw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-language
         :content-transfer-encoding:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:to:subject:cc;
        bh=NSwCQ+2ljFmQNO7j63odtMCpslIrNcC8Sz110szttQU=;
        b=qlwI27qM2Qiq4ED4QKw+P0AP1l/o9ReVr2mpOZJDY9PbvU8Q88GYwSGTdaiwNi3MFX
         ODua7e3YaaRXIYevnPoFbwkHLP3VmJSe8ZkL/f/wJVjxlF/7m9NPQ0eessDsNSxeyjMN
         WcoVvkWW07oLm81G8nsIYMZccwAv8Es5Pji7JQ/J0ZqWCzhfkP61QsPYWqNn2sIpRNi5
         HxPd/+9cbnRdy/+5QkrVUdZjDatpxFjSC8l+RxO0zKG8vNWXU/D2qcm/u2zZawoU3eRv
         gC41s8HFFt20ecpXVyqWcgUp01sUyE3r40cVUzoZ3H3JenhMXhm4EaAWJgD+u+APuR9t
         IIHg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=lfn1MScF;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id a22si9616269oii.98.2020.02.03.20.35.36;
        Mon, 03 Feb 2020 20:35:49 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=lfn1MScF;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727170AbgBDEeq (ORCPT <rfc822;qidong1992@gmail.com>
        + 99 others); Mon, 3 Feb 2020 23:34:46 -0500
Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:13044 "EHLO
        hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726994AbgBDEeq (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 3 Feb 2020 23:34:46 -0500
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5e38f44e0000>; Mon, 03 Feb 2020 20:34:22 -0800
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Mon, 03 Feb 2020 20:34:45 -0800
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Mon, 03 Feb 2020 20:34:45 -0800
Received: from [10.24.44.92] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 4 Feb
 2020 04:34:40 +0000
CC:     <spujar@nvidia.com>, <broonie@kernel.org>, <lgirdwood@gmail.com>,
        <thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
        <alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>,
        <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <sharadg@nvidia.com>, <mkumard@nvidia.com>,
        <viswanathl@nvidia.com>, <rlokhande@nvidia.com>,
        <dramesh@nvidia.com>, <atalambedu@nvidia.com>
Subject: Re: [PATCH v2 5/9] ASoC: tegra: add Tegra210 based AHUB driver
To:     Dmitry Osipenko <digetx@gmail.com>, <perex@perex.cz>,
        <tiwai@suse.com>, <robh+dt@kernel.org>
References: <1580380422-3431-1-git-send-email-spujar@nvidia.com>
 <1580380422-3431-6-git-send-email-spujar@nvidia.com>
 <bd802f93-dd03-f39d-86e1-39f8571bbbb0@gmail.com>
From:   Sameer Pujar <spujar@nvidia.com>
Message-ID: <104d2019-6505-09b1-0e9f-bcfcdd70c18e@nvidia.com>
Date:   Tue, 4 Feb 2020 10:04:37 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.2
MIME-Version: 1.0
In-Reply-To: <bd802f93-dd03-f39d-86e1-39f8571bbbb0@gmail.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To
 HQMAIL107.nvidia.com (172.20.187.13)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-Language: en-GB
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1580790862; bh=NSwCQ+2ljFmQNO7j63odtMCpslIrNcC8Sz110szttQU=;
        h=X-PGP-Universal:CC:Subject:To:References:From:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding:
         Content-Language;
        b=lfn1MScFrfOu1ACyFaZn1We5MjYcA2OqeE0152DvpHPtGtWMqKctHUxYH25JeaKBF
         UATjyF7sC5vc2TSztTVFcCxvp1ieeFKNu3fssbwTHwKt2Jdg+Zm8AxNUfH0Vn9v4tw
         Lboh5DkBy0pSwN37H7FlUlQrfMNylAI02lwTj+I9nuHcnwyBhTLh/If6C7wFIfajdN
         E3zqngGu3aE2Tkf7i3yW9os/ZCYxWau9FUEhEiifNN1Yaa29jwktdxwOVOt/MG6cma
         JIL8csFlc2rnNhziFmWZOsBLYIL2qePFOyoabBcR8v1Ktl75WncpgqhsSBIALXz20s
         cTS/jPZT29q4Q==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 1/30/2020 10:39 PM, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
>
>
> 30.01.2020 13:33, Sameer Pujar =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
> ...
>> +     ret =3D devm_snd_soc_register_component(&pdev->dev,
>> +                                           ahub->soc_data->cmpnt_drv,
>> +                                           ahub->soc_data->dai_drv,
>> +                                           ahub->soc_data->num_dais);
>> +     if (ret < 0) {
>> +             dev_err(&pdev->dev, "failed to register component, err: %d=
\n",
>> +                     ret);
>> +             return ret;
>> +     }
> In the the patch #4 ("ASoC: tegra: add Tegra210 based I2S driver") I see
> the following:
>
>          ret =3D devm_snd_soc_register_component(dev, &tegra210_i2s_cmpnt=
,
>                                          tegra210_i2s_dais,
>                                          ARRAY_SIZE(tegra210_i2s_dais));
>          if (ret !=3D 0) {
>                  dev_err(dev, "can't register I2S component, err: %d\n", =
ret);
>                  return ret;
>          }
>
> Please be consistent in regards to errors checking. The correct variant
> should be: if (ret !=3D 0). Usually error codes are a negative value, but
> it is much safer to check whether value isn't 0 in all cases where
> positive value isn't expected to happen.

yes "if (ret)" is good enough in such cases.
>
> I'd also recommend to rename all "ret" variables to "err" everywhere in
> the code where returned value is used only for errors checking. This
> will make code more explicit, and hence, easier to read and follow.

OK, I will update it to 'err' for better.
>
> So, it will be nicer to write it as:
>
>          err =3D devm_snd_soc_register_component(&pdev->dev,
>                                          ahub->soc_data->cmpnt_drv,
>                                          ahub->soc_data->dai_drv,
>                                          ahub->soc_data->num_dais);
>          if (err) {
>                  dev_err(&pdev->dev, "failed to register component: %d\n"=
, err);
>                  return err;
>          }