Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200120104626.30518-1-warthog618@gmail.com> <CAMpxmJWCwtnuB4T3_no59cVvPS5gy6QwOBV3i4FU4N6hmYugEw@mail.gmail.com>
 <20200129123349.GA3801@sol>
In-Reply-To: <20200129123349.GA3801@sol>
From:   Bartosz Golaszewski <bgolaszewski@baylibre.com>
Date:   Tue, 4 Feb 2020 11:04:46 +0100
Message-ID: <CAMpxmJU0d=e6ZrSd5Sp0q4xFz9PYo4Zwm=e2AsL8f-pEodZfng@mail.gmail.com>
Subject: Re: [PATCH] gpiolib: remove unnecessary argument from set_config call
To:     Kent Gibson <warthog618@gmail.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        linux-gpio <linux-gpio@vger.kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

=C5=9Br., 29 sty 2020 o 13:33 Kent Gibson <warthog618@gmail.com> napisa=C5=
=82(a):
>
> On Wed, Jan 29, 2020 at 11:55:49AM +0100, Bartosz Golaszewski wrote:
> > pon., 20 sty 2020 o 11:46 Kent Gibson <warthog618@gmail.com> napisa=C5=
=82(a):
> > >
> > > Remove unnecessary argument when setting PIN_CONFIG_BIAS_DISABLE.
> > >
> > > Fixes: 2148ad7790ea ("gpiolib: add support for disabling line bias")
> > > Signed-off-by: Kent Gibson <warthog618@gmail.com>
> > > ---
> > >
> > > No argument is expected by pinctrl, so removing it should be harmless=
.
> > >
> >
> > This doesn't really fix any bug, does it? If not, then I'll just take
> > it for v5.7 after the merge window.
> >
>
> This is just fixing what I suspect was a cut-and-paste error on my part
> that wasn't picked up during review - until I had a closer look
> following Geert and Andy's recent comments on some of your proposed
> changes.  So it is just a tidy up.
>
> It could only a problem if a pinctrl is making use of the unnecessary
> argument, and there are no such pinctrls that I am aware of.
>
> Merge it in whenever it is convenient.
>
> Cheers,
> Kent.

I'm picking up various early fixes for v5.6 so I'll go ahead and apply
it while at it.

Bart