Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1580735882-7429-1-git-send-email-harini.katakam@xilinx.com>
 <1580735882-7429-3-git-send-email-harini.katakam@xilinx.com>
 <20200204.103749.1474392609351299440.davem@davemloft.net> <BN7PR02MB51215810D1240E98E81F6176C9030@BN7PR02MB5121.namprd02.prod.outlook.com>
In-Reply-To: <BN7PR02MB51215810D1240E98E81F6176C9030@BN7PR02MB5121.namprd02.prod.outlook.com>
From:   Harini Katakam <harinik@xilinx.com>
Date:   Tue, 4 Feb 2020 15:56:51 +0530
Message-ID: <CAFcVECKXoG5Cdi2Ef2D13zj7afx4ZVVyTRRm0H84dzEAYFvHnA@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] net: macb: Limit maximum GEM TX length in TSO
To:     David Miller <davem@davemloft.net>
Cc:     Nicolas Ferre <nicolas.ferre@microchip.com>,
        Claudiu Beznea <claudiu.beznea@microchip.com>, kuba@kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Michal Simek <michal.simek@xilinx.com>,
        Harini Katakam <harini.katakam@xilinx.com>,
        Harini Katakam <harinikatakamlinux@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi David,

<snip>
> > > v2:
> > > Use 0x3FC0 by default
> >
> > You should add a comment above the definition which explains how this value
> > was derived.  It looks magic currently.

I'll add a comment. The value was specified in the errata document that Cadence
provided to us.

Regards,
Harini