Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4842832ybl; Tue, 4 Feb 2020 03:03:02 -0800 (PST) X-Google-Smtp-Source: APXvYqw6ujfb8DnzQfN+lmZiHBUqCse3SBfhcg8ObthQrrJ6Gt2VPkEwcnVY5wDyfkRN/n9KFhPv X-Received: by 2002:a05:6830:114c:: with SMTP id x12mr21736359otq.324.1580814182026; Tue, 04 Feb 2020 03:03:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580814182; cv=none; d=google.com; s=arc-20160816; b=LbMz+OK29niHnh36LMKhKqcX0JdjCskG1d8hInN2OFJe/nwjCYx/Xj+lfocqwM+t2i eOev5c6deZzNGS1rjbHxLgOcM5EDPGR+i7VITqrEFt5Ymnrm18jJgGLWsFGovuniBR+R zs8Vd7dkBTeOlKFG84BKJBw7hurNOq0ZZBILPm7dbMCF4jWgiXb7lkFRKLaTTiEtUwIR 9pmzmgUMZjvPx2qyB5U19wuULqoRkC/a13cg0s/iDfb7VQqET0QQRp0hU14tSEQooSSs BPaWaWMQPby9rZGtXYJoQM9HQU4+ZbNeGpllSBFVQeLBAOZylx81Oy101iCyfWV9P8mR z9MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=VSoKdzuTN654e/B/AIAS3k6Iw50VnzMJb6e2uFqXSFA=; b=KfXerU1j8QZDdFbjt0LwB3valTxyek7MhkYX1DryyrGsp3Umw25KlFagaV9oKHKg38 EAYEPbOmesvu0M/Sy9cinzqhAgb8LQCy/GQIqae6qZS3lSeIRTO3fotFKsKBOspa2eju VyX3pImHZ/2yLopcdVBmF3kV/enH5q3Pk3cx6BF8Oq1ouMa4+AeRK4bCUQ8ZoQCQo12T 4IPUn3i4QfomrzjD3vwk4KJk3aTCFzABUkLSdmpHG1fzy0Woouhgr8KJ16UDePWXGSjS Hwz8tiGHMd7c5wdJMXvnxZY1bvS6pzc0Jvw5q7MzPkkx1N7fO7iHYUhro0CsRmXWb5EH eqdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=ngl16WZ+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m7si11879572otk.73.2020.02.04.03.02.49; Tue, 04 Feb 2020 03:03:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=ngl16WZ+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726983AbgBDLAo (ORCPT + 99 others); Tue, 4 Feb 2020 06:00:44 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:51592 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726741AbgBDLAo (ORCPT ); Tue, 4 Feb 2020 06:00:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=VSoKdzuTN654e/B/AIAS3k6Iw50VnzMJb6e2uFqXSFA=; b=ngl16WZ+QvPAC5INvj9tjXxtC NbRgf0B1IP/0IpKklrIVGU4jViM6cYpmjE3sfcCmz3tfGfbvHWLLCKBV2lxeraJqEsnGouW/oqu1O iL60EatIfqVM+Gp4hheWEfiUiDwNYJZj8Th6805toGDD9j2NY5SNIUpfkexYBfJB26z1E=; Received: from fw-tnat-cam2.arm.com ([217.140.106.50] helo=fitzroy.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iyvwS-0007HD-22; Tue, 04 Feb 2020 11:00:28 +0000 Received: by fitzroy.sirena.org.uk (Postfix, from userid 1000) id 98871D01A54; Tue, 4 Feb 2020 11:00:27 +0000 (GMT) Date: Tue, 4 Feb 2020 11:00:27 +0000 From: Mark Brown To: Hongbo Yao Cc: bardliao@realtek.com, oder_chiou@realtek.com, chenzhou10@huawei.com, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] ASoc: rt1015: make symbol rt1015_aif_dai_ops and rt1015_dai static Message-ID: <20200204110027.GB3897@sirena.org.uk> References: <20200203021841.121378-1-yaohongbo@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Ghfi4GlmwTrWkODx" Content-Disposition: inline In-Reply-To: <20200203021841.121378-1-yaohongbo@huawei.com> X-Cookie: Programming is an unnatural act. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Ghfi4GlmwTrWkODx Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 03, 2020 at 10:18:41AM +0800, Hongbo Yao wrote: > Fix sparse warning: > sound/soc/codecs/rt1015.c: warning: symbol 'rt1015_aif_dai_ops' > was not declared. Should it be static? > sound/soc/codecs/rt1015.c: warning: symbol 'rt1015_dai' was not > declared. Should it be static? This introduces other warnings so clearly isn't the best fix: CC sound/soc/codecs/rt1015.o sound/soc/codecs/rt1015.c:844:31: warning: =E2=80=98rt1015_aif_dai_ops=E2= =80=99 defined but not used [-Wunused-variable] static struct snd_soc_dai_ops rt1015_aif_dai_ops =3D { ^~~~~~~~~~~~~~~~~~ --Ghfi4GlmwTrWkODx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl45TsoACgkQJNaLcl1U h9C5cQf9HIUK8FpIx3NDivWZ5zFfq57NOvJExnPqbpFzBxrkvwUyWFk630IJkyUU TmsT4A/64zxqPPsOG6w1CQvni6mHQ7NNg9fwmNuiyotN8rHq0ILly2iFa2VM9rjq vTy434JhhicHcRXOz3n/zJNZ9OF/fKlBeAKvwd1AY+38/wUsg5VvN4nx9mY/bj3S zK3s/qPeNvyhMoEdzY6WlfL8oAF6waL9+EIx/Qz7FJJvOo3XW4O6nnFmjV9sU8t2 oOOO0yAE5VkQgCCG9G/PbgAV1iDJE3BtKWsFx6u0bZRIOs4kjgutgzWEiyDOzzcl vgW4upIk9b2tAZt2cd151dj82Y/GKA== =4dPx -----END PGP SIGNATURE----- --Ghfi4GlmwTrWkODx--