Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Date:   Tue, 4 Feb 2020 20:22:11 +0900
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Petr Mladek <pmladek@suse.com>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        linux-kernel@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v1] printk: Declare log_wait as external variable
Message-ID: <20200204112211.GA2009@jagdpanzerIV.localdomain>
References: <20200203131528.52825-1-andriy.shevchenko@linux.intel.com>
 <20200204021620.GD41358@google.com>
 <20200204090533.GM32742@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200204090533.GM32742@smile.fi.intel.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On (20/02/04 11:05), Andy Shevchenko wrote:
> > > --- a/kernel/printk/printk.c
> > > +extern wait_queue_head_t log_wait;	/* Used in fs/proc/kmsg.c */
> > >  DECLARE_WAIT_QUEUE_HEAD(log_wait);
> > > +#else
> > > +static DECLARE_WAIT_QUEUE_HEAD(log_wait);
> > > +#endif /* CONFIG_PROC_FS */
> > 
> > [..]
> > 
> > Since we are now introducing CONFIG_PROC_FS dependency to printk (and
> > proc/kmsg already has CONFIG_PRINTK dependency),
> 
> I'm not sure I understood. The above does not introduce any dependencies.

kernel/printk/printk.c
 +#ifdef CONFIG_PROC_FS
 ..

Not exactly "dependency"... what is the correct word here.

	-ss