Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4882150ybl; Tue, 4 Feb 2020 03:46:03 -0800 (PST) X-Google-Smtp-Source: APXvYqxM7Bh7pqY2b7EcJ++B+QPzj/YJMTmnXT6IpLSk0We/KtR19h8CY3uJNkntwXYC8lILr57+ X-Received: by 2002:a05:6830:20c4:: with SMTP id z4mr22647275otq.260.1580816763759; Tue, 04 Feb 2020 03:46:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580816763; cv=none; d=google.com; s=arc-20160816; b=0UvQEIqPvZ0SCjciLRJoXljz4gIgN/2Y4xFsuSlh8Ogi/EOIil8kgoDfr2BzXx+1SC zhlHjWnNkz4LZxG6p56TBH+N4ZXNhFN46REP4CXcBXIeb3YHDPQ2/vek/eisdc+tvBsj Rs53Cx7onQg6J+Z4ghuyOyDbWJhRb4n8Ae70ja++aYwTXY4BbhUzwGlaqa7DncrsOHvb VvKFrnIduZFOY1gSc0kJTN6uFRzArzle5QXUHJ+JbYIBRgRbB0pHIJs3Pz49LSTTHvRX oXcdYtsiOYlF9ch0F4jCebc8nkryYYUi4c6suiJDKx6EfSVgrmGmLplK9AW+rrPydwtc tFvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=IoAMQXcnyStK6DgzYEMyTvtwtqvhXVfKfzLGyGdTCao=; b=Zwbth8mEGs/m4pOLJ9cc/nH8zySyuJs313XIlU3KCx3oI4flZRXnxViEM4TTBywJC/ wG58Yu4NmEfyiZjKpqyXrxgbpTLEfS5tiIsDl3PW0bEjPKt+d69M/9C+33BRrdWcwTm6 0TT2MUi6Zmf6ErkmVYmXfzGRHCmORZztvcMHzRLTbZ708f3+xbziI8e1K+cFySN71Hl1 /IbyS53H3C/w+TzQ88fNJBR2L+GfAQlR0JvtEbOuOJaWHliu8e+qWdi1uOmUokc0D4Mt ui3g1S4EmduBI6/QUSNng9GpjwjD92yNQXw1j2cWHnX+Fl1nmuZijhnkzPJbMYUGLTUb iqxQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u12si12073936otq.51.2020.02.04.03.45.51; Tue, 04 Feb 2020 03:46:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727192AbgBDLo6 (ORCPT + 99 others); Tue, 4 Feb 2020 06:44:58 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:42208 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727030AbgBDLo6 (ORCPT ); Tue, 4 Feb 2020 06:44:58 -0500 Received: from localhost (unknown [IPv6:2001:982:756:1:57a7:3bfd:5e85:defb]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id BD1C8133A87D3; Tue, 4 Feb 2020 03:44:56 -0800 (PST) Date: Tue, 04 Feb 2020 12:44:55 +0100 (CET) Message-Id: <20200204.124455.1858606436930758654.davem@davemloft.net> To: tbogendoerfer@suse.de Cc: ralf@linux-mips.org, paulburton@kernel.org, linux-mips@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: sgi: ioc3-eth: Remove leftover free_irq() From: David Miller In-Reply-To: <20200204113628.13654-1-tbogendoerfer@suse.de> References: <20200204113628.13654-1-tbogendoerfer@suse.de> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 04 Feb 2020 03:44:57 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thomas Bogendoerfer Date: Tue, 4 Feb 2020 12:36:28 +0100 > Commit 0ce5ebd24d25 ("mfd: ioc3: Add driver for SGI IOC3 chip") moved > request_irq() from ioc3_open into probe function, but forgot to remove > free_irq() from ioc3_close. > > Fixes: 0ce5ebd24d25 ("mfd: ioc3: Add driver for SGI IOC3 chip") > Signed-off-by: Thomas Bogendoerfer ioc3_open() still has the request_irq() in my tree.