Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4893290ybl; Tue, 4 Feb 2020 04:00:45 -0800 (PST) X-Google-Smtp-Source: APXvYqyavtY5bycnFMADpib1Y/rXubsV1Wygm00fpGpva6IlAiGohJLkXb5NK/taytmJTZce1AaE X-Received: by 2002:a54:4791:: with SMTP id o17mr3043441oic.70.1580817644877; Tue, 04 Feb 2020 04:00:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580817644; cv=none; d=google.com; s=arc-20160816; b=ORFX905OG5Rtt1+IV5JenoaMMpEKYHceTSjpM1kLmu3UWQRTQ+rwTn62i2mHPNPlb2 Ri4tabrM9iG3CyKTjJ9N9JBjHe9+Gwg4oF/3FtZuKnR3NPAoK9gu9Yf8Cg4tOdxQ8EpA o5Lx+WwfmWxFsOogqZZ+nYVEjKZwvU9uF7e+fZKHrqOdOEZHRtIXHYoXDJI4fGwfbeLs BlfQ7lrfXABtshDTohFmt/lHHQFjIKy6MDWxs4WDvCSWVDBeoheWv2126ic1e7IWq+iv AjxEFZLHB34jcgh7ELmCbX7uu97pZ+s83eyFPvR0mlg5Mm78Gm25mOfmjWcbTAEQrnrZ +91A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=5EODsAKk6BYMNRpItE0f/5thKH5PtlX1J1ScS2f3FyI=; b=D//k/vmEt4BjHs3OA3WUcQsEZZO1m2/HcqjD/hGKtC5g7LSS9ctRcmTOjwzZ5xrfTi +l/UttaBiSJs7GenGu+jDzzShkR2MQpABJUQyXIaiYPvgXbFCIXf3hsMpINN8Ps0XrLD kVVWoXWCdZJI/0IR2tkcjuLZHvUFBc0V4Bk2qC2K4WZqHYLlGMqyX83Zff+jBXH4kIcz nkxtgkD9A2XWFHV/2Ri4lea4XQsZRttxlikg9+d8hZhsSmWQ48uA36p9Yf5fHJ3vDpNl ZUjflvC72xSCGS52LPO6g3fXtyEh1urAR/MU2V9yI+vsY/UOkcXumNC40LxEbY+XhNk2 8Kng== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q9si11865630otc.86.2020.02.04.04.00.30; Tue, 04 Feb 2020 04:00:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727164AbgBDL6f convert rfc822-to-8bit (ORCPT + 99 others); Tue, 4 Feb 2020 06:58:35 -0500 Received: from mx2.suse.de ([195.135.220.15]:59050 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727097AbgBDL6f (ORCPT ); Tue, 4 Feb 2020 06:58:35 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id BF1DDADFF; Tue, 4 Feb 2020 11:58:33 +0000 (UTC) Date: Tue, 4 Feb 2020 12:58:33 +0100 From: Thomas Bogendoerfer To: David Miller Cc: ralf@linux-mips.org, paulburton@kernel.org, linux-mips@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: sgi: ioc3-eth: Remove leftover free_irq() Message-Id: <20200204125833.f4fd62590d0539cf87527286@suse.de> In-Reply-To: <20200204.124455.1858606436930758654.davem@davemloft.net> References: <20200204113628.13654-1-tbogendoerfer@suse.de> <20200204.124455.1858606436930758654.davem@davemloft.net> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 04 Feb 2020 12:44:55 +0100 (CET) David Miller wrote: > From: Thomas Bogendoerfer > Date: Tue, 4 Feb 2020 12:36:28 +0100 > > > Commit 0ce5ebd24d25 ("mfd: ioc3: Add driver for SGI IOC3 chip") moved > > request_irq() from ioc3_open into probe function, but forgot to remove > > free_irq() from ioc3_close. > > > > Fixes: 0ce5ebd24d25 ("mfd: ioc3: Add driver for SGI IOC3 chip") > > Signed-off-by: Thomas Bogendoerfer > > ioc3_open() still has the request_irq() in my tree. then I guess you don't have commit 0ce5ebd24d25 in your tree. My Patch is against linus/master, where it is already applied. Should I rebase against your net tree, when the commit shows up ? Thomas. -- SUSE Software Solutions Germany GmbH HRB 36809 (AG N?rnberg) Gesch?ftsf?hrer: Felix Imend?rffer