Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 04 Feb 2020 14:42:43 +0100 (CET)
Message-Id: <20200204.144243.914260869258980952.davem@davemloft.net>
To:     tbogendoerfer@suse.de
Cc:     ralf@linux-mips.org, paulburton@kernel.org,
        linux-mips@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: sgi: ioc3-eth: Remove leftover free_irq()
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200204125833.f4fd62590d0539cf87527286@suse.de>
References: <20200204113628.13654-1-tbogendoerfer@suse.de>
        <20200204.124455.1858606436930758654.davem@davemloft.net>
        <20200204125833.f4fd62590d0539cf87527286@suse.de>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
Date: Tue, 4 Feb 2020 12:58:33 +0100

> On Tue, 04 Feb 2020 12:44:55 +0100 (CET)
> David Miller <davem@davemloft.net> wrote:
> 
>> From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
>> Date: Tue,  4 Feb 2020 12:36:28 +0100
>> 
>> > Commit 0ce5ebd24d25 ("mfd: ioc3: Add driver for SGI IOC3 chip") moved
>> > request_irq() from ioc3_open into probe function, but forgot to remove
>> > free_irq() from ioc3_close.
>> > 
>> > Fixes: 0ce5ebd24d25 ("mfd: ioc3: Add driver for SGI IOC3 chip")
>> > Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
>> 
>> ioc3_open() still has the request_irq() in my tree.
> 
> then I guess you don't have commit 0ce5ebd24d25 in your tree. My Patch is
> against linus/master, where it is already applied. Should I rebase against your
> net tree, when the commit shows up ?

I just sync'd with Linus's tree so you should be able to rebase right now.

Thanks.