Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp5004874ybl; Tue, 4 Feb 2020 06:04:59 -0800 (PST) X-Google-Smtp-Source: APXvYqx6+ddk9tAoGNDhUxH9EZpxYSnjF1oCU07UwDPLC4qQAJSgZnO+ro9Ml+p+bJOqjkzkFYfT X-Received: by 2002:a05:6830:114c:: with SMTP id x12mr22264625otq.324.1580825099495; Tue, 04 Feb 2020 06:04:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580825099; cv=none; d=google.com; s=arc-20160816; b=plCKvbxhtsa1mRIDXkiT0IwrYG4k4iLW1m791M86FRW5+zuVjKq7Y16nPL2bihy8DD 3KqeK7QIOhWCOSwLqCuE+sZa+9j1AO22pFFnGSCt4DVtYcvpHg/rk4QJ26zvwW8NMDQA 3arWomVCU8QpR7Y/DYZ6Mj4mObLmVxVtBkkqAk0XzcFmHkK70ox3N3LF6GWmTMaKjKMU 4Ik93/DUL5ReAN/dKo+fV94C3JCt/95l2WG0dHmiYCAwx49ok18QgHCwNv1DHFp6OAHE 8ewkERM4oiy8LpqcBQSoqVClpnB1auW+QaikmBCSAd5oKw7ygCCGlYcakOPSSZwwhpRu 2rVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=n0ZWkKfL1Bo/DyraO/d0oDEkbGINoDALNn/C6EtNwXg=; b=OgFy31nYpZBuTU+KgiiUj8WUTR4WdS5BwsUeUtphq9zywPxSJKkjmJC8dlPTavViRK Zo11N1iHsj7DXrQO+DsF3nJZ/0S1ZNB7DQjtmWwpmaNr1cuxswBu9DqflhYEDFCpp1B+ XQuQx0vQdeQUdNze728ZVnk1GY4bfQ50voVXAuqUdt5RwIsthsdaiOX2v074Ik7bnr4R 2gees2MMdhtjTtgP+r5P+ml0krZJb/OmWkELKirXpRwbQzRI3/WqJnhfMUQCntCN/kvI Aj0temcxAl16/4BR668VDyzC4fSYCZLGDMc+sxNLqN5y0oZjOCuBZ0wzfv5ro0wTX0+t OxUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=r12UGfNl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s22si9912997oij.35.2020.02.04.06.04.44; Tue, 04 Feb 2020 06:04:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=r12UGfNl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727230AbgBDOBK (ORCPT + 99 others); Tue, 4 Feb 2020 09:01:10 -0500 Received: from mail-il1-f194.google.com ([209.85.166.194]:44187 "EHLO mail-il1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727191AbgBDOBJ (ORCPT ); Tue, 4 Feb 2020 09:01:09 -0500 Received: by mail-il1-f194.google.com with SMTP id s85so12494126ill.11 for ; Tue, 04 Feb 2020 06:01:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=n0ZWkKfL1Bo/DyraO/d0oDEkbGINoDALNn/C6EtNwXg=; b=r12UGfNlXLswwkx7BMDc89j69q2rEzvMYdKCkc0yFzWjsPVu3B+5KwlUSaC2an6fnn jCIs5AN737+p+c2QBbQAwy8rUd1TrzEfk5KCixdLjag8/cgrhOznyBX16h/W/cvMK65z MV8CzAfm/x/CuQK9kd386n20dHcOh+nK6mftSZ0HcIVICi1qsxyhozue6s3Ot3Oa50Lc BFLwvqvz14HfNxU0xQD/UL01fEa05pUMHjKd4qUu897IIvMdrYPQJ+ppT2y7kjay2133 /0cewr8CkwjwFAS0Ri+iEa0+muyNKlvj5eC1g7ym0raElkCNBMJX48hTntOfXqceLGq/ ekwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=n0ZWkKfL1Bo/DyraO/d0oDEkbGINoDALNn/C6EtNwXg=; b=kPgAt9WW+XZ1JQl3dyjH8JFsifWD4gJ2y2TDW2IbkhzRPDeh09SOtPNcC3b7Rp61QK LEDUOn74sFqPRrNE2jk1qbpEntuWBzk3esKLfIBNc5JCwfonzkXCmNGHqHCX3c/8SlJT MiIx8DuAgMW1oQFXN3snt5avJB4C+7H4Lx4EwBaUyIcy8UMj5B4h2f4XTk2BeXCsVTCE eX8Vz7Sk/aOGo+Ml2BTyIrhKfTnrvq+GI0Uvuo4cdFjgxEkwZQGAKf+PaqsWIpj5GkYC Ri5VUNcIpMz8yehhGubGCacK6yd0KVscgBAmiIEt3dqhpek4O8m93qB8xQ6UMw46bEgY pkug== X-Gm-Message-State: APjAAAUdklrzbXZkSL/dQvPcSs54mcFYpdOCyaspZwRzUNy3dFbTtMqX b7fS/2Yp/2qJIXdnJz88rCDfN+UwhV8= X-Received: by 2002:a92:8f44:: with SMTP id j65mr27068384ild.144.1580824865871; Tue, 04 Feb 2020 06:01:05 -0800 (PST) Received: from [192.168.1.159] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id c19sm6726691iob.70.2020.02.04.06.01.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Feb 2020 06:01:05 -0800 (PST) Subject: Re: [PATCH] Fix io_read() and io_write() when io_import_fixed() is used. To: David Laight Cc: LKML References: <0cf51853bebe4c889e4d00e4bbc61fb3@AcuMS.aculab.com> From: Jens Axboe Message-ID: Date: Tue, 4 Feb 2020 07:01:04 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <0cf51853bebe4c889e4d00e4bbc61fb3@AcuMS.aculab.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/4/20 4:20 AM, David Laight wrote: > io_import_fixed() returns 0 on success so io_import_iovec() may > not return the length of the transfer. > > Instead always use the value from iov_iter_count() > (Which is called at the same place.) > > Fixes 9d93a3f5a (modded by 491381ce0) and 9e645e110. What kernel is this against? This shouldn't be an issue in anything newer than 5.3-stable. -- Jens Axboe