Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp5136648ybl; Tue, 4 Feb 2020 08:21:03 -0800 (PST) X-Google-Smtp-Source: APXvYqyzernRE9/J13f5siaMNHrWB+rBEtcSnnKXBJUH/9w6/7Zjgm3aXwyNjTpoIcqdGpS0gGOW X-Received: by 2002:a05:6830:43:: with SMTP id d3mr23591579otp.259.1580833263142; Tue, 04 Feb 2020 08:21:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580833263; cv=none; d=google.com; s=arc-20160816; b=ULodtVmdlUr5Ya3SZr5wNLiwOeQn3jXjQtQGU0pzaqopg9SrUFmMl9HXoMSIQlMxwe 6ni1iws1UceP3RccXeHL+Y30JIwpzZmUaBT2Heu6JNHTUJ0946DY4TWJ6kBUecUD4vPT 4OlP3Je9MhaXiCOTVx7UrFFi8yUguDwzaaTU9fnm5C4GjRTdS0KXK6B/ojyULLbVBPFW xXnzAGLgYPhzuU81rFkN+VyePGyege9JM+jgm+dweEcgd7GEkrVLwv7Qhjfho2Q4qqlf FXD8EIflx2OqXgIdKIUJVhIvOxcyQpfK+VMRgSiQBR/CjWWWFfzBDZLFWTK5ZzNDpnwY neQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:date:message-id:from :references:cc:to:subject:dkim-signature; bh=rKE6BXas3LZe481kZHsQO9RrFsrswJ8xXmcNA5ia/sc=; b=kFB/qmF6V4Nmebbmk1Y6ehMyuc7ecbPUlvoKq1cON2fAAtCZHmmOZ2WsfeCRmRa017 vWOF5A0ailFbhmGaiCvwp1Uqk3nhjgz6L4Zuo0+RHj895NDccsNkynGFL4VK78/Ku+LZ s3AsO8/vvLrEyw3gO0kTOdiVhxRvtnryYxP+4pE4R25x5VXOHfhcecAt91cfMi018pah EfUOfMXXDl6IYEq5pDh+aNG8rhNbYgr08+/42Kn8/n8trCKDQSZvttIPEnR6JlZKADtA cR5MHM+akjcIYXanYdbXNllXf8ynNGvx6JUDZunPASJJmaAWC5zzAwaeRb5IiGEhaIZr cKRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=B83REeVY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i6si11749474otp.5.2020.02.04.08.20.49; Tue, 04 Feb 2020 08:21:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=B83REeVY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727369AbgBDQSk (ORCPT + 99 others); Tue, 4 Feb 2020 11:18:40 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:59154 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727290AbgBDQSk (ORCPT ); Tue, 4 Feb 2020 11:18:40 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 014GFpm9099115; Tue, 4 Feb 2020 16:18:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=rKE6BXas3LZe481kZHsQO9RrFsrswJ8xXmcNA5ia/sc=; b=B83REeVYK/qA/uk+oNSDRp+5EZio8ECEraJSWV7MzTlwxzLxjK0dCBX7/3cBu4IuEntU Q1Y8pi4wWrh1em0ZC4e7lGaKm6i/0RRM/QnIwHH1gDJLvate0O6i76HWnDscTBFE03jp m0vYMX+CR8CzHfsUkd0oSvHE3E4LMihs90G5z8RF7RlKSMXGVYHAiLAbIu9zS8fO5cqp BmX2YTRDlSo03ouhjqzQh0eaz+YLA705/vTz5f67vJro2hoMppguLlZtpfjRoh/Ajtlw q5v78rojwBeLB9TacrjrNMjrioqHLiAuhvXudutZGto/SNje390kzS8o5T8HTQ+QrK+h FQ== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 2xw0ru7rry-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 04 Feb 2020 16:18:09 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 014GGNC4155573; Tue, 4 Feb 2020 16:18:09 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 2xxw0xb6a8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 04 Feb 2020 16:18:08 +0000 Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 014GI6qi018533; Tue, 4 Feb 2020 16:18:06 GMT Received: from [10.175.207.61] (/10.175.207.61) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 04 Feb 2020 08:18:05 -0800 Subject: Re: [PATCH RFC 02/10] mm: Handle pmd entries in follow_pfn() To: Matthew Wilcox Cc: linux-nvdimm@lists.01.org, Dan Williams , Vishal Verma , Dave Jiang , Ira Weiny , Alex Williamson , Cornelia Huck , kvm@vger.kernel.org, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , x86@kernel.org, Liran Alon , Nikita Leshenko , Barret Rhoden , Boris Ostrovsky , Konrad Rzeszutek Wilk References: <20200110190313.17144-1-joao.m.martins@oracle.com> <20200110190313.17144-3-joao.m.martins@oracle.com> <20200203213718.GL8731@bombadil.infradead.org> From: Joao Martins Message-ID: <94c35449-16ac-235b-fa2e-a5aea85dc568@oracle.com> Date: Tue, 4 Feb 2020 16:17:59 +0000 MIME-Version: 1.0 In-Reply-To: <20200203213718.GL8731@bombadil.infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9521 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=767 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2002040108 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9521 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=830 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2002040108 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/3/20 9:37 PM, Matthew Wilcox wrote: > On Fri, Jan 10, 2020 at 07:03:05PM +0000, Joao Martins wrote: >> @@ -4366,6 +4366,7 @@ EXPORT_SYMBOL(follow_pte_pmd); >> int follow_pfn(struct vm_area_struct *vma, unsigned long address, >> unsigned long *pfn) >> { >> + pmd_t *pmdpp = NULL; > > Please rename to 'pmdp'. > Will do. Alongside patch 4 usage of pmdpp and renaming 'pudpp' to 'pudp'.