Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751119AbWBETCy (ORCPT ); Sun, 5 Feb 2006 14:02:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751219AbWBETCy (ORCPT ); Sun, 5 Feb 2006 14:02:54 -0500 Received: from mx1.redhat.com ([66.187.233.31]:58333 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S1751119AbWBETCx (ORCPT ); Sun, 5 Feb 2006 14:02:53 -0500 Date: Sun, 5 Feb 2006 14:02:20 -0500 From: Dave Jones To: Olaf Hering Cc: Linux Kernel Mailing List , "Rafael J. Wysocki" , Pavel Machek Subject: Re: [PATCH] Fix build failure in recent pm_prepare_* changes. Message-ID: <20060205190220.GB19458@redhat.com> Mail-Followup-To: Dave Jones , Olaf Hering , Linux Kernel Mailing List , "Rafael J. Wysocki" , Pavel Machek References: <200602032312.k13NCDAc012658@hera.kernel.org> <20060205125610.GA26337@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060205125610.GA26337@suse.de> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2000 Lines: 41 On Sun, Feb 05, 2006 at 01:56:10PM +0100, Olaf Hering wrote: > On Fri, Feb 03, Linux Kernel Mailing List wrote: > > > tree 8f70444139c8564c0f1e88e1f33adda036ae6a96 > > parent 278ff9537030bbb292b33504f5e1f6e0126793eb > > author Dave Jones Fri, 03 Feb 2006 19:03:44 -0800 > > committer Linus Torvalds Sat, 04 Feb 2006 00:32:00 -0800 > > > > [PATCH] Fix build failure in recent pm_prepare_* changes. > > > > kernel/power/power.h:49: error: static declaration of 'pm_prepare_console' follows non-static declaration > > include/linux/suspend.h:46: error: previous declaration of 'pm_prepare_console' was here > > kernel/power/power.h:50: error: static declaration of 'pm_restore_console' follows non-static declaration > > include/linux/suspend.h:47: error: previous declaration of 'pm_restore_console' was here > > > > Signed-off-by: Dave Jones > > this one is not correct, please have a closer look at > f7b8988ff50d99c99746f65f420364e91362c065 > > CC drivers/macintosh/via-pmu.o > drivers/macintosh/via-pmu.c: In function 'pmac_suspend_devices': > drivers/macintosh/via-pmu.c:2078: error: implicit declaration of function 'pm_prepare_console' > drivers/macintosh/via-pmu.c: In function 'pmac_wakeup_devices': > drivers/macintosh/via-pmu.c:2194: error: implicit declaration of function 'pm_restore_console' > make[2]: *** [drivers/macintosh/via-pmu.o] Error 1 Strange, my ppc[64] builds compiled and linked without failure. I think perhaps it's time I added -Werror-implicit-function-declaration to the Makefile. I'll not get a chance to look into fixing this until tomorrow, so if Rafael/Pavel have time before then, maybe they'll beat me to it. Dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/