Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp194829ybv; Tue, 4 Feb 2020 19:24:37 -0800 (PST) X-Google-Smtp-Source: APXvYqzrSKOZhh5WATqmtCiWImNs6hEMGJIAcOodY9yDFL624Swoq49O7DZgYGClkpPoIo2GKMRA X-Received: by 2002:aca:af49:: with SMTP id y70mr1578862oie.162.1580873077130; Tue, 04 Feb 2020 19:24:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580873077; cv=none; d=google.com; s=arc-20160816; b=lGvXxFBaLEM7uUN4dCuAXlcOskY+ADch88kNlG+hjn8rgU6SFj4aQ00BeWcDUu0T5A TGwAxEv1sBBziSCLhu9Z3LoRoDUqippFp43Flh33HFY65Ao2fKGZKhTwJ4VGQ6zolrbx q5AHSNi0UikPHQhz0WrqG2lhXeavtTJZ3wPPv8Saof4aolhG77ATqZEUVzQjQzU1WI8e 3bzYe9v2uqX/CvxqJg/SxWBzGCd+Pydk7m9zLHu+HjNxDxUoP7fQ88Ty5KW5L4wwJCFV e37KCQl2GVfXFSApwm+wNSosg3Xvs3a5/QxrlJsm6OfWvSjnfG0u5yzgipODZIldCKKW j7YA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=+2lM8J1UIiuSbHVK81bOiLN+F+o/66qCoAuQFiFYraQ=; b=m2T/5RZGAQCVPz9c4+mabw/5LmVGNnmose7zHexoKc7SJGpsBrsv/ystvh3wRdGIzG nId5W6XmiQ3p/Xmm5cKdFP5xk9Xl7GtvY7W2dqmnU/2gY/mpGblICOCqzq+yHUkcKLoR 71opMJA+fEfK+XGLdU+4btWYW0dw+Zx25msnA84Hl90hISiEebhusUsBaJDt5+4oPtYB fHLMHH72l8hXK2qaIYcj631BtNv6hQIOFWyqB7vZimF0LtddR/QbdX6gMC+LGWwxn2ru 9N6MoKi/zB9c+71LFQuEO3DBQJDr5aItv5NYtXG+Y0Mz4y53sSKs77lz6YbeGFw22Eov QIRg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p1si13605319otk.42.2020.02.04.19.24.25; Tue, 04 Feb 2020 19:24:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727887AbgBEDXd (ORCPT + 99 others); Tue, 4 Feb 2020 22:23:33 -0500 Received: from out30-54.freemail.mail.aliyun.com ([115.124.30.54]:52236 "EHLO out30-54.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727714AbgBEDXd (ORCPT ); Tue, 4 Feb 2020 22:23:33 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01f04427;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0TpA7DPY_1580873008; Received: from IT-FVFX43SYHV2H.lan(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0TpA7DPY_1580873008) by smtp.aliyun-inc.com(127.0.0.1); Wed, 05 Feb 2020 11:23:29 +0800 Subject: [PATCH v2] net/bluetooth: remove __get_channel/dir and __dir To: Marcel Holtmann Cc: Johan Hedberg , "David S. Miller" , "Gustavo A. R. Silva" , linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1579596583-258090-1-git-send-email-alex.shi@linux.alibaba.com> <8CA3EF63-F688-48B2-A21D-16FDBC809EDE@holtmann.org> <09359312-a1c8-c560-85ba-0f94be521b26@linux.alibaba.com> <2287CD53-58F4-40FD-B2F3-81A9F22F4731@holtmann.org> From: Alex Shi Message-ID: <1e76a7b8-c90a-56fe-96d7-4088dc7f6c38@linux.alibaba.com> Date: Wed, 5 Feb 2020 11:23:27 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <2287CD53-58F4-40FD-B2F3-81A9F22F4731@holtmann.org> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org These 3 macros are never used from first git commit Linux-2.6.12-rc2. let's remove them. Signed-off-by: Alex Shi Cc: Marcel Holtmann Cc: Johan Hedberg Cc: "David S. Miller" Cc: "Gustavo A. R. Silva" Cc: linux-bluetooth@vger.kernel.org Cc: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- net/bluetooth/rfcomm/core.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/bluetooth/rfcomm/core.c b/net/bluetooth/rfcomm/core.c index 3a9e9d9670be..dcecce087b24 100644 --- a/net/bluetooth/rfcomm/core.c +++ b/net/bluetooth/rfcomm/core.c @@ -73,8 +73,6 @@ static struct rfcomm_session *rfcomm_session_create(bdaddr_t *src, /* ---- RFCOMM frame parsing macros ---- */ #define __get_dlci(b) ((b & 0xfc) >> 2) -#define __get_channel(b) ((b & 0xf8) >> 3) -#define __get_dir(b) ((b & 0x04) >> 2) #define __get_type(b) ((b & 0xef)) #define __test_ea(b) ((b & 0x01)) @@ -87,7 +85,6 @@ static struct rfcomm_session *rfcomm_session_create(bdaddr_t *src, #define __ctrl(type, pf) (((type & 0xef) | (pf << 4))) #define __dlci(dir, chn) (((chn & 0x1f) << 1) | dir) #define __srv_channel(dlci) (dlci >> 1) -#define __dir(dlci) (dlci & 0x01) #define __len8(len) (((len) << 1) | 1) #define __len16(len) ((len) << 1) -- 1.8.3.1