Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp64438ybv; Wed, 5 Feb 2020 01:11:58 -0800 (PST) X-Google-Smtp-Source: APXvYqyKSlJoTFl/XKGOkzTbeCM5ewQWyX9dnoyXErQgma/xjT+GtRsA+ChK1d2tiZz538zie0S8 X-Received: by 2002:a9d:66c1:: with SMTP id t1mr22959030otm.73.1580893918725; Wed, 05 Feb 2020 01:11:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580893918; cv=none; d=google.com; s=arc-20160816; b=Crv09EKKhMYx0fkAD5BP8KR4VF6LskJDdj/B6QpnYcHui/D/NGnCe9fE2BVzquPoc4 FScvCERrrx7svDK8gm8xCs5QV0Ql3tmoDNpgFpe9EV5A9Sz6/HJszu+dlCXEq3Y1u9y2 1tEU3xN3eLmMt1piOJ05xTPjQGM+F0DMfX6+/Dlc6YdZ48x1TRCD6leEpE8OTbu7zIOI xzWmBoj2otQanPg1Pzh0MRaAgGoK/eZh0R0zIeP0jFwPxW+30imWqZhjH3yzBehaBLp1 Zg0Xhj+P1JZPYz6ItEp4u8Lu3UeWANsht+P+ZG0wkeBQ7RTeZoNPFdLnloSxyu8QvQ4k PUhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=wVS/JVUmfm01+cAFXyMRKAHnPLkjHzEEpQaJRC3+JHE=; b=RowJohnadU4uCbl6JkIET7zaczKr7KSCrRhPBlbsbk6vXDSv8tRNhza8NOsZhbZDV7 iRVumQ7HIzYNw+ZO4lj8x9UVoaip2XFIHWqpiBy7FE0Jrwa86UhHKBKGmofoQQrI3zC0 zRSO864KoAmCdqgfyqn5jMD2NIj5nrekYWJiGNAUN01hScKZhdRK/oS+vGANLjYOBwuE e3LRwSolT5F8A4XkQ+C6C+1AsSwQZv7OrweXZCKKpnaQgzxGPRaCwl1x3xRdJLUUo/2S 0QdevhrpHaHQedn66wUZbneH76uOnmkUk3nORCsaMH6xDCFpbhikumgOK2XEThtrvGdh 50gg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z199si8495818oia.192.2020.02.05.01.11.45; Wed, 05 Feb 2020 01:11:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728117AbgBEJKZ (ORCPT + 99 others); Wed, 5 Feb 2020 04:10:25 -0500 Received: from mga12.intel.com ([192.55.52.136]:3362 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727068AbgBEJKZ (ORCPT ); Wed, 5 Feb 2020 04:10:25 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Feb 2020 01:10:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,405,1574150400"; d="scan'208";a="231654014" Received: from linux.intel.com ([10.54.29.200]) by orsmga003.jf.intel.com with ESMTP; 05 Feb 2020 01:10:24 -0800 Received: from [10.226.38.72] (unknown [10.226.38.72]) by linux.intel.com (Postfix) with ESMTP id 8B76C5805E9; Wed, 5 Feb 2020 01:10:21 -0800 (PST) Subject: Re: [PATCH v4 2/2] dt-bindings: clk: intel: Add bindings document & header file for CGU To: Stephen Boyd , linux-clk@vger.kernel.org, mark.rutland@arm.com, mturquette@baylibre.com, robh+dt@kernel.org, robh@kernel.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, andriy.shevchenko@intel.com, qi-ming.wu@intel.com, yixin.zhu@linux.intel.com, cheol.yong.kim@intel.com References: <24933f5f1c48a891f9c05c7292117108fc880932.1580374761.git.rahul.tanwar@linux.intel.com> <20200131022541.3853C2067C@mail.kernel.org> From: "Tanwar, Rahul" Message-ID: <556c2277-885c-f6be-60b3-564187618ca6@linux.intel.com> Date: Wed, 5 Feb 2020 17:10:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <20200131022541.3853C2067C@mail.kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stephen, Thanks for taking time out to review. On 31/1/2020 10:25 AM, Stephen Boyd wrote: > Quoting Rahul Tanwar (2020-01-30 01:04:03) >> Clock generation unit(CGU) is a clock controller IP of Intel's Lightning >> Mountain(LGM) SoC. Add DT bindings include file and document for CGU clock >> controller driver of LGM. >> >> Signed-off-by: Rahul Tanwar >> --- >> >> + >> +/* LJPLL4 */ >> +#define LGM_CLK_PCIE 45 >> +#define LGM_CLK_SATA LGM_CLK_PCIE > What is with the aliases? Aliases are just for code readability when more than one peripherals share the same clock. Regards, Rahul