Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 5 Feb 2020 10:11:26 +0100
From:   Jean Delvare <jdelvare@suse.de>
To:     Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc:     Tiezhu Yang <yangtiezhu@loongson.cn>,
        Paul Burton <paulburton@kernel.org>,
        Ralf Baechle <ralf@linux-mips.org>,
        Huacai Chen <chenhc@lemote.com>,
        Xuefeng Li <lixuefeng@loongson.cn>, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org, Yinglu Yang <yangyinglu@loongson.cn>
Subject: Re: [PATCH v2,RESEND] MIPS: Scan the DMI system information
Message-ID: <20200205101126.4fad0946@endymion>
In-Reply-To: <17537451580871338@vla4-87a00c2d2b1b.qloud-c.yandex.net>
References: <1579181165-2493-1-git-send-email-yangtiezhu@loongson.cn>
        <a267161f-c8b3-a11c-7416-3ab9ba19aa82@loongson.cn>
        <20200203131422.384cd168@endymion>
        <609c7042-0e44-2bd4-5e03-97465621b184@loongson.cn>
        <17537451580871338@vla4-87a00c2d2b1b.qloud-c.yandex.net>
Organization: SUSE Linux
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 05 Feb 2020 10:55:38 +0800, Jiaxun Yang wrote:
> > I think it is better to split it into the following two patches?
> > [PATCH v3 1/2] firmware: dmi: Add macro SMBIOS_ENTRY_POINT_SCAN_START
> > [PATCH v3 2/2] MIPS: Add support for Desktop Management Interface (DMI)  
> 
> That way will break bisect.

Are you sure? As far as I can see, each patch builds individually. The
dmi patch is a no-op alone. The mips patch will not work alone,
obviously, however according to Tiezhu dmi_scan_machine() will fail
with a harmless error message if the base address is 0xF0000. If that's
correct then it's not breaking bisect.

-- 
Jean Delvare
SUSE L3 Support