Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp297590ybv; Wed, 5 Feb 2020 05:50:49 -0800 (PST) X-Google-Smtp-Source: APXvYqzi0gSO84C9aXkauqdVYMwRTljqWuxFxiXraXiQQ8qm0VFjViLrFJH4AXKh7fxomZSzqoeQ X-Received: by 2002:a9d:7607:: with SMTP id k7mr14182217otl.205.1580910648827; Wed, 05 Feb 2020 05:50:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580910648; cv=none; d=google.com; s=arc-20160816; b=f5R2xNrQi6m6x5Mqm+z9SVN7TJr2E/RzJZB86xb0l47ZjBypzsPkE9DMpvT1feWkWN uPv+osvs6pKcvCeN6/7cuojN5v2XgewbYqLO+qRh+K29uCq6JMF4x3Q4mO6qn7eesa2P 94rYnWJ+0Jw1aYbvjaqbmXe9smUfcIZJEAJwnpjw3aZ6ZN27ET7Sp8e1HL5j4FpUR2R/ ugLqsPyXswBMGP6CTiZgYIhe1MY6ccaGR2jwQg3b/Qm2Px5RLxxmW6gXceONwNaTum/f QE58G5wlwK/cfs2z+cqLrmRSfYmFQbxpLgL39CQoD/k+jg53HpdY+lWM8mrhH0Sawf/Q yD9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=FOL1oRM9YcB/YNvyg6P6mdrrt6nvUUG79vGaLSQNBsE=; b=oY+/WaE/0e1Glqqi/7ZYVEzIZ1UeIr1eoz3rOo6eciQWY6xTZmcpGcUM+mZXp9oPa9 +4pdBnmos18nDAySWqQF89kkzx1sB2fXYIO0Wyg4EIOjRePzljvncpVmktDfirC0iVjY rmYluo2Dbc9kp3pbzC9ztiLf6pgB/u6K4EEH+xLE4AyaiHZkfSebhmMe40twfEsxv/cM bw8QmlsP5U89chJnIoSPx5n8Ugi3+uDmle/GC+wL6kwxis5Doa9BeR1rkNGqhV7XbjJs my3KJJ6QclQOS5iZoJfHzG3qGGhsJBqSUFW16T4hUVnBNLvwez3oPblDGnNd/hStq25k Zd2A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l6si12955127oti.249.2020.02.05.05.50.35; Wed, 05 Feb 2020 05:50:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728028AbgBENto (ORCPT + 99 others); Wed, 5 Feb 2020 08:49:44 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:47314 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726822AbgBENto (ORCPT ); Wed, 5 Feb 2020 08:49:44 -0500 Received: from localhost (unknown [IPv6:2001:982:756:1:57a7:3bfd:5e85:defb]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 2B97D158EDDC9; Wed, 5 Feb 2020 05:49:42 -0800 (PST) Date: Wed, 05 Feb 2020 14:49:40 +0100 (CET) Message-Id: <20200205.144940.712557491994145617.davem@davemloft.net> To: harini.katakam@xilinx.com Cc: nicolas.ferre@microchip.com, claudiu.beznea@microchip.com, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michal.simek@xilinx.com, harinikatakamlinux@gmail.com Subject: Re: [PATCH v3 0/2] TSO bug fixes From: David Miller In-Reply-To: <1580906292-19445-1-git-send-email-harini.katakam@xilinx.com> References: <1580906292-19445-1-git-send-email-harini.katakam@xilinx.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 05 Feb 2020 05:49:43 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Harini Katakam Date: Wed, 5 Feb 2020 18:08:10 +0530 > An IP errata was recently discovered when testing TSO enabled versions > with perf test tools where a false amba error is reported by the IP. > Some ways to reproduce would be to use iperf or applications with payload > descriptor sizes very close to 16K. Once the error is observed TXERR (or > bit 6 of ISR) will be constantly triggered leading to a series of tx path > error handling and clean up. Workaround the same by limiting this size to > 0x3FC0 as recommended by Cadence. There was no performance impact on 1G > system that I tested with. > > Note on patch 1: The alignment code may be unused but leaving it there > in case anyone is using UFO. > > Added Fixes tag to patch 1. Series applied and queued up for -stable, thank you.