Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp300540ybv; Wed, 5 Feb 2020 05:54:03 -0800 (PST) X-Google-Smtp-Source: APXvYqzOZwVQnnbM6C4WyY58Hv+ar6DQGdBbPTdC62kCX1OE6H6m7IpOVJUZn8SDfj8oJTkbXirh X-Received: by 2002:a9d:6e02:: with SMTP id e2mr26332787otr.194.1580910843674; Wed, 05 Feb 2020 05:54:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580910843; cv=none; d=google.com; s=arc-20160816; b=hr8EoIazmrEmurjgfjcG2NbDjGMhdoW+Ts86SjgfLhQxS1nyWaH6MQ37P1WaFG6oi0 jgPE2NgIJ122q0MgJt6BV/9baFEoj/nWR86aTQlicdWZ1AOftBlZ1KIMiuxRpGxmactg f+ExjcI5drfBb/OkNGTGiW3EEHK6q6Y4grpq14dMAp2BR0LMRjCGcLe9CGvquuEtkDKh cZ9DpzX3tJrGRRvtIV89KIAOQD4aOuFb65CvA8VK0zJmKBo5Y5rLxG43Gz9WEo6KZ5QQ nPIYeZ/18fRYQap+DHk8M78/X6RNQ223nb8zdseCzPFLslNXwrwrfU6Nlfq2+Du5DvQd a1xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=QYRfDWZUUtqTWM9My1jeCr++tfeRfO79KtdWK10VIjs=; b=sfp87k+W+clW3DVqxK/FQZ1CEAsXbS6bqPmYwGjU2SfM9YrJTYxttrJn3yTFhqskNE mVupGMuVrX5e3dLcVN6uk9A0+SebD8UCmkG8UvNCtlwgcqVzgO4jtIkgLeBveoKkZ+nC FMahF+dLLk6SEAeWyZKGsX+7BPPCzmuJGJ8ak0VwdaQVsZ0+ydplEdsK6msRuwtdkMUm KOMlxu2JHnHV5mCu8mf8n4XJDPWtkIBoacbvCuU1vLIO4d4aKK0aHD7FS1LbAfhO0mdT ieygJIlQbUKzHVzhTMePd7SyNHvstSu/+WMd0AdwHNoaYC1c1rMVmZtUHV3z8vopKXc3 +r6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=H6fVaPc+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v26si14286866otj.0.2020.02.05.05.53.51; Wed, 05 Feb 2020 05:54:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=H6fVaPc+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728133AbgBENwy (ORCPT + 99 others); Wed, 5 Feb 2020 08:52:54 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:40874 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728018AbgBENwy (ORCPT ); Wed, 5 Feb 2020 08:52:54 -0500 Received: by mail-pf1-f194.google.com with SMTP id q8so1243404pfh.7 for ; Wed, 05 Feb 2020 05:52:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=QYRfDWZUUtqTWM9My1jeCr++tfeRfO79KtdWK10VIjs=; b=H6fVaPc+LuRLDkElWAchKpNLhgRPwesVngj2xuybBCoFYnlFyQ/u8/STOOXNdzoE8u NrcXlX0l1tKgvRvNCcq70uEQNXfywgVo2U0GZyKReuOUeuOh14swQJ9PK9V2wfhbwItI 0BpVDDR0Wi1xpfz07Lx6Wc/Cc+oyzOKzNMG7ZugzvMP/k0QE9cZaXrAmglyDihldlgsi DdrMCvfCcSHBhSLGonRygTn2bcSD2aAkYstSXlnQPTcLFutkNtK1ay6TKM0Gren9Suru T0epaZdrS10K+4vnY0WKXZvOWlUbQM/rqSMexwkJPuYYSHoN9UKg+TSRu/mKnGyomkuF BZCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QYRfDWZUUtqTWM9My1jeCr++tfeRfO79KtdWK10VIjs=; b=jrLkM3C1MA9S48XAJyxUvp+QtpnqC2nHg7b+WgOEfBiDf/GFKuyhGK/eFh5PWCpMT6 CVA3dtgpzzuCeMmuOLqvKHcApqhCnmM7+kAepYPwS9wDCeiUQ6gNe+gzY7xKWqA0oZqW Q0DWWM+f9Us+CXmo6gUjHnZDVw8JeSjrXCe0NYNfAWKP5yJsEAbl4OFgHqXqvdD4TC4p BBwY2B/A+fEopmfNcBdcpfO2PIYv7GA8zg7DArYhmLmnlhMFsXv/q8RXwmEzNrwwQQF8 ttvkXG9LJDY3PXeZeljmM+oJrIyWP+DRt1cojUJTuu09d923/MGwwbVvvIz7EU0qhlgx jKVw== X-Gm-Message-State: APjAAAXj08c8/TQ1qod01HsvYm0ucirrEs20kKFmGmWxE/5sx0zuIyuB fTtygY46m49uhTq5L9jWqKo= X-Received: by 2002:a63:8743:: with SMTP id i64mr14847459pge.243.1580910773072; Wed, 05 Feb 2020 05:52:53 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id r66sm29853616pfc.74.2020.02.05.05.52.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Feb 2020 05:52:52 -0800 (PST) Subject: Re: [PATCH 1/2] staging: octeon: delete driver To: Geert Uytterhoeven Cc: Dan Carpenter , Matthew Wilcox , Chris Packham , "devel@driverdev.osuosl.org" , "brandonbonaby94@gmail.com" , "julia.lawall@lip6.fr" , "yuehaibing@huawei.com" , "paulburton@kernel.org" , "aaro.koskinen@iki.fi" , "gregkh@linuxfoundation.org" , "fw@strlen.de" , "linux-kernel@vger.kernel.org" , "ddaney@caviumnetworks.com" , "bobdc9664@seznam.cz" , "sandro@volery.com" , "ivalery111@gmail.com" , "ynezz@true.cz" , "davem@davemloft.net" , "wambui.karugax@gmail.com" References: <20191210091509.3546251-1-gregkh@linuxfoundation.org> <6f934497-0635-7aa0-e7d5-ed2c4cc48d2d@roeck-us.net> <20200204070927.GA966981@kroah.com> <1a90dc4c62c482ed6a44de70962996b533d6f627.camel@alliedtelesis.co.nz> <20200204203116.GN8731@bombadil.infradead.org> <20200205033416.GT1778@kadam> From: Guenter Roeck Message-ID: Date: Wed, 5 Feb 2020 05:52:50 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/5/20 1:03 AM, Geert Uytterhoeven wrote: > On Wed, Feb 5, 2020 at 4:57 AM Guenter Roeck wrote: >> On 2/4/20 7:34 PM, Dan Carpenter wrote: >>> On Tue, Feb 04, 2020 at 12:31:16PM -0800, Matthew Wilcox wrote: >>>> On Tue, Feb 04, 2020 at 08:06:14PM +0000, Chris Packham wrote: >>>>> On Tue, 2020-02-04 at 07:09 +0000, gregkh@linuxfoundation.org wrote: >>>>>> On Tue, Feb 04, 2020 at 04:02:15AM +0000, Chris Packham wrote: >>>>> On Tue, 2020-02-04 at 10:21 +0300, Dan Carpenter wrote: >>>>>> My advice is to delete all the COMPILE_TEST code. That stuff was a >>>>>> constant source of confusion and headaches. >>>>> >>>>> I was also going to suggest this. Since the COMPILE_TEST has been a >>>>> source of trouble I was going to propose dropping the || COMPILE_TEST >>>>> from the Kconfig for the octeon drivers. >>>> >>>> Not having it also causes problems. I didn't originally add it for >>>> shits and giggles. >>> >>> I wonder if the kbuild bot does enough cross compile build testing these >>> days to detect compile problems. It might have improved to the point >>> where COMPILE_TEST isn't required. > > It depends... > >> Not really. Looking at the build failures in the mainline kernel right now: >> >> Failed builds: >> alpha:allmodconfig >> arm:allmodconfig >> i386:allyesconfig >> i386:allmodconfig >> m68k:allmodconfig >> microblaze:mmu_defconfig >> mips:allmodconfig >> parisc:allmodconfig >> powerpc:allmodconfig >> s390:allmodconfig >> sparc64:allmodconfig > > I did receive a report from noreply@ellerman.id.au for the m68k build > failure. But that was sent to me only, not to the offender, and I do my > own builds anyway. > > More interesting, that report happened after the offending commit landed > upstream, while it had been in next for 4 weeks. > m68k in -next builds fine for me, and did for a while. I have not seen a build failure there. There must be a context commit causing this failure, or what is (or was) in -next differs from what is in mainline. >> Many of those don't even _have_ specific configurations causing the build failures. > > Exactly. These are the "easy" ones, as the all*config builds enable as > much infrastructure as possible. It's much harder if some common > dependency is not fulfilled in some specific config. > Yes, that is correct. But that doesn't mean that it would be a good idea to retire COMPILE_TEST. Guenter