Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp313777ybv; Wed, 5 Feb 2020 06:06:35 -0800 (PST) X-Google-Smtp-Source: APXvYqyBdYMBcN/nEZpysnQftjJ/R+2iQQPHwLOTPjyVG1GpSofUGtenfxtSCsacETZcLVtGeiFu X-Received: by 2002:aca:2118:: with SMTP id 24mr2937287oiz.28.1580911595466; Wed, 05 Feb 2020 06:06:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580911595; cv=none; d=google.com; s=arc-20160816; b=RSRXWzXJPllSJFhAlZG2b3U1jZhG9Z1s8OYXW4eGDkxXoZFAHn+qK5MkUyOBsrfVId 12XPTJT+icBZReUDLLBZCqVtlT4nJPZ7J0v4J6mUW/9+IvMWPQIyD2hvVHf0QREq13Ki mIHTN9VaaPU3T0mHUdthn5kPAIcHVqeO849Zlm3x24C/1EXodTWRsq5k5OkQhPlQ7MXj AyJODkBeZXg/41bEZdufL29sH5NWKFRvDTz2BlEruMwsFu2s9F5fD8Ym1QtwUjPJ0fLt rJW5OT8JYfhmo+gKyhthmKFwawI1Jv0A04xoA4k+IZOvX0BYbPmqhaz0VT2YYGwCzmxF GHAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=fbpmMHLGYfCb5hEyseXUTmFbKQXRdR8+g1ZxkhuxJBo=; b=Bze6/JAV6zRTMbOLXB0JEpM2eAt7uPcbjWfFhnGMCS+9xhF7o9yPlBSStIm/kfRv9r fF5fraZkPCczlKJOr3oMGfQ9YHCj0nz55LATPehi6sx8iUVfw6okxlCkKMu1KNfBJyBR SUJgjP52O7zKWIcm18e/z79ogR0jf6BOUMFrstCPRn9qulCAPNUJcXHQTQtrE+95NBOT FhPFNjfcj7aZtnHtIBVQZJUhDT4WKl0SlaSIEW5QApsV/8gMFrm99bJSmjCl7VIfL/Yn bIvz03WWvLJa2s8+cCcpreHMrV8vsc7LJib5hYkh5K2KQpM0YiAGy3dbD65UkNK2G5qK mtlg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q195si9125075oic.83.2020.02.05.06.06.11; Wed, 05 Feb 2020 06:06:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728129AbgBEOCn (ORCPT + 99 others); Wed, 5 Feb 2020 09:02:43 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:57912 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727468AbgBEOCn (ORCPT ); Wed, 5 Feb 2020 09:02:43 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 6D4B654E713B6850B9A8; Wed, 5 Feb 2020 22:02:39 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.439.0; Wed, 5 Feb 2020 22:02:29 +0800 From: Chen Zhou To: , , CC: , , Subject: [PATCH -next] scsi: ipr: remove redundant NULL check Date: Wed, 5 Feb 2020 21:56:49 +0800 Message-ID: <20200205135649.163926-1-chenzhou10@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Free function dma_pool_destroy() does NULL check, so the NULL check before dma_pool_destroy() is unnecessary, just remove it. Signed-off-by: Chen Zhou --- drivers/scsi/ipr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c index ae45cbe..f027cf3 100644 --- a/drivers/scsi/ipr.c +++ b/drivers/scsi/ipr.c @@ -9529,8 +9529,7 @@ static void ipr_free_cmd_blks(struct ipr_ioa_cfg *ioa_cfg) } } - if (ioa_cfg->ipr_cmd_pool) - dma_pool_destroy(ioa_cfg->ipr_cmd_pool); + dma_pool_destroy(ioa_cfg->ipr_cmd_pool); kfree(ioa_cfg->ipr_cmnd_list); kfree(ioa_cfg->ipr_cmnd_list_dma); -- 2.7.4