Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp483893ybv; Wed, 5 Feb 2020 08:58:04 -0800 (PST) X-Google-Smtp-Source: APXvYqznySl4jv6MEvYVTGDxKP8XBHyTvIRbuUDId25DLNkXntBvByp+8jq6CMxIbYR06ILwlNpK X-Received: by 2002:a9d:12cf:: with SMTP id g73mr25393708otg.329.1580921884459; Wed, 05 Feb 2020 08:58:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580921884; cv=none; d=google.com; s=arc-20160816; b=dkAiUrPM6Da1W+mdRdHmupU5IVx3wUNisKZwX2GHI3HRG7wUkuKE8c+8sbE0e2Shb1 kGU2FouYho7cLgd9rx8TLoW2RFMh9EM7J2TEUfrpeaNniwIf8EUY9GlRPUIdpXtzjVbt BA0/lUPPFMLImtMWCsWc4ek2YjQHrWfXxubFyj27k5rQztheCI6ZKaGsZyoWXh7Zldj+ RjnHVr/e5syN65P9v164SWhSUFprX4VBU53aDpeZMEvTenlmz/fO2hysX6OX80pcZKgW kDA/KSa0ymvS4Sh+GEgEGGewE4X6c1v4tB4i8TOVEehdDfP+5TeTSo3G9l7ohiBYoiJF iZog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from; bh=xfB1mvpw3J22yq5Ig/rx8Az0hCzj2Q1rltLZLMbXs3s=; b=qfLxK8h4ywTNBUuTCObiAE6i6z1e1b36isDee05wUXc5FbFgIDUAEN33j0qHpG9cAc xwIvRbPYWNWC9t/ZR7bi9e7HHKkG/qLuFLz8RmY7+hrBm4vbe6S7aAjmkzFrNMp7rmw0 ZjHtpl5LOa0vOOpxmuCX5VoQKQ7afvI0qJUSlFL41Hl6cN8rry6fNfxGyYsbK8Rq6V63 XkEZ4WJyDDnqhdnCr9h6euLTa2FJStTqBPP8aRKbcu9NGmUI/h0t7+uFP5oWM4aR5/Ei 8BLw5Pm5Mk2pkaRlCYzLaInbWVMxYsmIm1+1+ltWYE8PDQ84OY8aLJFDXwml4WkU3Q6o BUXg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h3si14337588otq.203.2020.02.05.08.57.49; Wed, 05 Feb 2020 08:58:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727516AbgBEQ40 (ORCPT + 99 others); Wed, 5 Feb 2020 11:56:26 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:32144 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727054AbgBEQ40 (ORCPT ); Wed, 5 Feb 2020 11:56:26 -0500 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 015GnpZJ131463; Wed, 5 Feb 2020 11:55:50 -0500 Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 2xyhmgwxt7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 05 Feb 2020 11:55:50 -0500 Received: from m0098414.ppops.net (m0098414.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 015Gp2Ri135129; Wed, 5 Feb 2020 11:55:50 -0500 Received: from ppma03wdc.us.ibm.com (ba.79.3fa9.ip4.static.sl-reverse.com [169.63.121.186]) by mx0b-001b2d01.pphosted.com with ESMTP id 2xyhmgwxsu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 05 Feb 2020 11:55:49 -0500 Received: from pps.filterd (ppma03wdc.us.ibm.com [127.0.0.1]) by ppma03wdc.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id 015GtnRg024988; Wed, 5 Feb 2020 16:55:49 GMT Received: from b03cxnp07029.gho.boulder.ibm.com (b03cxnp07029.gho.boulder.ibm.com [9.17.130.16]) by ppma03wdc.us.ibm.com with ESMTP id 2xykc9e4k8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 05 Feb 2020 16:55:49 +0000 Received: from b03ledav006.gho.boulder.ibm.com (b03ledav006.gho.boulder.ibm.com [9.17.130.237]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 015GtmHr11338068 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 5 Feb 2020 16:55:48 GMT Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5E96BC6063; Wed, 5 Feb 2020 16:55:48 +0000 (GMT) Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 34DA6C605A; Wed, 5 Feb 2020 16:55:48 +0000 (GMT) Received: from localhost (unknown [9.41.100.106]) by b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTP; Wed, 5 Feb 2020 16:55:48 +0000 (GMT) From: Nathan Lynch To: Michal Suchanek Cc: David Hildenbrand , Michal Suchanek , stable@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Mackerras , Leonardo Bras , Thomas Gleixner , Michal Suchanek , Allison Randal , linuxppc-dev@lists.ozlabs.org, Libor Pechacek Subject: Re: [PATCH v2] powerpc: drmem: avoid NULL pointer dereference when drmem is unavailable In-Reply-To: <20200131132829.10281-1-msuchanek@suse.de> References: <20200131132829.10281-1-msuchanek@suse.de> Date: Wed, 05 Feb 2020 10:55:47 -0600 Message-ID: <87r1z92cto.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-02-05_05:2020-02-04,2020-02-05 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=1 spamscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 mlxscore=0 clxscore=1011 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002050128 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Michal Suchanek writes: > From: Libor Pechacek > > In guests without hotplugagble memory drmem structure is only zero > initialized. Trying to manipulate DLPAR parameters results in a crash. > [...] > > Fixes: 6c6ea53725b3 ("powerpc/mm: Separate ibm, dynamic-memory data from DT format") > Cc: Michal Suchanek > Cc: stable@vger.kernel.org > Signed-off-by: Libor Pechacek > Signed-off-by: Michal Suchanek > --- > v2: rename last_lmb -> limit, clarify error condition. Acked-by: Nathan Lynch Thanks!