Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp510983ybv; Wed, 5 Feb 2020 09:23:37 -0800 (PST) X-Google-Smtp-Source: APXvYqyEkEg8DRbHATPWME2l95ct0/r0eE7sECAQ41TA78NjYPdDLujm5wSIryr8vlNnU7JbbXYt X-Received: by 2002:aca:c692:: with SMTP id w140mr3867086oif.139.1580923416984; Wed, 05 Feb 2020 09:23:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580923416; cv=none; d=google.com; s=arc-20160816; b=KDh6+meYpsnmI0pA3M7mWMbGHcQLATwRRTagIDrlaH2yAC//idqC8loHcYZAce/mQX UhKO6QjeVDRSxqeVLaFU9KUpCc35wQp3EN9XohDt8sGG1kE8sXZXK1QHw16mKTMYGAD4 q0pawuthCoCbIDFuBBwFKnQlWfx9KL6j/1h+v/XeWi4sB/S3CqFU+lj64Bk8HLlZTr+D /3i0l8rw18bQbRGOtu7IkawOwE5UwFtaO21DwbXtAzIT9UfFzyQnnkB2mVK+a5wHPG8C sVUVqcPOe1ivDCt9ePu8TlN/UTLeev/QJji6acR8iWlRKsP9vbGX7gaUFe8Efz3WJHfN 3utA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=LeEuRMcjzD1S5zh7QTk0/nyyI+phqFYrJTxuryABbfk=; b=yOlCvHATUxcPiWBPfanpOybDxmh2LKMWsTbdeJMmt5rQv9Px1xyOP7KCed7b/PbhDv jT008CumcS3+mMZwQZU+eslHBel8O3X/PNMvaet4bhtG7Y/V488QWxwSlH5BwZsVSg2/ mEslBfcC5xoWCKgk3804JAnkYf3Ua6gYNZAjLLpLotvPYgd/JgZ8UfncUXOxAjxStmJh 9Cr7H9Aa9Eq3jkNTSRZCK7Bofi188UX/UYYYreaH3foPGA8jQwxLqz8szQWWFadmrc9B iHJgvb4fjatKkgXohpeiOSSXpBHAX5ZT0SLX6oY2ObqWD5D5Ahqv5bnOtCWulLlmsd8q NhjQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y73si348717oia.246.2020.02.05.09.23.24; Wed, 05 Feb 2020 09:23:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727149AbgBERWR (ORCPT + 99 others); Wed, 5 Feb 2020 12:22:17 -0500 Received: from mga03.intel.com ([134.134.136.65]:7727 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726957AbgBERWR (ORCPT ); Wed, 5 Feb 2020 12:22:17 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Feb 2020 09:22:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,406,1574150400"; d="scan'208";a="254826270" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.21]) by fmsmga004.fm.intel.com with ESMTP; 05 Feb 2020 09:22:15 -0800 Received: by tassilo.localdomain (Postfix, from userid 1000) id AF2C63003A2; Wed, 5 Feb 2020 09:22:15 -0800 (PST) Date: Wed, 5 Feb 2020 09:22:15 -0800 From: Andi Kleen To: Hagen Paul Pfeifer Cc: linux-kernel@vger.kernel.org, Adrian Hunter , Jiri Olsa , Arnaldo Carvalho de Melo Subject: Re: [PATCH] perf script: introduce deltatime option Message-ID: <20200205172215.GG302770@tassilo.jf.intel.com> References: <20200204173709.489161-1-hagen@jauu.net> <20200204231628.GF302770@tassilo.jf.intel.com> <20200205091414.GB495987@virgo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200205091414.GB495987@virgo> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > reltime is relative to the *first event* in the record - deltatime is relative > to the *previous* event. Ah ok. I think it's useful, but you should rather implement it as a new field instead of as an option. There might be use cases where you want both. delta time is easier for reading, but absolute time is often important to find something in a trace. -Andi