Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 5 Feb 2020 10:40:38 -0700
From:   Jonathan Corbet <corbet@lwn.net>
To:     Stephen Kitt <steve@sk2.org>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Allow git builds of Sphinx
Message-ID: <20200205104038.7b27a94f@lwn.net>
In-Reply-To: <20200124183316.1719218-1-steve@sk2.org>
References: <20200124183316.1719218-1-steve@sk2.org>
Organization: LWN.net
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 24 Jan 2020 19:33:16 +0100
Stephen Kitt <steve@sk2.org> wrote:

> When using a non-release version of Sphinx, from a local build (with
> improvements for kernel doc handling, why not),
> 
> 	sphinx-build --version
> 
> reports versions of the form
> 
> 	sphinx-build 3.0.0+/4703d9119972
> 
> i.e. base version, a plus symbol, slash, and the start of the git hash
> of whatever repository the command is run in (no, not the hash that
> was used to build Sphinx!).
> 
> This patch fixes the installation check in sphinx-pre-install to
> recognise such version output.
> 
> Signed-off-by: Stephen Kitt <steve@sk2.org>
> ---

Seems useful.  Applied, thanks.

jon