Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp541608ybv; Wed, 5 Feb 2020 09:58:33 -0800 (PST) X-Google-Smtp-Source: APXvYqzC3UCbnSlaPXSOkoAOGj4bpf0tpKvQcKbxPQT8r2Dim/6ksaob6egJYM2LqCxbKSR2iUNO X-Received: by 2002:aca:4106:: with SMTP id o6mr3852133oia.173.1580925513198; Wed, 05 Feb 2020 09:58:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580925513; cv=none; d=google.com; s=arc-20160816; b=poLFcD9ISzTpWxzC6e6KKGI+YaMBWxCairGOn0qxw920jQQZqysE8UYsgaWswiZLgi 4Nej8mpYUkt1YNY08oyIoJuLv3JWvJ+7qqWeX02y18IAxuZg/JYetPU/a41AtYOKa0NI 3JqwY8pk0UHojjO+whCRquaehlsfWvlbg3Wq8/0jWXilXsChyC809c7jid/rfP+hJcWd nZhoUSNM5TqeI7psF2pKYFtInJDp4vGXMslqmSqy7SAEqfZe9NGdX77hgFvpBt+VeThc 6FtmnTulR6lall03BSR2yi12V5uTLdWYWJYFMfTlPIzc2zyUxg7nfae29gjDfy1E/Ikp cw1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from; bh=WZcv1SDekaVfalQ2fYokf9ZMEB3dBhpueabWBpDhBJ8=; b=AEt8efNBEo/ttrypm89l4ux37OXAsSdu53lJsPfz0u2+Qm1uIAhK/4SMIvFdG19aHK 7hff/7s0vEI7z7m1unzi1If5Kxgb9xnDztpsHV/MwHI3ZyU4DOhKoTygT6n0pQ36naiQ OXpErSDh2YGsos9S2OdP/OfFfNvMf0xKb+piK9GQQg0i+Te6tmqk3sjy81g3u+40bPGJ vccl7u7O+y2A2MKs+yeV1e/WaIQoNdlJbJqMJUP4x3WK7Bg9mi/xCaGwSURo/MXbOHmw 8G63lyq//1X95JRy2IqSolGXka8/DUxQL+JiIkBu2zOzUEipUSl4kGmnN/C2t/7rNAl8 Ws6A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w7si442863oie.196.2020.02.05.09.58.20; Wed, 05 Feb 2020 09:58:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727282AbgBER5S convert rfc822-to-8bit (ORCPT + 99 others); Wed, 5 Feb 2020 12:57:18 -0500 Received: from smtp10.smtpout.orange.fr ([80.12.242.132]:18412 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727081AbgBER5S (ORCPT ); Wed, 5 Feb 2020 12:57:18 -0500 Received: from belgarion ([109.220.251.231]) by mwinf5d45 with ME id z5xE2100A50Jj11035xEhh; Wed, 05 Feb 2020 18:57:15 +0100 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Wed, 05 Feb 2020 18:57:15 +0100 X-ME-IP: 109.220.251.231 From: Robert Jarzmik To: Lubomir Rintel , Bartosz Golaszewski Cc: Linus Walleij , linux-gpio , LKML Subject: Re: [PATCH] gpio: pxa: Avoid a warning when gpio0 and gpio1 IRQS are not there References: <20200128210845.332679-1-lkundrak@v3.sk> X-URL: http://belgarath.falguerolles.org/ Date: Wed, 05 Feb 2020 18:57:00 +0100 In-Reply-To: (Bartosz Golaszewski's message of "Tue, 4 Feb 2020 11:13:44 +0100") Message-ID: <87ftfo29zn.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/26 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Bartosz Golaszewski writes: > wt., 28 sty 2020 o 22:08 Lubomir Rintel napisaƂ(a): >> >> Not all platforms use those. Let's use >> platform_get_irq_byname_optional() instead platform_get_irq_byname() so >> that we avoid a useless warning: >> >> [ 1.359455] pxa-gpio d4019000.gpio: IRQ gpio0 not found >> [ 1.359583] pxa-gpio d4019000.gpio: IRQ gpio1 not found >> >> Signed-off-by: Lubomir Rintel Okay, what would have really be nice in the commit message was to state _which_ platform doesn't use these, and still use pxa-gpio as their gpio driver. Cheers. -- Robert PS: And yes, my response is late, but I'm moving house so my ping is huge lately.