Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp672413ybv; Wed, 5 Feb 2020 12:22:27 -0800 (PST) X-Google-Smtp-Source: APXvYqz//i1Vc2C6hM3grAaHvYZ7Snzc9QTdloPa+LMjtjjxs1D7Wp2HbdCcnGq+CsdqhmRqypdC X-Received: by 2002:a9d:394:: with SMTP id f20mr27537064otf.148.1580934146924; Wed, 05 Feb 2020 12:22:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580934146; cv=none; d=google.com; s=arc-20160816; b=XOpaX6jM8+K73UmbZesMKZ6oLdBjQjc7shZmELQE4CWVoK6j7vJB72VLL01Qb4ZR1a 8sdweqbIH++4RFHOByKJEqUV73b0R3gIpfxdZhf8R+BhFVQxOR4cJz+egcv/O0WL+4q1 8hk2PVmYXfAVptkKPgtpnYbR1kd8ag42lg7yXmQsRFwDWYvNfu3eKCoh8qou3TE/STM8 w6ZdgOd02xusxHwg8RHkwdJ1DMMOvPX1wBPgGhU3MlR50iM49ceaeIpW6feqNOtt3mxm HYSQu5LaADcBXDmJ5RZE/3G725cWCZHb6C0UGvngAsumm/Oin5n+xseHTIze5tyVXMUW KUCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=JlLlxcQrpMkFUoU3hq5dL+E4UdUH5CDEd0YwvUejnVU=; b=J/rjq/5EKaZXtaQNrvGZwLJp8UIaRoNK9Czk+1wlhWginCYQ6tEG5Nzvmm1KwElis5 oJJlqLA+4z4S4stdgBqWLHcsX1ZilLLJYEGPtjmBV/3bR5GmmJuGJH/MGg1Hq368+CGm iTpfD2cohA65BUw3INxnugEpUiLlUdWI9YANCqEBU0uTNmGEmzldXS3E3pii6GdWkX37 F7bmrtbCfVzaWGDnQNLbANwLrhqF0LnfZsPVIgCtbxF6sg4gkOxqHCMYWG1ogq40f1Cd ngKxbwZQI6wxNLwFbhT+ShMMZNFZnEZ1OvXdhNJCmAfCEzHqOrDp2hmaiCy/2pqkCiSW 0U2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=oxenJqq8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w142si719917oia.132.2020.02.05.12.22.01; Wed, 05 Feb 2020 12:22:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=oxenJqq8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727104AbgBEUUZ (ORCPT + 99 others); Wed, 5 Feb 2020 15:20:25 -0500 Received: from mail-il1-f195.google.com ([209.85.166.195]:35207 "EHLO mail-il1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726208AbgBEUUY (ORCPT ); Wed, 5 Feb 2020 15:20:24 -0500 Received: by mail-il1-f195.google.com with SMTP id g12so3038003ild.2 for ; Wed, 05 Feb 2020 12:20:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JlLlxcQrpMkFUoU3hq5dL+E4UdUH5CDEd0YwvUejnVU=; b=oxenJqq82hLbOY7iPrO4DykFZo5N5e0MnyDP4aMCZ4rNnPVzW7PVckpP2qD7MWebBl Al2LFHbYZUmY6P3jBNPQTFTJATaNYQgghy5BquPjuhetKLPYg9SYNadMl/MB5nl7p4qg fP4YnhAj3q8n1AbMRpiGqJzn+4OeEEOrK6Re9bVBJ1d/IuaQkN3rb6jYEWcjVskRYLp5 vWHG9YVnk4VtWVbENO1Fy3klZ4pRRQAwj+tfauQTnQrm5eYUVWtjg7IuVHH6cFLXArQ9 PWBduhU9ZJSz1uDA/+UGLI7zagtMps7gLmNwuAHjyETzuhbO2L6Wzt2/DjinPhcQ6ge4 Q1gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JlLlxcQrpMkFUoU3hq5dL+E4UdUH5CDEd0YwvUejnVU=; b=fjClK4UAnOyR054PeQY6OsnfO+xsirM1Yn2ZbKLmO1goc9mQGsacUhZ2svtwzIetOo 90O1pewahVIwgmvWSC8shiThrm2YHMZASB+mqRqu2Qk8THl3FAtYWZhF1Bfuy6dCvTgd DZRkd032QPl4+wOH2u16UoGvnc9v2/h3ZbpdXWeFrquXn3SV6AODT9/iQ/n0BUz+YEsS NFF/nxlHF/sKxSjmESvrgJ+YULMjLzxGx48gy5rSb+1AKaKckbt/wsKPqp1bAzGeDB91 llK5fy9e3FQYQ3nkeRCfoE91feQJ0Bg4GnlvelXGlhnOTE8/AbthwAD408ZgJ5avP66r Q/1g== X-Gm-Message-State: APjAAAXUHUUPE4izEGc0xCD4VznMml21a7rY9X31+YmsCKBRpPXezNct 75M1kCBe55xVafDNCn/wgViw1DRMF5gem0gN/M0= X-Received: by 2002:a92:9e97:: with SMTP id s23mr29405150ilk.139.1580934023820; Wed, 05 Feb 2020 12:20:23 -0800 (PST) MIME-Version: 1.0 References: <20200205102552.21409-1-kraxel@redhat.com> In-Reply-To: <20200205102552.21409-1-kraxel@redhat.com> From: Chia-I Wu Date: Wed, 5 Feb 2020 12:20:12 -0800 Message-ID: Subject: Re: [PATCH] drm/virtio: ratelimit error logging To: Gerd Hoffmann Cc: ML dri-devel , Gurchetan Singh , David Airlie , Daniel Vetter , "open list:VIRTIO GPU DRIVER" , open list Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 5, 2020 at 2:26 AM Gerd Hoffmann wrote: > > Avoid flooding the log in case we screw up badly. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Chia-I Wu > --- > drivers/gpu/drm/virtio/virtgpu_vq.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c > index 5914e79d3429..83f22933c3bb 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_vq.c > +++ b/drivers/gpu/drm/virtio/virtgpu_vq.c > @@ -212,9 +212,9 @@ void virtio_gpu_dequeue_ctrl_func(struct work_struct *work) > if (resp->type >= cpu_to_le32(VIRTIO_GPU_RESP_ERR_UNSPEC)) { > struct virtio_gpu_ctrl_hdr *cmd; > cmd = (struct virtio_gpu_ctrl_hdr *)entry->buf; > - DRM_ERROR("response 0x%x (command 0x%x)\n", > - le32_to_cpu(resp->type), > - le32_to_cpu(cmd->type)); > + DRM_ERROR_RATELIMITED("response 0x%x (command 0x%x)\n", > + le32_to_cpu(resp->type), > + le32_to_cpu(cmd->type)); > } else > DRM_DEBUG("response 0x%x\n", le32_to_cpu(resp->type)); > } > -- > 2.18.1 >