Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 5 Feb 2020 17:34:15 -0500
From:   Joel Fernandes <joel@joelfernandes.org>
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
        paulmck@kernel.org, frextrite@gmail.com, rcu@vger.kernel.org,
        madhuparnabhowmik04@gmail.com
Subject: Re: [PATCH] kernel/trace: Use rcu_assign_pointer() for setting
 fgraph hash pointers
Message-ID: <20200205223415.GA55522@google.com>
References: <20200205221808.54576-1-joel@joelfernandes.org>
 <20200205172529.4282a0d1@oasis.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200205172529.4282a0d1@oasis.local.home>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Feb 05, 2020 at 05:25:29PM -0500, Steven Rostedt wrote:
> On Wed,  5 Feb 2020 17:18:08 -0500
> "Joel Fernandes (Google)" <joel@joelfernandes.org> wrote:
> 
> > set_ftrace_early_graph() sets pointers without any explicit
> > release-barriers. Let us use rcu_assign_pointer() to ensure the same.
> > 
> > Note that ftrace_early_graph() calls ftrace_graph_set_hash() which does
> > do mutex_unlock(&ftrace_lock); which should imply a release barrier.
> > However it is better to not depend on it and just use
> > rcu_assign_pointer() which should also avoid sparse errors in the
> > future.
> 
> This is going to have to wait for the next merge window, as I'm already
> *very* late, and I've pushed the limit to what I will add at this time
> frame.

I understand, no problem. I will resend it next merge window.

thanks,

 - Joel

> 
> -- Steve
>