Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] kbuild: Include external modules compile flags
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        dev@openvswitch.org, dsahern@gmail.com
References: <1580161806-8037-1-git-send-email-gvrose8192@gmail.com>
 <CAK7LNAQyh9CFgKd1DtAPFW8DuHNp1gn8YABuP8-LsF=hHK2DFw@mail.gmail.com>
 <f6ffa0d0-8214-8fc0-4fe9-4b70a1581d3e@gmail.com>
 <677aff5a-a52e-08ae-f341-547af08f7566@gmail.com>
 <CAK7LNARsBQm8jTs6PZDHAVFX4GZ_=Ls-5MOutNJFOHBN29Gd5w@mail.gmail.com>
From:   Gregory Rose <gvrose8192@gmail.com>
Message-ID: <fffab888-8337-c659-fcb6-4f9fa765513a@gmail.com>
Date:   Wed, 5 Feb 2020 14:48:26 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.2
MIME-Version: 1.0
In-Reply-To: <CAK7LNARsBQm8jTs6PZDHAVFX4GZ_=Ls-5MOutNJFOHBN29Gd5w@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2/1/2020 10:07 PM, Masahiro Yamada wrote:
> On Thu, Jan 30, 2020 at 3:09 AM Gregory Rose <gvrose8192@gmail.com> wrote:
>>
>> On 1/28/2020 7:37 AM, Gregory Rose wrote:
>>> On 1/27/2020 7:35 PM, Masahiro Yamada wrote:
>>>> On Tue, Jan 28, 2020 at 6:50 AM Greg Rose <gvrose8192@gmail.com> wrote:
>>>>> Since this commit:
>>>>> 'commit 9b9a3f20cbe0 ("kbuild: split final module linking out into
>>>>> Makefile.modfinal")'
>>>>> at least one out-of-tree external kernel module build fails
>>>>> during the modfinal make phase because Makefile.modfinal does
>>>>> not include the ccflags-y variable from the exernal module's Kbuild.
>>>> ccflags-y is passed only for compiling C files in that directory.
>>>>
>>>> It is not used for compiling *.mod.c
>>>> This is true for both in-kernel and external modules.
>>>>
>>>> So, ccflags-y is not a good choice
>>>> for passing such flags that should be globally effective.
>>>>
>>>>
>>>> Maybe, KCFLAGS should work.
>>>>
>>>>
>>>> module:
>>>>          $(MAKE) KCFLAGS=...  M=$(PWD) -C /lib/modules/$(uname
>>>> -r)/build modules
>>>>
>> Hi Masahiro,
>>
>> I'm unable to get that to work.  KCFLAGS does not seem to be used in
>> Makefile.modfinal.
>
> I quickly tested it, and confirmed
> KCFLAGS works for external modules, too.
>
>
> Makefile.modfinal includes scripts/Makefile.lib
>
>
> So,  c_flags contains $(KCFLAGS)
>
>   c_flags -> KBUILD_CFLAGS -> KCFLAGS
>
>
Hi Masahiro,

I found a way to make this work on the openvswitch out of tree kernel 
module.  KCFLAGS
doesn't work because it is added at the end of the gcc command line and 
we need to
add a '-include <file>' directive so that the include file comes 
*before* all other include
files.  I fix this by inserting the '-include <file>' command line 
option to the beginning
of our own Kbuild NOSTDINC variable.

Thanks for your help in debugging this.

- Greg