Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200202014624.75356-1-hridya@google.com>
In-Reply-To: <20200202014624.75356-1-hridya@google.com>
From:   Paul Moore <paul@paul-moore.com>
Date:   Wed, 5 Feb 2020 18:28:44 -0500
Message-ID: <CAHC9VhR-aUtrU4PTibDLLG2S5GB9bx9MtwKuyH-x9eqSCmyP9w@mail.gmail.com>
Subject: Re: [PATCH] selinux: Fix typo in filesystem name
To:     Hridya Valsaraju <hridya@google.com>
Cc:     Stephen Smalley <sds@tycho.nsa.gov>,
        Eric Paris <eparis@parisplace.org>,
        Jeff Vander Stoep <jeffv@google.com>,
        Mark Salyzyn <salyzyn@android.com>, selinux@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-team@android.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Feb 1, 2020 at 8:46 PM Hridya Valsaraju <hridya@google.com> wrote:
>
> Correct the filesystem name to "binder" to enable
> genfscon per-file labelling for binderfs.
>
> Fixes: 7a4b5194747 ("selinux: allow per-file labelling for binderfs")
> Signed-off-by: Hridya Valsaraju <hridya@google.com>
> ---
>
> Hello,
>
> I seem to have made the typo/mistake during a rebase. Sorry about that
> :(
>
> Thanks,
> Hridya
>
>  security/selinux/hooks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Ooops :/

Thanks for the fix.  I've merged this into selinux/stable-5.6, but due
to some personal scheduling issues on my end I'm going to refrain from
sending this to Linus until next week.

> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index 89fe3a805129..d67a80b0d8a8 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -699,7 +699,7 @@ static int selinux_set_mnt_opts(struct super_block *sb,
>
>         if (!strcmp(sb->s_type->name, "debugfs") ||
>             !strcmp(sb->s_type->name, "tracefs") ||
> -           !strcmp(sb->s_type->name, "binderfs") ||
> +           !strcmp(sb->s_type->name, "binder") ||
>             !strcmp(sb->s_type->name, "pstore"))
>                 sbsec->flags |= SE_SBGENFS;
>
> --
> 2.25.0.341.g760bfbb309-goog

-- 
paul moore
www.paul-moore.com