Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Nikita Shubin <NShubin@topcon.com>
Cc:     NShubin@topcon.com, Ohad Ben-Cohen <ohad@wizery.com>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] remoteproc: warn on kick missing
Date:   Thu,  6 Feb 2020 08:54:19 +0300
Message-Id: <20200206055419.15897-1-NShubin@topcon.com>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain
MIME-Version: 1.0
Received-SPF: None (protection.outlook.com: topcon.com does not designate
 permitted sender hosts)
X-MS-Exchange-CrossTenant-Network-Message-Id: 20085c89-d4f6-4aa9-fd4e-08d7aac8ea5b
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2020 05:53:40.1341
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 96c2c3ba-19d3-47b6-ba0b-8f7471bd1f14
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Y/6DcAlTv+7x6iTfv5zbXJwgFemfWDFE4m10oo8h7I2Mb+hHG6nrwpst1vvhqRrrHQ5Te0HoLUcbcaDfRwQoGQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR06MB6128
To:     unlisted-recipients:; (no To-header on input)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

.kick method not set in rproc_ops will result in:

8<--- cut here ---
Unable to handle kernel NULL pointer dereference

in rproc_virtio_notify, after firmware loading.

At least a warning needed on attempt to call missing method.

Signed-off-by: Nikita Shubin <NShubin@topcon.com>
---
 drivers/remoteproc/remoteproc_virtio.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/remoteproc/remoteproc_virtio.c b/drivers/remoteproc/re=
moteproc_virtio.c
index 8c07cb2ca8ba..77a81f331e3f 100644
--- a/drivers/remoteproc/remoteproc_virtio.c
+++ b/drivers/remoteproc/remoteproc_virtio.c
@@ -32,6 +32,12 @@ static bool rproc_virtio_notify(struct virtqueue *vq)

        dev_dbg(&rproc->dev, "kicking vq index: %d\n", notifyid);

+       if (unlikely(rproc->ops->kick =3D=3D NULL)) {
+               WARN_ONCE(rproc->ops->kick =3D=3D NULL, ".kick method not d=
efined for %s",
+                       rproc->name);
+               return false;
+       }
+
        rproc->ops->kick(rproc, notifyid);
        return true;
 }
--
2.24.1

Confidentiality Notice: This message (including attachments) is a private c=
ommunication solely for use of the intended recipient(s). If you are not th=
e intended recipient(s) or believe you received this message in error, noti=
fy the sender immediately and then delete this message. Any other use, rete=
ntion, dissemination or copying is prohibited and may be a violation of law=
, including the Electronic Communication Privacy Act of 1986.   =AD=AD