Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1310123ybv; Thu, 6 Feb 2020 01:41:52 -0800 (PST) X-Google-Smtp-Source: APXvYqzcGWNNTV7i4Xm1hXIptM/ebOOeUY6JdTge4x2xVxeHYLqODVoqT0iRniK+yTfmUPljPwEB X-Received: by 2002:aca:f354:: with SMTP id r81mr6092779oih.90.1580982111781; Thu, 06 Feb 2020 01:41:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580982111; cv=none; d=google.com; s=arc-20160816; b=MW2M/lCCGLsmVi3RnstwZDPPDg4oLMXw7YNbNiw5pgs6i9aVJyq8SK/fDISjk0p1TN pU+ojH9UoVOMbWXqu226Y6iX0KGqwyd96L/sTC8AktezA5CY1FOueE/f1lVPjXFbzqhD JrFxMStnrA6k0wBL4Aq9QgwSR2jTpkojP4l22F0YbiVNj4vNc6aaxI0pJEwS/d1qYkF4 Hl9h/rZFJVjJcgaZwn1I1nI5sNVnRtCaMjouERzddpQM66HpJrYM03gkW+uM3g3YYcRB TMn2Dt/BD06a5Ga94hS9MB1kJEeOC/l5RWkRB+h0hFk6k5Ob8In1MrWWc2t1Hf8hLHzN H+WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=hyxflvdPkH1sSVjFxEnax3xstwJwmc+m7jt5bIt+1Yw=; b=CwNl8XuV3hw7oZyphBMTzou84c0jfbMsdjzA7PoDwfG7WVEofSC7+pokEh8R3yDj7J tks1QfU9kufi66+mf8VMVWs8PWeDxkS6bBpmtmaRKOIISRtmO/xiTyWRuOLAgaBqWNWa AlV2D/KcyzLrQBs0YnmyAcCoMVOCE9FnFhvMK6mKqtWALD5XPLpIvY5n5oKMmyRnrydS H/AldxKEztKuOHx30rQtzpYalASiRJVoaeg/mbro6zmkvYXlMh4HafGBxVDsvHfMH0ee Hod8cjDYGpWF3b5W+/VOx1t5gc/UIhHmP8dJshXd3qXAFenIM0FYBm0zLcXyqB32Nx0F a+Ag== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i6si1857428otj.24.2020.02.06.01.41.39; Thu, 06 Feb 2020 01:41:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728331AbgBFJM2 (ORCPT + 99 others); Thu, 6 Feb 2020 04:12:28 -0500 Received: from alexa-out-blr-01.qualcomm.com ([103.229.18.197]:3864 "EHLO alexa-out-blr-01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727848AbgBFJM1 (ORCPT ); Thu, 6 Feb 2020 04:12:27 -0500 Received: from ironmsg02-blr.qualcomm.com ([10.86.208.131]) by alexa-out-blr-01.qualcomm.com with ESMTP/TLS/AES256-SHA; 06 Feb 2020 14:42:24 +0530 Received: from harigovi-linux.qualcomm.com ([10.204.66.157]) by ironmsg02-blr.qualcomm.com with ESMTP; 06 Feb 2020 14:42:04 +0530 Received: by harigovi-linux.qualcomm.com (Postfix, from userid 2332695) id 54F7C28E6; Thu, 6 Feb 2020 14:42:03 +0530 (IST) From: Harigovindan P To: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org Cc: Harigovindan P , linux-kernel@vger.kernel.org, robdclark@gmail.com, seanpaul@chromium.org, hoegsberg@chromium.org, kalyan_t@codeaurora.org, nganji@codeaurora.org Subject: [v1] drm/msm/dsi/pll: call vco set rate explicitly Date: Thu, 6 Feb 2020 14:42:01 +0530 Message-Id: <1580980321-19256-1-git-send-email-harigovi@codeaurora.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org For a given byte clock, if VCO recalc value is exactly same as vco set rate value, vco_set_rate does not get called assuming VCO is already set to required value. But Due to GDSC toggle, VCO values are erased in the HW. To make sure VCO is programmed correctly, we forcefully call set_rate from vco_prepare. Signed-off-by: Harigovindan P --- Changes in v1: - Calling set rate from vco_prepare drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c b/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c index 1c89454..6ac04fc 100644 --- a/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c +++ b/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c @@ -411,6 +411,12 @@ static int dsi_pll_10nm_vco_prepare(struct clk_hw *hw) if (pll_10nm->slave) dsi_pll_enable_pll_bias(pll_10nm->slave); + rc = dsi_pll_10nm_vco_set_rate(hw,pll_10nm->vco_current_rate, 0); + if (rc) { + pr_err("vco_set_rate failed, rc=%d\n", rc); + return rc; + } + /* Start PLL */ pll_write(pll_10nm->phy_cmn_mmio + REG_DSI_10nm_PHY_CMN_PLL_CNTRL, 0x01); -- 2.7.4