Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1355388ybv; Thu, 6 Feb 2020 02:39:25 -0800 (PST) X-Google-Smtp-Source: APXvYqzear/3yGojsgDkOZMFIfyRLH2ySaDgMmb1zp1IjwPGPrZGTC+LwvDhSw39jeKlGIylxpAp X-Received: by 2002:a05:6830:1e72:: with SMTP id m18mr28036352otr.226.1580985565016; Thu, 06 Feb 2020 02:39:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580985565; cv=none; d=google.com; s=arc-20160816; b=SQk0+qrD8qGavfhOnfcLgDGdBEelt9R9i0meQ6fHTCxV4oSIqR9MOOJLjoJYXIO5oi NeAHLsNdSYmMB8S5mfkEwdZr/VbMbanJET1lM9tLcrNq4jjeQIs0MRZsrep5wKo47SSR CT0ccoOe1rOytzJk8OfyQTs3TiQO8E3r7MizEl5ZMEpAT4R6oe2EYfagYigydX050E1A rBWusgBhiP8tRrNcCFhSjQyU7we1XluIpBu0IfL8PvoWDfcJebMwX72IYLxZGJVOMXTK ZdUMIEdG36AsHk84IDF1/09mJ+19VFQ0w9JhTjJfCTwDFp7JNCppABZBvoSrB28EJVZm 0xWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=iqFcvoPw8DcFhtobWmJ0Y2CIxJP8eCyXtt0XGuUZrno=; b=oj6shakhzfCPgtOW3ciyk3FL+HMg93k4KfDkrYbF14zu9NegrPAIKXrm1skLsXj5IS /LXBlm5lzSCBrDzxEIvajEhgG1seZia1g1ozUT40BE4U5pZGY0vx6hGl9gXNH9LYa+vr DUUmNBblLmaWNY5QjEedltvv1t2ihaPMgyMMrsgac/1/hNmU75XAWlPv2vTnFWUxm/IL +/vUDrfUP+NHi9GIhFRxRhD9Z7Wdwjw/9pIDEHXFXsgOBTfv/FwjMHXnw+TbDbkFWhvH 6jmHJbrjkLc6x0JQkTvfHf7ABvkPMyoy26nPlgPlRS5O7cXsElaaw0GEkjuXDZ07POsR /Zdw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n186si1887663oig.191.2020.02.06.02.39.10; Thu, 06 Feb 2020 02:39:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728143AbgBFIw1 (ORCPT + 99 others); Thu, 6 Feb 2020 03:52:27 -0500 Received: from alexa-out-blr-02.qualcomm.com ([103.229.18.198]:33807 "EHLO alexa-out-blr-02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727778AbgBFIw1 (ORCPT ); Thu, 6 Feb 2020 03:52:27 -0500 Received: from ironmsg02-blr.qualcomm.com ([10.86.208.131]) by alexa-out-blr-02.qualcomm.com with ESMTP/TLS/AES256-SHA; 06 Feb 2020 14:22:24 +0530 Received: from harigovi-linux.qualcomm.com ([10.204.66.157]) by ironmsg02-blr.qualcomm.com with ESMTP; 06 Feb 2020 14:22:02 +0530 Received: by harigovi-linux.qualcomm.com (Postfix, from userid 2332695) id 2DE7628E6; Thu, 6 Feb 2020 14:22:02 +0530 (IST) From: Harigovindan P To: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org Cc: Harigovindan P , linux-kernel@vger.kernel.org, robdclark@gmail.com, seanpaul@chromium.org, hoegsberg@chromium.org, kalyan_t@codeaurora.org, nganji@codeaurora.org Subject: [v1] drm/msm/dsi: save pll state before dsi host is powered off Date: Thu, 6 Feb 2020 14:21:54 +0530 Message-Id: <1580979114-16447-1-git-send-email-harigovi@codeaurora.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Save pll state before dsi host is powered off. Without this change some register values gets resetted. Signed-off-by: Harigovindan P --- Changes in v1: - Saving pll state before dsi host is powered off. - Removed calling of save state in post_disable since everything would be resetted and it would save only resetted values. drivers/gpu/drm/msm/dsi/dsi_manager.c | 5 +++++ drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 4 ---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.c b/drivers/gpu/drm/msm/dsi/dsi_manager.c index 104115d..a987efe 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_manager.c +++ b/drivers/gpu/drm/msm/dsi/dsi_manager.c @@ -506,6 +506,7 @@ static void dsi_mgr_bridge_post_disable(struct drm_bridge *bridge) struct msm_dsi *msm_dsi1 = dsi_mgr_get_dsi(DSI_1); struct mipi_dsi_host *host = msm_dsi->host; struct drm_panel *panel = msm_dsi->panel; + struct msm_dsi_pll *src_pll; bool is_dual_dsi = IS_DUAL_DSI(); int ret; @@ -539,6 +540,10 @@ static void dsi_mgr_bridge_post_disable(struct drm_bridge *bridge) id, ret); } + /* Save PLL status if it is a clock source */ + src_pll = msm_dsi_phy_get_pll(msm_dsi->phy); + msm_dsi_pll_save_state(src_pll); + ret = msm_dsi_host_power_off(host); if (ret) pr_err("%s: host %d power off failed,%d\n", __func__, id, ret); diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c index b0cfa67..f509ebd 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c @@ -724,10 +724,6 @@ void msm_dsi_phy_disable(struct msm_dsi_phy *phy) if (!phy || !phy->cfg->ops.disable) return; - /* Save PLL status if it is a clock source */ - if (phy->usecase != MSM_DSI_PHY_SLAVE) - msm_dsi_pll_save_state(phy->pll); - phy->cfg->ops.disable(phy); dsi_phy_regulator_disable(phy); -- 2.7.4