Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: FTvuon9J4JofATOfz/4Of/idmexQkUI5ifKQgkApqdDZAlhCqbo5A873tmhXktkFTbdm/Leucy
 XEXm2y0e2c34LvfKUDq5ErouQ/OO+afBuwRr7dJJPRgq5L95EYGYML+Fv3Zs66CSEdHIbkhz9M
 f450ujli7N60ZrFctrYNsEZwrkHS56GJvOl24TtPLfF5QwDzOBKP/4Cobqsonj3q3JNT/5QwYa
 pTX5a0dVQTG68rBl+gSCjugOL/g20yNkP5z7Eg//7vpAJTvIdO8ok/OMqnaTGFX9UOxrL3mBhl
 mvc=
From:   Avi Shchislowski <Avi.Shchislowski@wdc.com>
To:     Avri Altman <Avri.Altman@wdc.com>,
        Guenter Roeck <linux@roeck-us.net>
CC:     Alim Akhtar <alim.akhtar@samsung.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: RE: [PATCH 0/5] scsi: ufs: ufs device as a temperature sensor
Thread-Topic: [PATCH 0/5] scsi: ufs: ufs device as a temperature sensor
Thread-Index: AQHV2bYg6ExsysKG0EeYEdSzahFFuKgISGeAgAEWP7CAAC/CAIAAcFWAgAAE64CAAI5eAIADbglQ
Date:   Thu, 6 Feb 2020 10:40:03 +0000
Message-ID: <MN2PR04MB6190D9E63717D37285DADBB09A1D0@MN2PR04MB6190.namprd04.prod.outlook.com>
References: <1580640419-6703-1-git-send-email-avi.shchislowski@wdc.com>
 <20200202192105.GA20107@roeck-us.net>
 <MN2PR04MB61906E820FAF0F17082D53AE9A000@MN2PR04MB6190.namprd04.prod.outlook.com>
 <94cb1e97-18ed-ebec-23c2-b4d87434726a@roeck-us.net>
 <MN2PR04MB69910152F14A7D481029E4ECFC000@MN2PR04MB6991.namprd04.prod.outlook.com>
 <20200203214733.GA30898@roeck-us.net>
 <BY5PR04MB69809A3BEFD629A67FB563CDFC030@BY5PR04MB6980.namprd04.prod.outlook.com>
In-Reply-To: <BY5PR04MB69809A3BEFD629A67FB563CDFC030@BY5PR04MB6980.namprd04.prod.outlook.com>
Accept-Language: en-US, he-IL
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 7db13c2c-1c8e-4b7c-2db2-08d7aaf0ec64
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Feb 2020 10:40:03.0346
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: N+Hx8/SAx9pwiIHX6O7SbE8ln6pnin1nS+ly6f/yHWanqKCWYt3nrdz0Q4nzpwGxE8Wh8xFqFmWwKsV6czO8hfM/1U+G7yupmb6HxvDIJOI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB6893
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

As it become evident that the hwmon is not a viable option to implement ufs=
 thermal notification, I would appreciate some concrete comments of this se=
ries.

Thanks,
Avi

>=20
> > On Mon, Feb 03, 2020 at 09:29:57PM +0000, Avri Altman wrote:
> > > > >> Can you add an explanation why this can't be added to the just-
> > > > introduced
> > > > >> 'drivetemp' driver in the hwmon subsystem, and why it make
> > > > >> sense to
> > > > have
> > > > >> proprietary attributes for temperature and temperature limits ?
> > >
> > >
> > > Guenter hi,
> > > Yeah - I see your point. But here is the thing - UFS devices support
> > > only a subset of scsi commands.
> > > It does not support ATA_16 nor SMART attributes.
> > > Moreover, you can't read UFS attributes using any other
> > > scsi/ATA/SATA Commands, nor it obey the ATA temperature sensing
> conventions.
> > > So unless you want to totally break the newly born drivetemp -
> > > Better to leave ufs devices out of it.
> > >
> >
> > drivetemp is written with extensibility in mind. For example, Martin
> > has a prototype enhancement which supports SCSI drive temperature
> sensors.
> > As long as a device can be identified as ufs device, and as long as
> > there
> The ufs device does not identifies as such, e.g. by INQUIRY or other.
>=20
> > is a means to pass-through commands, adding a new type would be easy.
> I am unaware of any such option.
> Device management commands are privet to the ufs driver.
>=20
> Thanks,
> Avri