Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1549667ybv; Thu, 6 Feb 2020 06:02:24 -0800 (PST) X-Google-Smtp-Source: APXvYqwPZvKJQd6oDoa4g4YDx8q0EZGPJocTvj6BO7FxgMVsoIBPf081xwDv0xg2bXxEOGD9ywl4 X-Received: by 2002:a05:6830:1353:: with SMTP id r19mr31095095otq.288.1580997744502; Thu, 06 Feb 2020 06:02:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580997744; cv=none; d=google.com; s=arc-20160816; b=m6wllwPj8VgZDDfUA0poV/s8OtAOCaNKNDGmJyUjUv/YhDJn0HHdg2xesGbMQv8gDa PAZzLWZaDSD0DZNS0JEm0PWTQwpfpNBuKqhjRDLz3eoe2cv6+svuLohp7raXfVhDIX6b RkoPa++bf+G94lkAR6u+/w67DkFVIe8LnOj8PpdkAY46YjAj3F6Pxk4i1rvz/6m1+2Cf dkibfhBAeaEglSkfo3ZygtsvgBCEzxg17CfqD+JR8AZEEVmFVDO9y/2hGLkwkqhWRqLt 6oTXGJ5jyRiHqlVEMdy8Q56K7jcEMuy+XKLH9j/Nn9eeozFeVJs75TEezF2+m9h7413L VFEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:autocrypt:from:references:cc:to:subject :dkim-signature; bh=f0/+4MrvvxwnQ1e3OxyrOFplpAJRmKm/saMN5zwzLds=; b=JFHXQMaO/wooSXmap9YnxeqReoGvOwcWIGLuxAloY0Taxgvzs4wYGBd/yQlZYa4Cci dkWRTGsELyAXqeMfPj0ryLZtNuFQBG/ET1xfEDwImWgrujLHZ5/ye8ZtqtM9jzWS4fhD yBFoiTH9qRUh/tUy9WwsWmAMFZsJDvUw/qvWPjs4THWynDGdnkuBjikJUhQkpOtubCvy 8r0AJciYEV7ygYK7Ka8M2JUfn30i3+oX5tGStiv1feFMPPf6k3G4o6NwnFB4qsuEilzc BcUVL0Ud1QdgMl5biEwSuWUcZKMJICMPvIbCD2EOTpBAg4kZcfr7bzqQ15d9R5QF1+6p WsIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FszNcqqN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d199si2242509oib.135.2020.02.06.06.02.09; Thu, 06 Feb 2020 06:02:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FszNcqqN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728016AbgBFN75 (ORCPT + 99 others); Thu, 6 Feb 2020 08:59:57 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:33959 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727769AbgBFN75 (ORCPT ); Thu, 6 Feb 2020 08:59:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580997596; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=f0/+4MrvvxwnQ1e3OxyrOFplpAJRmKm/saMN5zwzLds=; b=FszNcqqNKi6M++eEWG4NoiGNSre6noB2uc2K7pXnj1pkqwYaPOnQhSJC4uWffoih2KBqnS qf72l78RsVZtYRUhoRTi4+hYwegd4g4L2whNgolNjfm3dla+Q/fch2S7ukhQCzvN7LazHT MayuZ/AJc8e5jS9ARssvI/vIckKd+hg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-363-avUDCSFnNYCVRk99HRv6Ig-1; Thu, 06 Feb 2020 08:59:54 -0500 X-MC-Unique: avUDCSFnNYCVRk99HRv6Ig-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C3FCF1098163; Thu, 6 Feb 2020 13:59:52 +0000 (UTC) Received: from [10.36.118.128] (unknown [10.36.118.128]) by smtp.corp.redhat.com (Postfix) with ESMTP id 197315C1B0; Thu, 6 Feb 2020 13:59:50 +0000 (UTC) Subject: Re: [PATCH] mm/sparsemem: pfn_to_page is not valid yet on SPARSEMEM To: Wei Yang Cc: Wei Yang , akpm@linux-foundation.org, osalvador@suse.de, dan.j.williams@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, bhe@redhat.com References: <20200206125343.9070-1-richardw.yang@linux.intel.com> <6d9e36cb-ee4a-00c8-447b-9b75a0262c3a@redhat.com> <20200206135742.454wgna4ta76yv5w@master> From: David Hildenbrand Autocrypt: addr=david@redhat.com; prefer-encrypt=mutual; keydata= mQINBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABtCREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT6JAlgEEwEIAEICGwMFCQlmAYAGCwkIBwMCBhUI AgkKCwQWAgMBAh4BAheAFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl3pImkCGQEACgkQTd4Q 9wD/g1o+VA//SFvIHUAvul05u6wKv/pIR6aICPdpF9EIgEU448g+7FfDgQwcEny1pbEzAmiw zAXIQ9H0NZh96lcq+yDLtONnXk/bEYWHHUA014A1wqcYNRY8RvY1+eVHb0uu0KYQoXkzvu+s Dncuguk470XPnscL27hs8PgOP6QjG4jt75K2LfZ0eAqTOUCZTJxA8A7E9+XTYuU0hs7QVrWJ jQdFxQbRMrYz7uP8KmTK9/Cnvqehgl4EzyRaZppshruKMeyheBgvgJd5On1wWq4ZUV5PFM4x II3QbD3EJfWbaJMR55jI9dMFa+vK7MFz3rhWOkEx/QR959lfdRSTXdxs8V3zDvChcmRVGN8U Vo93d1YNtWnA9w6oCW1dnDZ4kgQZZSBIjp6iHcA08apzh7DPi08jL7M9UQByeYGr8KuR4i6e RZI6xhlZerUScVzn35ONwOC91VdYiQgjemiVLq1WDDZ3B7DIzUZ4RQTOaIWdtXBWb8zWakt/ ztGhsx0e39Gvt3391O1PgcA7ilhvqrBPemJrlb9xSPPRbaNAW39P8ws/UJnzSJqnHMVxbRZC Am4add/SM+OCP0w3xYss1jy9T+XdZa0lhUvJfLy7tNcjVG/sxkBXOaSC24MFPuwnoC9WvCVQ ZBxouph3kqc4Dt5X1EeXVLeba+466P1fe1rC8MbcwDkoUo65Ag0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAGJAiUEGAECAA8FAlXLn5ECGwwFCQlmAYAACgkQTd4Q 9wD/g1qA6w/+M+ggFv+JdVsz5+ZIc6MSyGUozASX+bmIuPeIecc9UsFRatc91LuJCKMkD9Uv GOcWSeFpLrSGRQ1Z7EMzFVU//qVs6uzhsNk0RYMyS0B6oloW3FpyQ+zOVylFWQCzoyyf227y GW8HnXunJSC+4PtlL2AY4yZjAVAPLK2l6mhgClVXTQ/S7cBoTQKP+jvVJOoYkpnFxWE9pn4t H5QIFk7Ip8TKr5k3fXVWk4lnUi9MTF/5L/mWqdyIO1s7cjharQCstfWCzWrVeVctpVoDfJWp 4LwTuQ5yEM2KcPeElLg5fR7WB2zH97oI6/Ko2DlovmfQqXh9xWozQt0iGy5tWzh6I0JrlcxJ ileZWLccC4XKD1037Hy2FLAjzfoWgwBLA6ULu0exOOdIa58H4PsXtkFPrUF980EEibUp0zFz GotRVekFAceUaRvAj7dh76cToeZkfsjAvBVb4COXuhgX6N4pofgNkW2AtgYu1nUsPAo+NftU CxrhjHtLn4QEBpkbErnXQyMjHpIatlYGutVMS91XTQXYydCh5crMPs7hYVsvnmGHIaB9ZMfB njnuI31KBiLUks+paRkHQlFcgS2N3gkRBzH7xSZ+t7Re3jvXdXEzKBbQ+dC3lpJB0wPnyMcX FOTT3aZT7IgePkt5iC/BKBk3hqKteTnJFeVIT7EC+a6YUFg= Organization: Red Hat GmbH Message-ID: <185d502e-d5a8-9149-18fc-1ef9b251843e@redhat.com> Date: Thu, 6 Feb 2020 14:59:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <20200206135742.454wgna4ta76yv5w@master> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06.02.20 14:57, Wei Yang wrote: > On Thu, Feb 06, 2020 at 02:28:53PM +0100, David Hildenbrand wrote: >> On 06.02.20 13:53, Wei Yang wrote: >>> When we use SPARSEMEM instead of SPARSEMEM_VMEMMAP, pfn_to_page() >>> doesn't work before sparse_init_one_section() is called. This leads to a >>> crash when hotplug memory. >>> >>> We should use memmap as it did. >>> >>> Fixes: ba72b4c8cf60 ("mm/sparsemem: support sub-section hotplug") >>> Signed-off-by: Wei Yang >>> CC: Dan Williams >>> --- >>> mm/sparse.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/mm/sparse.c b/mm/sparse.c >>> index 5a8599041a2a..2efb24ff8f96 100644 >>> --- a/mm/sparse.c >>> +++ b/mm/sparse.c >>> @@ -882,7 +882,7 @@ int __meminit sparse_add_section(int nid, unsigned long start_pfn, >>> * Poison uninitialized struct pages in order to catch invalid flags >>> * combinations. >>> */ >>> - page_init_poison(pfn_to_page(start_pfn), sizeof(struct page) * nr_pages); >>> + page_init_poison(memmap, sizeof(struct page) * nr_pages); >> >> If you add sub-sections that don't fall onto the start of the section, >> >> pfn_to_page(start_pfn) != memmap >> >> and your patch would break that under SPARSEMEM_VMEMMAP if I am not wrong. >> >> Instead of memmap, there would have to be something like >> >> memmap + (start_pfn - SECTION_ALIGN_DOWN(start_pfn)) >> >> If I am not wrong :) > > Hi, David, Thanks for your comment. > > To be hones, I am not familiar with SPARSEMEM_VMEMMAP. Here is my > understanding about section_activate() when SPARSEMEM_VMEMMAP is set. > > section_activate(nid, start_pfn, nr_pages, altmap) > populate_section_mmemap(start_pfn, nr_pages, nid, altmap) > __populate_section_mmemap(start_pfn, nr_pages, nid, altmap) > return pfn_to_page(start_pfn) > > So the memmap is the page struct for start_pfn when SPARSEMEM_VMEMMAP is set. > > Maybe I missed some critical part? I was assuming that memmap is the memmap of the section, not of the sub-section. (judging from the change in the original patch) If the right memmap pointer to the sub-section is returned, then we are fine. Will double check :) -- Thanks, David / dhildenb