Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1583160ybv; Thu, 6 Feb 2020 06:28:31 -0800 (PST) X-Google-Smtp-Source: APXvYqzOLXVagv4PF8KDg45FBIad0CaM9TUQtwP0YS7lvXRi1CWseOyJJ/xaFAHr4zwm+uYRmhZz X-Received: by 2002:a9d:6647:: with SMTP id q7mr31631669otm.35.1580999311276; Thu, 06 Feb 2020 06:28:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580999311; cv=none; d=google.com; s=arc-20160816; b=kxnC8i06a+tkqnrbRkHQKir38gZiptgmKanB+IyUtMwGOg9bTKyLzRhzWMMG2g8Ljt OOr+qCUTG8DiBG6/H6GQFvNU8NSjs3OrBCOoPGZHzXSYx9sg81uLloxWKCGojKCeePk1 wzbmFzoGg4EArxSfqljXQNpq2jrSxA4K6f1OExqqsRCJ1LUjWLJsp7+ajAgtjAWxUlVE YjHa7txgWGNLJK2yPjOciiLBHkYqrV8kCVUpukjhVst6HF4TqyezHlzqT0ih4fj69Tov R0IaaZBDTyNH6jsqQbyQCvoeqRs9a5WFKsF5xdWp3pzrQUpzw3jfDmS6SGHKyKhZmh1L C+eA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=p19oP9rAShwHnrZ6I0lQPYswxVWimInnaxXF/O9xV8g=; b=IIDwkNavXxu8J87oNe5jthVTgXlhRjxoi8rhYpVygiMbBeqw9vN1AxwMGupnOJ916p eLHawGi/T6R3q4KKHQ7pWt9FvYKhruVNoaO8qW06JcYYakBqAyDgO3Gf1+TxnvJ8J99T CiR/WrO9E0tFWPYBTjj+3ETiO2MrdLqWoD8Ido5q3bfA+m8ExOwZI9Ezy7gO2P6dBE23 2bwK5P3BoMQcUQkXJVSvZMsmN8WkxWCG5wgEGU5fDQAoFGVqrFA/WAkiNeKlQxc6S+0D vOQZct6VT/Xt+Pn7XcCb2F0t5+W6G9FHJD2576BAURoAuTSOK553Bv/1HYsevvleOcCL X40g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=sRLuL+ZY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d19si1827880ote.3.2020.02.06.06.28.18; Thu, 06 Feb 2020 06:28:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=sRLuL+ZY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728060AbgBFO00 (ORCPT + 99 others); Thu, 6 Feb 2020 09:26:26 -0500 Received: from mail-io1-f65.google.com ([209.85.166.65]:41653 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727415AbgBFO00 (ORCPT ); Thu, 6 Feb 2020 09:26:26 -0500 Received: by mail-io1-f65.google.com with SMTP id m25so6489998ioo.8 for ; Thu, 06 Feb 2020 06:26:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=p19oP9rAShwHnrZ6I0lQPYswxVWimInnaxXF/O9xV8g=; b=sRLuL+ZYZ1mHJ9JzmN+K+3bN8/VG6BkcFKf1MtjNw1A82YrRKTxSvEvUcANj/1tUfA Wv15JzdAUTZXWVZaXTLhwSnP/urKWyvFumMrwTqaKLHq/K/EGCt7N36fC7oaUfpReypE mDxiYIhzR9aQrNqNaOQMPp/Zqy4RDY6yrO33G7IFNPj311Q6lEpWujuDlMsRVdtTpYs/ Y8jn/CjiJVpxYmIMUsfkiNNf7kTGpb4QbMASprTY7owa22+ONSjSYglz4PLkW/zR6yju ASVKsRqet3GDWnmPbXEsXoY3CTRV8nnW07NN/e72QNHwP0VPTipRDogRgqK9lrHq3gaI UMog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=p19oP9rAShwHnrZ6I0lQPYswxVWimInnaxXF/O9xV8g=; b=I5LMDq/Opvq5jgmmF7MD7+Fd4LawueHqwSJ7tBfpuRF8ZU432yK/NrFHBTp/LrPREo 6KdFzsFanc4JbO/B9IZofGhfL4oggLGSteiQ03tOzdX2IaypT+eV8YXFdVaHsOXwUxjt EnsKVkLPNacnkA/KKvekwhoKZvNX7T0H83hnhRVpwMJ6pz9MRMweOe8fLL6YYCcGISsS W2QNbuFWGXpmaU5FTDXcQLbvGOQZJmPcd7fjLynKfQ88xnS9Pn86ALWDh5I5BzTvD6OV dA3zrWwXdoPIoWqVioueovdXUzKyZr15x5e7iuoD7knOcDJQucs42kW2PSX3T2ZOs9Ss 5Lyg== X-Gm-Message-State: APjAAAWGzVv2/JxF0Jspx1iJK2q6UBBC8rfM5KTMzgGtTLXWAwPxVGMn QQxewrblWw9Wf3L7ctJ4erV/hzv1uPk= X-Received: by 2002:a5d:970e:: with SMTP id h14mr32952567iol.201.1580999184935; Thu, 06 Feb 2020 06:26:24 -0800 (PST) Received: from [192.168.1.159] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id s21sm894587ioa.33.2020.02.06.06.26.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Feb 2020 06:26:24 -0800 (PST) Subject: Re: [PATCH 0/3] io_uring: clean wq path To: Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: <1fdfd8bf-c0cd-04c0-e22e-bc0945ef1734@gmail.com> <8c0639c6-78ad-6240-0c18-d3ef8936e2f4@kernel.dk> <8ad4a84e-9796-6431-c73e-1d34eed0b0fb@gmail.com> From: Jens Axboe Message-ID: <858563a9-8a99-dfc2-c4df-53ae09ffdfeb@kernel.dk> Date: Thu, 6 Feb 2020 07:26:23 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <8ad4a84e-9796-6431-c73e-1d34eed0b0fb@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/6/20 2:51 AM, Pavel Begunkov wrote: > On 2/6/2020 5:50 AM, Jens Axboe wrote: >> On 2/5/20 3:29 PM, Pavel Begunkov wrote: >>> On 05/02/2020 22:07, Pavel Begunkov wrote: >>>> This is the first series of shaving some overhead for wq-offloading. >>>> The 1st removes extra allocations, and the 3rd req->refs abusing. >>> >>> Rechecked a couple of assumptions, this patchset is messed up. >>> Drop it for now. >> >> OK, will do, haven't had time to look at it yet anyway. > > Sorry for the fuss. I'll return to it later. No worries >> Are you going to do the ->has_user removal? We should just do that >> separately first. > Yes. I've spotted a few bugs, so I'm going to patch them first with > merging/backporting in mind, and then deal with ->has_user. IMO, this > order makes more sense. I think it probably makes sense to do it in the opposite order, as the ->has_user cleanup/clarification should go into 5.6 whereas the other stuff is likely 5.7 material. -- Jens Axboe