Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: zY4WxZFka5XFBS3OqYwMIuqbhwXzbHdLc/lVn4XB5HgYoOHZ7roASaNHxZQWxSSaJIOPSlb82k
 GBJS59iEBeV9UtYm7QoEMF+GfLsWuvHZXHZCW8vBRYPyPXjqMNfiAlLpEsKQYPAko5SSeljk+L
 3gPzjVubRUICdbMbUdEwycifOphbn336v8N6iOaiEcrxA2MCoil7fqnGmq8uLpKoubDJRiLCNa
 xXdidZdTlBu1fl7YZ0G9+MCGLRe2YL35vY28y88vN6iGDKSnHxaRbTS5NQpWGbHTryQXuQ2sRL
 BtQ=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Can Guo <cang@codeaurora.org>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "nguyenb@codeaurora.org" <nguyenb@codeaurora.org>,
        "hongwus@codeaurora.org" <hongwus@codeaurora.org>,
        "rnayak@codeaurora.org" <rnayak@codeaurora.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "kernel-team@android.com" <kernel-team@android.com>,
        "saravanak@google.com" <saravanak@google.com>,
        "salyzyn@google.com" <salyzyn@google.com>
CC:     Alim Akhtar <alim.akhtar@samsung.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Bean Huo <beanhuo@micron.com>,
        Stanley Chu <stanley.chu@mediatek.com>,
        Bart Van Assche <bvanassche@acm.org>,
        Venkat Gopalakrishnan <venkatg@codeaurora.org>,
        Tomas Winkler <tomas.winkler@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Pedro Sousa <sousa@synopsys.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v7 8/8] scsi: ufs: Select INITIAL adapt for HS Gear4
Thread-Topic: [PATCH v7 8/8] scsi: ufs: Select INITIAL adapt for HS Gear4
Thread-Index: AQHV3MhOcPND5Q8f/kqjkSYvDk+3nKgOJc2A
Date:   Thu, 6 Feb 2020 13:20:07 +0000
Message-ID: <MN2PR04MB6991EA027BB31FA58EEBDA81FC1D0@MN2PR04MB6991.namprd04.prod.outlook.com>
References: <1580978008-9327-1-git-send-email-cang@codeaurora.org>
 <1580978008-9327-9-git-send-email-cang@codeaurora.org>
In-Reply-To: <1580978008-9327-9-git-send-email-cang@codeaurora.org>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 1726033a-1546-4a2c-3d0b-08d7ab0748f4
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Feb 2020 13:20:07.2225
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zExoRXxyy3sgLru2xkZf6SE9vvrB4CCdCGD4RL9IRqqdyo61Y5zx62D9LBc4CO/C7qyBE8FLJqo/fcISHCFgwA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB5662
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Can,

=20
> ADAPT is added specifically for HS Gear4 mode only, select INITIAL adapt
> before do power mode change to G4 and select no adapt before switch to
> non-G4 modes.

UFSHCI 3.0 says:
7.4.1 Adapt
The use of Adapt isn't mandatory but the specification provides some guidel=
ines on its use.
The HCI should perform an Initial Adapt in the following cases if the link =
is running at HS-G4
speed:
 - If DME_RESET is initiated.
 - If an unused line is activated for HS-G4.
 - If UECDME.EC is triggered with bit 3 set to '1'.
 - If a change between Rate A and Rate B in HS-G4 is performed.

If it's not mandatory - why are we setting this for all vendors on all plat=
forms?
Or am I miss-reading the spec?

Thanks,
Avri