Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1603881ybv; Thu, 6 Feb 2020 06:49:41 -0800 (PST) X-Google-Smtp-Source: APXvYqz+JOxzCjT4Uofe3ZScYCaqZDRj+lPGo9UPp2QM1vn8Y5+l7cAnshsZiUMtr4a7r2GGeROc X-Received: by 2002:a54:488d:: with SMTP id r13mr6843966oic.115.1581000580948; Thu, 06 Feb 2020 06:49:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581000580; cv=none; d=google.com; s=arc-20160816; b=ZG//dTzOjU/DvW6ibRJ07AeMbvsHk4CA2eKcV6COlwHcFhOO5ZwwtepyDZhiJc+Frx /slNnHRGD6DuZdWUw9Y1hhnlKNP2L4C75ZHlN/K44D8/EEXcXEN5F2qUa9d+Cg4ToajG sDrsvbfTWilqMtUd+UVl+AUuFxMPGvX8o3NTh3EDzuFBXZDyeKYPII3qAitttZADlEMA IMf9gu9twg6v8eXONbOKcAydrtS1tI5b0+bC+i7yNsH7Zwa1ps1PVU7gx/2X3zCbkyeE WYFRxJhQO4eFJhQ1fB6fbkd1UEjzNkjU8ZFXS31I5ti0Aya8fkxMz8CiUGo/q9xFxDvE YXmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=8+XUabkF0ZHmi2bxsikRrvUqicuDPtiFMCes1grPN6M=; b=DFZ9rSFD+lJpMmfIO8UT4xkAOXLcNaLOlETR3Moh0TlWxWBTm9llIp9sNYVQmh4qEt rcj8qSw9UjmJ3edvW9cuA0A8WhawmVErFZ/TcnJQnw7kLBhrkYNEUI6OgzQ7Sz43C+P/ RjPjqsZUgQbI8tDD5A/Tdav0oopeAyd2bQ2PGw2nk2GvYiwREYZEFP4bHMShA+qfhXqP 7eGS85d+ifoQFZTkuCnv+zKVejjoje5ED3O2nqh5eOxSCJ1zS//4ZwaCWSFe3F77I8Yb ptcOrcQhOpUtWWUkm7fI4AKxO9hu6LAtXRtT/cGBolC2YaE9JMOkBNGn/5BXqeIdGkqg kB6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=kJBPHTJY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a8si1953193otp.258.2020.02.06.06.49.28; Thu, 06 Feb 2020 06:49:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=kJBPHTJY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727815AbgBFNgB (ORCPT + 99 others); Thu, 6 Feb 2020 08:36:01 -0500 Received: from mail.kernel.org ([198.145.29.99]:41602 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727060AbgBFNgB (ORCPT ); Thu, 6 Feb 2020 08:36:01 -0500 Received: from localhost (unknown [122.178.198.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 330B22082E; Thu, 6 Feb 2020 13:35:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580996161; bh=KQ1zNlhQGY64IHdB8I6m2LzafLRqPGfU8AX+YoBdzQg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kJBPHTJYzmbvrcRG634TwPmCRb2rG0lb2roFVEyErmRYAkCTzhIau1RYoal97rzba n/QItxXcTNTsnRDzk1f8fEi7JAAGN3moK1meFBhESojb+HexZiMJ2XjAiPd42H8pLi RmZzEcv7pEmtwCNcV4PfEZObyh/EXotjJCHKKoCk= Date: Thu, 6 Feb 2020 19:05:54 +0530 From: Vinod Koul To: Dejin Zheng Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com, joabreu@synopsys.com, davem@davemloft.net, mcoquelin.stm32@gmail.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: stmmac: fix a possible endless loop Message-ID: <20200206133554.GO2618@vkoul-mobl> References: <20200206132147.22874-1-zhengdejin5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200206132147.22874-1-zhengdejin5@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06-02-20, 21:21, Dejin Zheng wrote: > It forgot to reduce the value of the variable retry in a while loop > in the ethqos_configure() function. It may cause an endless loop and > without timeout. Thanks for the fix. Acked-by: Vinod Koul We should add: Fixes: a7c30e62d4b8 ("net: stmmac: Add driver for Qualcomm ethqos") Also, I think this should be CCed stable -- ~Vinod