Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1605784ybv; Thu, 6 Feb 2020 06:51:37 -0800 (PST) X-Google-Smtp-Source: APXvYqws7X1qeAXVNkkd5aPhG4AXvOxILkHt2Vb5A1vJ9IumXhGtlqdbKqIRbtpsG5dFWuvp/v63 X-Received: by 2002:aca:388:: with SMTP id 130mr6809812oid.89.1581000697470; Thu, 06 Feb 2020 06:51:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581000697; cv=none; d=google.com; s=arc-20160816; b=BAIXUlOIsshivcvl/dyDRsAtKO/w0LcTspyaSIJVCepUL/kGT6PultW4Z2Cy8mWNei DBnd+0Bx/YH1OklIgBm6J7mE6vSM8Q5X3TyQJ4D/4aExUqHA3ZfdJFH5RUp9juSvV4RE S1uFFNOdIOp2KpaIZTrhFvlW3ebMGDwqMKh7aFrI3Ct8T6JxtUshe/qiPX7agFZdgjN/ PR6492mKEpkLA2JF/4fWZeF4wucj5VfprsHMljIWjrQUrGiidzUX32ttdEe+ZTT+69yN ocx4I1E3ZN+0+1qOz+5Qsx9TWvGgpg+CxMOlE0rxyiK0pWttXKHfD2lZXRhbbCMEJiBO 5Qtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=wzmTtKEOXxbPV5WWqvMsynodImZrUwQo2fJtIEVyEeY=; b=iYgf+ZwUH9Kjs0bPu7FapG9F1dRCZ8McLqIYFSc3oPG/MT8AxgheuUHzC42GE0Lzp6 oWAA/N3Q9232e/6IsMPDVAUZzVvOz3CbGnrYkhlg/ie+YxZZDPSJXhbNHCMidPEokW+o UsK3P823iec8IGeN+z3y9HYsaqxzebc1oEPWtwkMGkEc/NpLelRI3gMLQr1XPZx81s6H y9YoH6sDBCCuaIX22uHcnYSpduQOTVprAD+IpEJ7DZMZNtA0DY4yX+1dIDlDyFU1n3gu 7Q37OwCSwo7dbSwj8HflVjsdREWCl2SMQwhqj97FWTTYbAHZXeUttzT2f2T7VMUK08eq gV5g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s9si2051244oij.78.2020.02.06.06.51.25; Thu, 06 Feb 2020 06:51:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727482AbgBFOuc (ORCPT + 99 others); Thu, 6 Feb 2020 09:50:32 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:60318 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726956AbgBFOub (ORCPT ); Thu, 6 Feb 2020 09:50:31 -0500 Received: from localhost (unknown [IPv6:2001:982:756:1:57a7:3bfd:5e85:defb]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 82EB414E226FC; Thu, 6 Feb 2020 06:50:29 -0800 (PST) Date: Thu, 06 Feb 2020 15:50:25 +0100 (CET) Message-Id: <20200206.155025.1955610977652855941.davem@davemloft.net> To: zhengdejin5@gmail.com Cc: vkoul@kernel.org, peppe.cavallaro@st.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, niklas.cassel@linaro.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net: stmmac: fix a possible endless loop From: David Miller In-Reply-To: <20200206141811.24862-1-zhengdejin5@gmail.com> References: <20200206141811.24862-1-zhengdejin5@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 06 Feb 2020 06:50:31 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dejin Zheng Date: Thu, 6 Feb 2020 22:18:11 +0800 > It forgot to reduce the value of the variable retry in a while loop > in the ethqos_configure() function. It may cause an endless loop and > without timeout. > > Fixes: a7c30e62d4b8 ("net: stmmac: Add driver for Qualcomm ethqos") > > Signed-off-by: Dejin Zheng > Acked-by: Vinod Koul > --- > > Vinod Koul and David Miller, Thanks for your comments! > > V2: > add an appropriate Fixes tag. Please do not put an empty line between Fixes and other tags. I have no idea why people often do this. Anyways, Fixes and other tags are all tags and thus belong together as an uninterrupted group of text. Thank you.