Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1734636ybv; Thu, 6 Feb 2020 08:55:15 -0800 (PST) X-Google-Smtp-Source: APXvYqz1OMsabBAV5VoKdjUcumqIW2jWIx+1vBEbPQJktdgByKX4mBKtlmQG7MJSWKYvqi03rLW+ X-Received: by 2002:a9d:4c8e:: with SMTP id m14mr29501774otf.245.1581008115826; Thu, 06 Feb 2020 08:55:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581008115; cv=none; d=google.com; s=arc-20160816; b=s9kc4MGhQtCqL9K+zqokwOsZDBcPdm8c1fUF568avlAk1ax5j9CZ1bmHgYk+DHo8GW 95REf2+n08U1VWiPOavzSMcd9ReUHpWBe+f4Jk8pZLIMi3rZOKSFWZ6ZoB0mGaYBoXbg OmfdslAYQ1VNjyK4E1QkRHamY90pbhFa527By/KCOkaMhFE4nTUQ7ZZvwk+qYX8pAw/e V7ZJlYPwgZuowP27tB54KQr8WYm73RFF4cl9z8FF8W31NhbmDiSm0ZzQwBF/8ophxHHn 9GOjNDTsTx6q2D7OtdRojgZUhTsKsd82eIpN6xH7VMyCosw9vcdbov6RJ5ienDRzBhoJ +1dA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=aYjPID+86AwFTbXgWpB4ZDC6SCfeqfl8MOuO71FjWTc=; b=b0Lq2iGvacaK/yVGk3ITHoOtSS/Ozqkrkcdxr3POSeafjbGRSD0q42gkfnin71PyoC 9MACpGrL12Qq2Vj6UjHHlT2zLlpC3yp64qFFvpLl68LuzyJp6cpqJ0bAWO6jaMeI7Gaf OsQmP5f1rMVkXIqVZTs7bAkFiuhR2z9w1XQ7gNCY9ukmxXcQ8ae70ObVDb58+w4C6xI0 SHDJIGt87+i/fuwWX968CR8HeEFgfaMV6cuI3woibCh+je/8/AMuZM8gWmdp2ruUf+5W Rw6S9+h2WnF9Zi25VO1wkf6Fy84Vnx/XY9xIw/d3Pz9CgC1whdKSczpCmXFk7V36x3eY SsZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Oe19er23; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 5si2556550oiy.102.2020.02.06.08.55.03; Thu, 06 Feb 2020 08:55:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Oe19er23; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727685AbgBFQyC (ORCPT + 99 others); Thu, 6 Feb 2020 11:54:02 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:38945 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727060AbgBFQyC (ORCPT ); Thu, 6 Feb 2020 11:54:02 -0500 Received: by mail-lj1-f193.google.com with SMTP id o15so6848225ljg.6; Thu, 06 Feb 2020 08:54:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=aYjPID+86AwFTbXgWpB4ZDC6SCfeqfl8MOuO71FjWTc=; b=Oe19er23o00T0c4K/YdRf6LayjLgkdOVvy2wtLnqQzWAXAfyTipZh+ox7V2UmKx6uP v0O+9GwYp6MaPZ4fG8bbVJKzfq5tQaAotTOLA7S7x3zLRwQW7IfOJEunjOuYlghcSFzZ vE46F9MJMajetQcMCYySEqElf+1oto5+pquM9b9ZJSIdta4OgPfE5ru6PdJ6v1dOVNTO xvUsVYpHfBIL9iVPUfDOAXEawcjRnYqfts+UBmW68uj08B+vQido5r868WqCADKNy8aA yE3E/VyYyltjpCdgHdppLbXEIGK6aHLIdAmUOdydd+Cz/AwnesEX5xISEFKM9j3TT/Ks h6XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aYjPID+86AwFTbXgWpB4ZDC6SCfeqfl8MOuO71FjWTc=; b=GtrsMDuCkhNkQLJuc/OIN3cUyLFJrcJuYanBkmPTY6YOwZSSBm6puppf4W648A859q 8KEjHg/YpzBrzjel3rA66/j1FbxzdqNO+l1O2DOzp9kTYY2DH9S+Drfez3+YpAU3UO32 r/s4GI1OthTvbJRdI3C+hCdhd+msZqMBZZ6TG3JkEwBDM1VleQPBgPH2zyqAcrfldgGD GlTrFD8D4325ASbxnPQljkxJlsCUFNRklIY0UZtPeV2pCc3qkKkQaieZICTz9ofMmcIQ gnJUxUhXqnhEy2KA+2sm1C2GbOUkcq8tjpP+ychnFZK18U80CrlsbmTi8QIYxV03TpNZ ikSQ== X-Gm-Message-State: APjAAAXYDN4FgoLxoQKwVF8zEfprFJvP1ys024Sq7KRwvDSHNzs63LNJ 5G7bksUMbNMftF5Joyod+ZI= X-Received: by 2002:a2e:8699:: with SMTP id l25mr2509962lji.137.1581008039144; Thu, 06 Feb 2020 08:53:59 -0800 (PST) Received: from [192.168.2.145] (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.googlemail.com with ESMTPSA id y7sm1649358ljy.92.2020.02.06.08.53.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Feb 2020 08:53:58 -0800 (PST) Subject: Re: [PATCH v2 3/9] ASoC: tegra: add Tegra210 based DMIC driver To: Sameer Pujar Cc: perex@perex.cz, tiwai@suse.com, robh+dt@kernel.org, broonie@kernel.org, lgirdwood@gmail.com, thierry.reding@gmail.com, jonathanh@nvidia.com, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, sharadg@nvidia.com, mkumard@nvidia.com, viswanathl@nvidia.com, rlokhande@nvidia.com, dramesh@nvidia.com, atalambedu@nvidia.com References: <1580380422-3431-1-git-send-email-spujar@nvidia.com> <1580380422-3431-4-git-send-email-spujar@nvidia.com> From: Dmitry Osipenko Message-ID: <9ada4090-169e-0767-db5d-739f6e621812@gmail.com> Date: Thu, 6 Feb 2020 19:53:57 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <1580380422-3431-4-git-send-email-spujar@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 30.01.2020 13:33, Sameer Pujar пишет: ... > +static const struct reg_default tegra210_dmic_reg_defaults[] = { > + { TEGRA210_DMIC_TX_INT_MASK, 0x00000001}, > + { TEGRA210_DMIC_TX_CIF_CTRL, 0x00007700}, > + { TEGRA210_DMIC_CG, 0x1}, > + { TEGRA210_DMIC_CTRL, 0x00000301}, > + /* Below enables all filters - DCR, LP and SC */ > + { TEGRA210_DMIC_DBG_CTRL, 0xe }, > + /* Below as per latest POR value */ > + { TEGRA210_DMIC_DCR_BIQUAD_0_COEF_4, 0x0}, > + /* LP filter is configured for pass through and used to apply gain */ > + { TEGRA210_DMIC_LP_BIQUAD_0_COEF_0, 0x00800000}, > + { TEGRA210_DMIC_LP_BIQUAD_0_COEF_1, 0x0}, > + { TEGRA210_DMIC_LP_BIQUAD_0_COEF_2, 0x0}, > + { TEGRA210_DMIC_LP_BIQUAD_0_COEF_3, 0x0}, > + { TEGRA210_DMIC_LP_BIQUAD_0_COEF_4, 0x0}, > + { TEGRA210_DMIC_LP_BIQUAD_1_COEF_0, 0x00800000}, > + { TEGRA210_DMIC_LP_BIQUAD_1_COEF_1, 0x0}, > + { TEGRA210_DMIC_LP_BIQUAD_1_COEF_2, 0x0}, > + { TEGRA210_DMIC_LP_BIQUAD_1_COEF_3, 0x0}, > + { TEGRA210_DMIC_LP_BIQUAD_1_COEF_4, 0x0}, > +}; I'd add a space on the right side of `}`, for consistency with the left.