Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp2067797ybv; Thu, 6 Feb 2020 15:19:15 -0800 (PST) X-Google-Smtp-Source: APXvYqwltMtn/+uqobRih1NUvptjJENO2NsvH32ZMO+hC3z5Om8vtps6nsgY2pjA/kszSxunVSGh X-Received: by 2002:a9d:6ac2:: with SMTP id m2mr428197otq.191.1581031155416; Thu, 06 Feb 2020 15:19:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581031155; cv=none; d=google.com; s=arc-20160816; b=GouA72L5CuxE9ktx7PDFHfy6S1XUQpZM4ylTHwu7P1B5fdyfNQTxodU0n+evFF95M8 ICzC8kZbDlqURdYTP4LyxAMns3VXFDeAt5gsMFD38PiQPouUWe/nSKVw4Mj0QR/weXdC ZrpA6Ub7TtMjuSOSPhTCBMbw2qq/f8bb8qPD2hfvehWDfRe7pAzBlHc+sv/OwnJH0TWm mrfcuzGtHbHEEjlfmHZSiG/DGROwUlO39H5P0TvFYQZJdcCqkGshGTh3CIn2BQqHmIwm j4XjcmHBWXf0FOzbwk9GpmQFAkcLyLvZSmbjJr+EbpFSkjwMqSs09mWUebPMeoB9RJwm TTXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=QFK4soxgX+UjQ+BWtPp2YXpgCwVucaszYFD+VMRQutg=; b=NeaMXKkxrI7KRFYUzMDHp1MBLctQS3bPr0Ykn/4F8WUtda0m+2vi4BQKWPxDPHWovA 1zF8ZaBLaYn76qzACdFh888DOlWXRXafwlqfjDVD2xCLThnJuR4+5OxbEq7LC+GBjfwl /Yq+qyxvUkLkSMuynQS4aUNvaOdjgM9ce58FaBpjRw3KQWBEivsBI6Xfo7h3XjIYXxg4 eAaX9vbUOj1URGUEpkQpEIj46c58G4uX5DofFCzyIvh/2g4xE128hR3FMUfPkHG8TCou SyoGnaBQXYhi1bMLiIvEY+i0miTk8GD/CXV1ikf6H3MPPlGOaQyHRRMJyBqLT26MALwf YPag== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x16si625695otk.13.2020.02.06.15.18.57; Thu, 06 Feb 2020 15:19:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727162AbgBFXRj (ORCPT + 99 others); Thu, 6 Feb 2020 18:17:39 -0500 Received: from mga03.intel.com ([134.134.136.65]:6959 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726509AbgBFXRi (ORCPT ); Thu, 6 Feb 2020 18:17:38 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Feb 2020 15:17:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,411,1574150400"; d="scan'208";a="232200544" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by orsmga003.jf.intel.com with ESMTP; 06 Feb 2020 15:17:35 -0800 From: Wei Yang To: akpm@linux-foundation.org, osalvador@suse.de, dan.j.williams@intel.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, bhe@redhat.com, david@redhat.com, Wei Yang Subject: [PATCH 2/3] mm/sparsemem: get physical address to page struct instead of virtual address to pfn Date: Fri, 7 Feb 2020 07:16:28 +0800 Message-Id: <20200206231629.14151-3-richardw.yang@linux.intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200206231629.14151-1-richardw.yang@linux.intel.com> References: <20200206231629.14151-1-richardw.yang@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org memmap should be the physical address to page struct instead of virtual address to pfn. Since we call this only for SPARSEMEM_VMEMMAP, pfn_to_page() is valid at this point. Fixes: ba72b4c8cf60 ("mm/sparsemem: support sub-section hotplug") Signed-off-by: Wei Yang CC: Dan Williams --- mm/sparse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/sparse.c b/mm/sparse.c index b5da121bdd6e..56816f653588 100644 --- a/mm/sparse.c +++ b/mm/sparse.c @@ -888,7 +888,7 @@ int __meminit sparse_add_section(int nid, unsigned long start_pfn, /* Align memmap to section boundary in the subsection case */ if (IS_ENABLED(CONFIG_SPARSEMEM_VMEMMAP) && section_nr_to_pfn(section_nr) != start_pfn) - memmap = pfn_to_kaddr(section_nr_to_pfn(section_nr)); + memmap = pfn_to_page(section_nr_to_pfn(section_nr)); sparse_init_one_section(ms, section_nr, memmap, ms->usage, 0); return 0; -- 2.17.1