Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp2097485ybv; Thu, 6 Feb 2020 15:58:18 -0800 (PST) X-Google-Smtp-Source: APXvYqxNmuukpweQFTwihMX6V3PR6Tl+fgVaV1KAuEv0sE1I/7SQscOIbNertPzgAQiTdq/NgCJi X-Received: by 2002:a9d:4e99:: with SMTP id v25mr531490otk.363.1581033498419; Thu, 06 Feb 2020 15:58:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581033498; cv=none; d=google.com; s=arc-20160816; b=nCgYI9ymewBpyTe8qJ4Wmr7EOm61MFbRu9ETmOhInN1mzR7oFQwWeCj9JZIXkbKftq IjGshkOqXY87Vwvq5MSmdthEYkZLPUT27fWgE0wyoV2n8DFIDufvynY7Tr6DobO+hU9u hJOGeGMDuOoFbo0CbPPc2nElCYhJlnbjflIZm4mYNIhE3v/WJvOsVi3CF96Ro44Y1r/W vXMEF17AC/R/AVY6pND/PNDN9rrd1T3l4yc5n0BBaXpK7s8QLidrmMCGx00tO1xNicdP tQjL3iqJtHA0SMWKSEeOHDgNDDmSrMxcY4pgGeOwZA4RIuNeh5llLn+x/pi8nKjssiCg SuWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:in-reply-to:cc:references:message-id :date:subject:mime-version:from:content-transfer-encoding :dkim-signature; bh=wfPvgghFf2DMJhy7eadDruUT5v7p4a/ZvJyom2rl9Po=; b=MzN5DGbVRVHKWADuOeZxC7T0oix4eYMQnTre1B5jljHc2m8H9RVuit9k1CmQcHXJ7t VTOCYqGtWIK1bNdpQuMgxI54apDpwmNe9fkV1DKZsTFCuldaJdqfQVu6SmG7i8pkIyao MikTyKi1Dma1UDigsTflkZDFpQfaVBH8dIWB5o/chpb1iWqB4owJu0tN89A3sAmXW+az 4mqtcyAXOy871/AoA4CtI93rZNfSFwqFJsCkjm3ubUVTJ2NiJXxCkhs78mWb1YOL5B6Z 7Rhk0NEnrw07jAIul5g8cdNQFsiJJuIuV9IfNu72s0NIX1kllZWYjCnmWVfOmktDVuSY ha+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lca.pw header.s=google header.b=a57dANPf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m26si687499otn.307.2020.02.06.15.57.48; Thu, 06 Feb 2020 15:58:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@lca.pw header.s=google header.b=a57dANPf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726674AbgBFX4B (ORCPT + 99 others); Thu, 6 Feb 2020 18:56:01 -0500 Received: from mail-qv1-f65.google.com ([209.85.219.65]:40239 "EHLO mail-qv1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726502AbgBFX4B (ORCPT ); Thu, 6 Feb 2020 18:56:01 -0500 Received: by mail-qv1-f65.google.com with SMTP id dp13so161358qvb.7 for ; Thu, 06 Feb 2020 15:55:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=wfPvgghFf2DMJhy7eadDruUT5v7p4a/ZvJyom2rl9Po=; b=a57dANPf8EWe3YJhbkTClCTBrBFUaDTCV0iV+QivehVRNEcg9CL/EUY32PYUQnanJZ qAzSgKf3ZALLRbngIhfGb5khLDd4cZLBKBYOIsLHWu9wpRn0F02jcdIso2EQEtxYwFXD FXr8EHoW2dOr9Rvm97hVP8bmnP57sf/vycWbKg4phZaJtH9czqcZosnW6nsyGtCqFjsr xghw1RHZozmBj0TmviYOv+IbIcyllNfCu45HlGDdY6LrrzE7MRsWN4ApDgdOwMsilcoS qb64I8/Jh2crWOx+Ob5amurO0GDUyzrVxeIdm3PztalA+wU1/jBYFpbeiUw//k4CZlpp BjYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=wfPvgghFf2DMJhy7eadDruUT5v7p4a/ZvJyom2rl9Po=; b=Fih3S4J7XPn6J5iAs9mMhqkg9YcnhiayFq4PO6jHsdvf6e9+0bDfPY19wldnxP9+Wz jSp8B5lH6D2yBwHww/LyTNoBtgqls9C0BNxFxC8oeR3WNQjCvXrMVKM1px8emuJ+h7+0 hrGLkb/u80QzjXchk4beSvu8Vg8LTg5+9BZRRfHfzztNBU9KoexFgcwzfub96WU/XxLb ZkSqEolGD6U5zdDNh20tsbWWYpAbylySWyQfVcjvl69pqVygDlHu28j/PF2CFlciZSTf GjWkkIPG5nhQHrWyHvLvP6aU2dW40a1U62thDQMIF5rIalbB6RZI44ErsXP5N2slIN2p 1oUg== X-Gm-Message-State: APjAAAXox0P6fCHv10nXCIOpGFFwrN9v3mnD5qt+XdPCvaWBUOccA8n9 VNksGtX2HrfX+upeEk11ejxCBA== X-Received: by 2002:ad4:4f47:: with SMTP id eu7mr4615264qvb.69.1581033358641; Thu, 06 Feb 2020 15:55:58 -0800 (PST) Received: from [192.168.1.183] (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id g77sm429615qke.129.2020.02.06.15.55.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Feb 2020 15:55:58 -0800 (PST) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Qian Cai Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] mm: fix a data race in put_page() Date: Thu, 6 Feb 2020 18:55:57 -0500 Message-Id: References: <079c4429-8a11-154d-cf5c-473d2698d18d@nvidia.com> Cc: Jan Kara , David Hildenbrand , akpm@linux-foundation.org, ira.weiny@intel.com, dan.j.williams@intel.com, elver@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org In-Reply-To: <079c4429-8a11-154d-cf5c-473d2698d18d@nvidia.com> To: John Hubbard X-Mailer: iPhone Mail (17D50) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Feb 6, 2020, at 6:34 PM, John Hubbard wrote: >=20 > * data_race(): there is no race on the N bits worth of page zone number da= ta. There > is only a perceived race, due to tools that look at word-level granularit= y. I=E2=80=99d like to think this from the compiler level. There is a data race= from the compiler load and store point of view. It is just in the case it i= s harmless to affect the actual code logic.=