Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp48025ybv; Thu, 6 Feb 2020 17:45:42 -0800 (PST) X-Google-Smtp-Source: APXvYqzEmDa6TiNjWr35wrAFjkgHOKsNZ3oWBHMEj94r9LZ+d0pNrSRQPjYDZjVOh/U5PUpKZip0 X-Received: by 2002:aca:f354:: with SMTP id r81mr512900oih.90.1581039942219; Thu, 06 Feb 2020 17:45:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581039942; cv=none; d=google.com; s=arc-20160816; b=s3jpvqx5LHcwZ1qddSE6XCo3LBCAboHmDRZtVc0jFUL3222TRpQ0QckI4qgGVH0ZR/ 0vDwqL1v+m5T9fpP3M5LWsSsxFZ21qBpXqyf2+d6a8Pd61MvnZ38JcJxfvBEs0gz9mww czBAVSiD/dkQcwLJwW7NFs3BnLp80SrkLIzpL0BK5YpTNcMJzGSSdJv1w8X0Gs9Ffu+O k1MNUrEZ/svktXupz+c+yXEkNHXNDOH4sTrRU6hrSJNmuxwbXGW97fYEB40I+jDge6Ay u2Oe4edp0cKv7MNkJrOPsxN2FwSkwTXGqYKvUGUSDTniFZtGdKvcUuTeYLYdlku3yDKQ Whzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=7E4U88D5jmJCv0TXQKWMR47MO6HdZqjWgdHeWw9HJqw=; b=F79/a1BalqqqrCPfx2e6MTcFOYhkzbuLx9jRs61rjcGwLE1fHiiovVt83Fa/SoLnF/ NfS75QhdpRb/zfXtUo3rv04fS0tTrbBbPLtaMyWp9g082OPL5RH7wapOL3ZlzAkNrsH8 Gc265BcWCKQMJ+viCNxU+hqraNColgxKMYLiizbIiV6CSnZ+ddB/orG6NL2fkV+tXlfh mPjlmQX+V833OCa0qsWFzsBa1qzxHH2f984znVwy2QJibqCvJuFFZt75qsjA1wdEtaQC 0GaDHB23qQRSi1zbQ/+bXVp1AHvAjMH2+U6pW7gU7IKbY3ghxpsrazF/GbBSf45X3EtW /RNg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r6si796140otp.220.2020.02.06.17.45.15; Thu, 06 Feb 2020 17:45:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727303AbgBGBkQ (ORCPT + 99 others); Thu, 6 Feb 2020 20:40:16 -0500 Received: from mail.kernel.org ([198.145.29.99]:48250 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727028AbgBGBkP (ORCPT ); Thu, 6 Feb 2020 20:40:15 -0500 Received: from oasis.local.home (unknown [12.174.139.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8DAD220838; Fri, 7 Feb 2020 01:40:14 +0000 (UTC) Date: Thu, 6 Feb 2020 20:40:12 -0500 From: Steven Rostedt To: John Ogness Cc: Sergey Senozhatsky , Sergey Senozhatsky , lijiang , Petr Mladek , Peter Zijlstra , Linus Torvalds , Greg Kroah-Hartman , Andrea Parri , Thomas Gleixner , kexec@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] printk: replace ringbuffer Message-ID: <20200206204012.0cbfc941@oasis.local.home> In-Reply-To: <87wo919grz.fsf@linutronix.de> References: <20200128161948.8524-1-john.ogness@linutronix.de> <20200205044848.GH41358@google.com> <20200205050204.GI41358@google.com> <88827ae2-7af5-347b-29fb-cffb94350f8f@redhat.com> <20200205063640.GJ41358@google.com> <877e11h0ir.fsf@linutronix.de> <20200205110522.GA456@jagdpanzerIV.localdomain> <87wo919grz.fsf@linutronix.de> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 05 Feb 2020 16:48:32 +0100 John Ogness wrote: > The quick fixup: > > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c > index d0d24ee1d1f4..5ad67ff60cd9 100644 > --- a/kernel/printk/printk.c > +++ b/kernel/printk/printk.c > @@ -883,6 +883,7 @@ static int devkmsg_open(struct inode *inode, struct file *file) > user->record.text_buf_size = sizeof(user->text_buf); > user->record.dict_buf = &user->dict_buf[0]; > user->record.dict_buf_size = sizeof(user->dict_buf); > + user->record.text_line_count = NULL; > > logbuf_lock_irq(); > user->seq = prb_first_seq(prb); FYI, I used your patch set to test out Konstantin's new get-lore-mbox script, and then applied them. It locked up on boot up as well, and applying this appears to fix it. -- Steve