Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Peng Fan <peng.fan@nxp.com>
To:     Sudeep Holla <sudeep.holla@arm.com>
CC:     "viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
        "f.fainelli@gmail.com" <f.fainelli@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/2] firmware: arm_scmi: mailbox: share shmem for
 protocols
Thread-Topic: [PATCH 1/2] firmware: arm_scmi: mailbox: share shmem for
 protocols
Thread-Index: AQHV3O24QXHBlTcD4kSCPnFpCByfEqgON8AAgADC2KA=
Date:   Fri, 7 Feb 2020 02:08:06 +0000
Message-ID: <AM0PR04MB4481A6C089DD233D4099566D881C0@AM0PR04MB4481.eurprd04.prod.outlook.com>
References: <1580993846-17712-1-git-send-email-peng.fan@nxp.com>
 <20200206142204.GB3383@bogus>
In-Reply-To: <20200206142204.GB3383@bogus>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 1079dd0e-55c2-4332-fefd-08d7ab729296
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2020 02:08:06.9625
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DDoLfJfjC/NY72pto8uRtVEc9I7yT7Gl8gb3pW0IKQpXlwREvh1k26xLxSqIfI0PdNfqsphuiIX3dxt7693jaA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6962
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: Re: [PATCH 1/2] firmware: arm_scmi: mailbox: share shmem for
> protocols
>=20
> On Thu, Feb 06, 2020 at 08:57:25PM +0800, peng.fan@nxp.com wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > When shmem property of protocol is not specificed, let it use its
> > parent's shmem property.
> >
>=20

+arm list

> Why do you even need this ? If shmem property of protocol is not specifie=
d
> then why is the mailbox property ? Either you need both or none. I don't =
see
> the point of this patch. I am interested to know how are you even hitting=
 this
> case.

Without this patch, I need add shmem property in each protocol node.
With this patch, I only need to add shmem property in scmi node.

In mailbox_chan_setup, cdev is protocol device, input parameter device
is the parent, saying scmi device.

>=20
> If you don't have mailbox property, then chan_available is false and henc=
e we
> don't call chan_setup.

chan_avilable only parse mbox properties, not shmem.

Regards,
Peng.

>=20
> --
> Regards,
> Sudeep