Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Horia Geanta <horia.geanta@nxp.com>
To:     =?iso-8859-2?Q?Andr=E9_Draszik?= <git@andred.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     Anson Huang <anson.huang@nxp.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Aymen Sghaier <aymen.sghaier@nxp.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
        Robin Gong <yibin.gong@nxp.com>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH 1/3] ARM: dts: imx7s: add snvs clock to pwrkey
Thread-Topic: [PATCH 1/3] ARM: dts: imx7s: add snvs clock to pwrkey
Thread-Index: AQHV164xC7dgwu9e4kaRkYTJlTesdg==
Date:   Fri, 7 Feb 2020 07:36:59 +0000
Message-ID: <VI1PR0402MB3485BFC1B2BD9842ACE2E834981C0@VI1PR0402MB3485.eurprd04.prod.outlook.com>
References: <20200130204516.4760-1-git@andred.net>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 4612cabb-3d35-467a-cb43-08d7aba083e9
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2020 07:36:59.1489
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DOuPcsjVHOIs+tb67ieQ7Muz5PeCd6d0AGipbbS02y0+BA4b5FN24TIsyclmWaVarvQ9trl8PtF6rnjgzh+gCA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3504
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/30/2020 10:45 PM, Andr=E9 Draszik wrote:=0A=
> On i.MX7, the SNVS requires a clock. This is similar to the clock=0A=
> bound to the SNVS RTC node, but if the SNVS RTC driver isn't enabled,=0A=
> then SNVS doesn't work, and as such the pwrkey driver doesn't=0A=
> work (i.e. hangs the kernel, as the clock isn't enabled).=0A=
> =0A=
This is true also for i.MX8M.=0A=
For this reason it would probably better splitting the=0A=
DT bindings update in a separate patch.=0A=
=0A=
> Also see commit ec2a844ef7c1=0A=
> ("ARM: dts: imx7s: add snvs rtc clock")=0A=
> for a similar fix.=0A=
> =0A=
> Signed-off-by: Andr=E9 Draszik <git@andred.net>=0A=
> Cc: Anson Huang <Anson.Huang@nxp.com>=0A=
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>=0A=
> Cc: "Horia Geant=E3" <horia.geanta@nxp.com>=0A=
> Cc: Aymen Sghaier <aymen.sghaier@nxp.com>=0A=
> Cc: Herbert Xu <herbert@gondor.apana.org.au>=0A=
> Cc: "David S. Miller" <davem@davemloft.net>=0A=
> Cc: Rob Herring <robh+dt@kernel.org>=0A=
> Cc: Mark Rutland <mark.rutland@arm.com>=0A=
> Cc: linux-crypto@vger.kernel.org=0A=
> Cc: devicetree@vger.kernel.org=0A=
> Cc: linux-input@vger.kernel.org=0A=
Reviewed-by: Horia Geant=E3 <horia.geanta@nxp.com>=0A=
=0A=
> ---=0A=
>  .../devicetree/bindings/crypto/fsl-sec4.txt     | 17 +++++++++++++++++=
=0A=
>  arch/arm/boot/dts/imx7s.dtsi                    |  2 ++=0A=
>  2 files changed, 19 insertions(+)=0A=
> =0A=
> diff --git a/Documentation/devicetree/bindings/crypto/fsl-sec4.txt b/Docu=
mentation/devicetree/bindings/crypto/fsl-sec4.txt=0A=
> index 2fe245ca816a..755c2838d658 100644=0A=
> --- a/Documentation/devicetree/bindings/crypto/fsl-sec4.txt=0A=
> +++ b/Documentation/devicetree/bindings/crypto/fsl-sec4.txt=0A=
> @@ -449,6 +449,19 @@ System ON/OFF key driver=0A=
>        Value type: <phandle>=0A=
>        Definition: this is phandle to the register map node.=0A=
>  =0A=
> +   - clocks=0A=
> +      Usage: optional, required if SNVS LP requires explicit=0A=
> +          enablement of clocks=0A=
> +      Value type: <prop_encoded-array>=0A=
> +      Definition:  a clock specifier describing the clock required for=
=0A=
> +          enabling and disabling SNVS LP RTC.=0A=
> +=0A=
> +   - clock-names=0A=
> +      Usage: optional, required if SNVS LP requires explicit=0A=
> +          enablement of clocks=0A=
> +      Value type: <string>=0A=
> +      Definition: clock name string should be "snvs-pwrkey".=0A=
> +=0A=
>  EXAMPLE:=0A=
>  	snvs-pwrkey@020cc000 {=0A=
>  		compatible =3D "fsl,sec-v4.0-pwrkey";=0A=
> @@ -456,6 +469,8 @@ EXAMPLE:=0A=
>  		interrupts =3D <0 4 0x4>=0A=
>  	        linux,keycode =3D <116>; /* KEY_POWER */=0A=
>  		wakeup-source;=0A=
> +		clocks =3D <&clks IMX7D_SNVS_CLK>;=0A=
> +		clock-names =3D "snvs-pwrkey";=0A=
>  	};=0A=
>  =0A=
>  =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A=
> @@ -547,6 +562,8 @@ FULL EXAMPLE=0A=
>  			interrupts =3D <0 4 0x4>;=0A=
>  			linux,keycode =3D <116>; /* KEY_POWER */=0A=
>  			wakeup-source;=0A=
> +			clocks =3D <&clks IMX7D_SNVS_CLK>;=0A=
> +			clock-names =3D "snvs-pwrkey";=0A=
>  		};=0A=
>  	};=0A=
>  =0A=
> diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi=
=0A=
> index 1b812f4e7453..6240a6f58048 100644=0A=
> --- a/arch/arm/boot/dts/imx7s.dtsi=0A=
> +++ b/arch/arm/boot/dts/imx7s.dtsi=0A=
> @@ -614,6 +614,8 @@=0A=
>  					linux,keycode =3D <KEY_POWER>;=0A=
>  					wakeup-source;=0A=
>  					status =3D "disabled";=0A=
> +					clocks =3D <&clks IMX7D_SNVS_CLK>;=0A=
> +					clock-names =3D "snvs-pwrkey";=0A=
>  				};=0A=
>  			};=0A=
>  =0A=
> =0A=